Skip to content

[libgpiod] Add new port.#23221

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
sylvain-prevost:libgpiod
Feb 23, 2022
Merged

[libgpiod] Add new port.#23221
vicroms merged 5 commits intomicrosoft:masterfrom
sylvain-prevost:libgpiod

Conversation

@sylvain-prevost
Copy link
Contributor

Describe the pull request
Add [libgpiod] port

  • What does your PR fix?

New Port - add support for libgpiod package (https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/).
libgpio: C library and tools for interacting with the linux GPIO character device (gpiod stands for GPIO device).
This port only builds the library part to keep licensing under LGPLv2.1-or-later.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

linux, No

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libgpiod but no changes to version or port version.
-- Version: 1.6.3
-- Old SHA: 98b005671873a0755f4e3135e53fa6d2caf92197
-- New SHA: bee35d9df1cadb1f55fa8db8219c3f450944c33a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@sylvain-prevost
Copy link
Contributor Author

The port explicitly does target only Linux (x64 & arm64), yet it fails on x86 windows (build machine does not find python...).
Seems like a CI setup issue.. Not sure how to move on from there.

@sylvain-prevost sylvain-prevost marked this pull request as ready for review February 22, 2022 07:54
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 22, 2022
@JonLiu1993
Copy link
Contributor

@sylvain-prevost ,Thanks for your pr, please run the command "./vcpkg x-add-version libgpiod --overwrite-version" and commit again

@sylvain-prevost
Copy link
Contributor Author

Updated the hash as instructed.

Now it is failing on osx (was fine yesterday..).
I'm not able to understand/guess the origin of the pb with the CI error log.
Or I do not know where to look for something more meaningful than

[Build vcpkg]

  • [command]/bin/bash /Users/vagrant/Data/work/_temp/b35dac1a-4f0f-4338-9230-6d0848c5dc85.sh
  • Downloading vcpkg-macos...
  • curl: (22) The requested URL returned error: 503').

or
[Artifact]

  • Not found PathtoPublish: /Users/vagrant/Data/work/1/a/failure-logs'

Would welcome any hint on what to look for...

@sylvain-prevost
Copy link
Contributor Author

Simply deleted empty lines & properly updated the hash to re-trigger the CI, and now again failing windows (static)...
?? something funky going on.

@JonLiu1993
Copy link
Contributor

Simply deleted empty lines & properly updated the hash to re-trigger the CI, and now again failing windows (static)... ?? something funky going on.

I re-run ci and it looks like ci is happy now

@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 23, 2022
@vicroms vicroms merged commit 3a45c58 into microsoft:master Feb 23, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 27, 2022
* master: (57 commits)
  [vcpkg-tools] update cmake and git (windows only) (microsoft#22985)
  Update vcpkg tool to 2022-02-24. (microsoft#23162)
  [vcpkg baseline] Move cspice headers (microsoft#23272)
  Fixed inaccurate Chinese words (microsoft#23179)
  [vcpkg] Add fixed changelog generator. (microsoft#23255)
  [authentication.md] Add Jenkins section (microsoft#23226)
  [vcpkg] Meson osx sysroot (microsoft#21772)
  [pkgconf] enable search for system libs on linux (microsoft#23010)
  [yasm/yasm-tool] Incorporate yasm-tool into yasm (microsoft#23218)
  [lapack-reference] Update to 3.10 (microsoft#23228)
  [skia] Arm64 for skia on osx (microsoft#23222)
  [libfido2] Update to 1.10.0 (microsoft#23241)
  [Tracy] Fixing issue where version 0.7.8 was pulling the wrong version (microsoft#23061)
  [libgpiod] Add new port. (microsoft#23221)
  [drogon] Update to 1.7.5 (microsoft#23227)
  [tinyexif] Remove from fail list. (microsoft#23163)
  [vcpkg docs][ES] Sync with English readme (microsoft#19834) (microsoft#22618)
  [vcpkg baseline][libao] Disable dlfcn check under windows (microsoft#23235)
  [OpenCV] upgrade to v4.5.5 (microsoft#22801)
  [libcurl-simple-https] New port (microsoft#22917)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants