Skip to content

[yasm/yasm-tool] Incorporate yasm-tool into yasm#23218

Merged
vicroms merged 8 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/18816
Feb 24, 2022
Merged

[yasm/yasm-tool] Incorporate yasm-tool into yasm#23218
vicroms merged 8 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/18816

Conversation

@JackBoosY
Copy link
Contributor

Since port yasm and yasm-tool repo is same and generate the same files, remove port yasm-tool and switch the related dependency item yasm-tool to yasm.

Fixes #18746.

Replace #18816.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Feb 22, 2022
@JackBoosY JackBoosY requested a review from BillyONeal February 22, 2022 06:37
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY
Copy link
Contributor Author

@BillyONeal I removed the script changes, please review again.

Thanks.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 24, 2022
@vicroms vicroms merged commit b7a1088 into microsoft:master Feb 24, 2022
@JackBoosY JackBoosY deleted the dev/jack/18816 branch February 25, 2022 02:20
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 27, 2022
* master: (57 commits)
  [vcpkg-tools] update cmake and git (windows only) (microsoft#22985)
  Update vcpkg tool to 2022-02-24. (microsoft#23162)
  [vcpkg baseline] Move cspice headers (microsoft#23272)
  Fixed inaccurate Chinese words (microsoft#23179)
  [vcpkg] Add fixed changelog generator. (microsoft#23255)
  [authentication.md] Add Jenkins section (microsoft#23226)
  [vcpkg] Meson osx sysroot (microsoft#21772)
  [pkgconf] enable search for system libs on linux (microsoft#23010)
  [yasm/yasm-tool] Incorporate yasm-tool into yasm (microsoft#23218)
  [lapack-reference] Update to 3.10 (microsoft#23228)
  [skia] Arm64 for skia on osx (microsoft#23222)
  [libfido2] Update to 1.10.0 (microsoft#23241)
  [Tracy] Fixing issue where version 0.7.8 was pulling the wrong version (microsoft#23061)
  [libgpiod] Add new port. (microsoft#23221)
  [drogon] Update to 1.7.5 (microsoft#23227)
  [tinyexif] Remove from fail list. (microsoft#23163)
  [vcpkg docs][ES] Sync with English readme (microsoft#19834) (microsoft#22618)
  [vcpkg baseline][libao] Disable dlfcn check under windows (microsoft#23235)
  [OpenCV] upgrade to v4.5.5 (microsoft#22801)
  [libcurl-simple-https] New port (microsoft#22917)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[yasm] Dependent library of yasm binary is missing

4 participants