Skip to content

Conversation

@jurokapsiar
Copy link
Contributor

Remove v0 dependency from v0 compat package as the import was pulling unnecessary files and running unnecessary initialization.

@jurokapsiar jurokapsiar requested a review from a team as a code owner January 10, 2024 07:52
@fabricteam
Copy link
Collaborator

fabricteam commented Jan 10, 2024

📊 Bundle size report

🤖 This report was generated against 2c18f0f68fccba9eebaddb7d3dfdf68917dcf57b

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 93bf217:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jan 10, 2024

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2c18f0f68fccba9eebaddb7d3dfdf68917dcf57b (build)

@jurokapsiar jurokapsiar merged commit 37f8222 into microsoft:master Jan 10, 2024
@jurokapsiar jurokapsiar deleted the jukapsia/remove-v0-dependency branch January 10, 2024 09:41
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jan 10, 2024
* master: (166 commits)
  Remove v0 dependency from v0 compat package (microsoft#30276)
  applying package updates
  Disallow `window` and `document` access for `@fluentui/react` and related packages. (microsoft#30063)
  Update Rating api and stories (microsoft#30092)
  TeachingPopover: Minor style changes (microsoft#30270)
  feat(scripts-gulp): replace lerna with nx (microsoft#30266)
  ci: remove canary and nightly functionality from northstar (microsoft#30264)
  List: Re-initialize on mount in React 18. (microsoft#29881)
  feat(scripts-monorepo): replace lerna/utils with pure nx apis (microsoft#30178)
  chore: remove react-timepicker-compat-preview (microsoft#30263)
  applying package updates
  feat(TimePicker-compat): stable release  (microsoft#30217)
  feat: Implement onPositioningEnd callback (microsoft#30177)
  applying package updates
  v8 registerIcons compat (microsoft#30003)
  Adding Planner, ToDoItem and updated Project filetype icons. Updating FabricCDN url to latest datecode. (microsoft#30079)
  Scaffolds more Nav components (microsoft#30227)
  chore: migrate to nx 17.2 (microsoft#30187)
  applying package updates
  feat: Update position when target or container dimensions change (microsoft#30179)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants