Skip to content

v8 registerIcons compat #30003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomi-msft merged 13 commits into from
Jan 9, 2024
Merged

v8 registerIcons compat #30003

tomi-msft merged 13 commits into from
Jan 9, 2024

Conversation

@tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented Dec 5, 2023 •
edited
Loading

This PR is to add a package that users can use to access functionality used in v8 icons such as registerIcons without taking a dependency on a v8 package.

Fixes #28603

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 5, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 99e1128925fa5863a99e311884cc2c710c2606bd

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 5, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 72f8e7e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 5, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 654 663 5000
Button mount 296 314 5000
Field mount 1117 1151 5000
FluentProvider mount 720 724 5000
FluentProviderWithTheme mount 83 95 10
FluentProviderWithTheme virtual-rerender 71 62 10
FluentProviderWithTheme virtual-rerender-with-unmount 85 83 10
MakeStyles mount 857 896 50000
Persona mount 1778 1740 5000
SpinButton mount 1447 1411 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 5, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 5, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 166 152 1.09:1
CarouselMinimalPerf.default 270 251 1.08:1
LabelMinimalPerf.default 218 204 1.07:1
ListNestedPerf.default 320 301 1.06:1
ButtonMinimalPerf.default 84 80 1.05:1
AnimationMinimalPerf.default 304 293 1.04:1
AttachmentMinimalPerf.default 81 78 1.04:1
PortalMinimalPerf.default 86 83 1.04:1
RadioGroupMinimalPerf.default 261 251 1.04:1
TextMinimalPerf.default 195 187 1.04:1
BoxMinimalPerf.default 189 184 1.03:1
ListMinimalPerf.default 311 301 1.03:1
PopupMinimalPerf.default 362 350 1.03:1
TextAreaMinimalPerf.default 281 274 1.03:1
ButtonSlotsPerf.default 313 307 1.02:1
ProviderMergeThemesPerf.default 651 639 1.02:1
RefMinimalPerf.default 104 102 1.02:1
SegmentMinimalPerf.default 197 193 1.02:1
TableManyItemsPerf.default 1095 1077 1.02:1
TableMinimalPerf.default 241 236 1.02:1
ToolbarMinimalPerf.default 533 520 1.02:1
ChatWithPopoverPerf.default 191 190 1.01:1
DialogMinimalPerf.default 443 437 1.01:1
EmbedMinimalPerf.default 1882 1868 1.01:1
InputMinimalPerf.default 543 539 1.01:1
ListCommonPerf.default 388 383 1.01:1
RosterPerf.default 1549 1541 1.01:1
ProviderMinimalPerf.default 197 196 1.01:1
SliderMinimalPerf.default 744 737 1.01:1
SplitButtonMinimalPerf.default 2234 2212 1.01:1
TreeWith60ListItems.default 83 82 1.01:1
AttachmentSlotsPerf.default 663 661 1:1
ButtonOverridesMissPerf.default 658 657 1:1
CheckboxMinimalPerf.default 1116 1121 1:1
DropdownMinimalPerf.default 1414 1415 1:1
FormMinimalPerf.default 217 218 1:1
HeaderSlotsPerf.default 461 462 1:1
LayoutMinimalPerf.default 203 202 1:1
MenuButtonMinimalPerf.default 927 928 1:1
ReactionMinimalPerf.default 209 208 1:1
StatusMinimalPerf.default 379 380 1:1
TooltipMinimalPerf.default 1257 1261 1:1
AvatarMinimalPerf.default 111 112 0.99:1
GridMinimalPerf.default 183 185 0.99:1
ItemLayoutMinimalPerf.default 699 705 0.99:1
ListWith60ListItems.default 362 366 0.99:1
TreeMinimalPerf.default 465 469 0.99:1
DividerMinimalPerf.default 195 199 0.98:1
DropdownManyItemsPerf.default 382 390 0.98:1
ImageMinimalPerf.default 223 227 0.98:1
LoaderMinimalPerf.default 182 185 0.98:1
AlertMinimalPerf.default 154 159 0.97:1
CardMinimalPerf.default 297 306 0.97:1
CustomToolbarPrototype.default 1437 1486 0.97:1
HeaderMinimalPerf.default 196 204 0.96:1
MenuMinimalPerf.default 474 496 0.96:1
IconMinimalPerf.default 383 399 0.96:1
VideoMinimalPerf.default 433 452 0.96:1
DatepickerMinimalPerf.default 3709 3909 0.95:1
SkeletonMinimalPerf.default 194 204 0.95:1
ChatDuplicateMessagesPerf.default 147 156 0.94:1
ChatMinimalPerf.default 410 450 0.91:1
AccordionMinimalPerf.default 74 84 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 5, 2023 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 5, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 5, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 634 634 5000
Breadcrumb mount 1693 1672 1000
Checkbox mount 1674 1723 5000
CheckboxBase mount 1485 1476 5000
ChoiceGroup mount 2985 2984 5000
ComboBox mount 655 669 1000
CommandBar mount 6245 6237 1000
ContextualMenu mount 13467 13504 1000
DefaultButton mount 762 761 5000
DetailsRow mount 2204 2203 5000
DetailsRowFast mount 2239 2225 5000
DetailsRowNoStyles mount 2020 2042 5000
Dialog mount 2657 2772 1000
DocumentCardTitle mount 214 228 1000
Dropdown mount 2018 1990 5000
FocusTrapZone mount 1161 1158 5000
FocusZone mount 1055 1081 5000
GroupedList mount 41418 41664 2
GroupedList virtual-rerender 20056 19818 2
GroupedList virtual-rerender-with-unmount 50785 50993 2
GroupedListV2 mount 233 230 2
GroupedListV2 virtual-rerender 209 209 2
GroupedListV2 virtual-rerender-with-unmount 229 236 2
IconButton mount 1078 1100 5000
Label mount 333 339 5000
Layer mount 2768 2700 5000
Link mount 396 394 5000
MenuButton mount 961 976 5000
MessageBar mount 21460 21535 5000
Nav mount 1942 1952 1000
OverflowSet mount 787 783 5000
Panel mount 1839 1764 1000
Persona mount 734 767 1000
Pivot mount 870 898 1000
PrimaryButton mount 872 865 5000
Rating mount 4648 4606 5000
SearchBox mount 900 918 5000
Shimmer mount 1867 1873 5000
Slider mount 1332 1312 5000
SpinButton mount 2927 2920 5000
Spinner mount 388 394 5000
SplitButton mount 1788 1845 5000
Stack mount 413 409 5000
StackWithIntrinsicChildren mount 891 845 5000
StackWithTextChildren mount 2586 2608 5000
SwatchColorPicker mount 6238 6202 5000
TagPicker mount 1488 1476 5000
Text mount 378 372 5000
TextField mount 948 942 5000
ThemeProvider mount 830 828 5000
ThemeProvider virtual-rerender 587 591 5000
ThemeProvider virtual-rerender-with-unmount 1266 1260 5000
Toggle mount 611 601 5000
buttonNative mount 197 198 5000

khmakoto
khmakoto reviewed Dec 6, 2023
View reviewed changes
@size-auditor
Copy link

size-auditor bot commented Dec 6, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 99e1128925fa5863a99e311884cc2c710c2606bd (build)

@Hotell Hotell self-requested a review December 19, 2023 13:21
@Hotell
Copy link
Contributor

Hotell commented Dec 22, 2023

can we please dissect this PR into 2 to follow our workflows and more focused review process ?

  • 1st PR -> only boostraping new package
  • 2nd PR -> contains implementation

ty

@tomi-msft tomi-msft mentioned this pull request Jan 4, 2024
Merged
@github-actions github-actions bot removed this from the December Project Cycle Q1 2023 milestone Jan 4, 2024
@github-actions github-actions bot added this to the January Project Cycle Q1 2024 milestone Jan 4, 2024
@tomi-msft tomi-msft requested a review from a team as a code owner January 5, 2024 18:12
@tomi-msft
Copy link
Contributor Author

tomi-msft commented Jan 5, 2024

can we please dissect this PR into 2 to follow our workflows and more focused review process ?

  • 1st PR -> only boostraping new package
  • 2nd PR -> contains implementation

ty

I've split the PRs into two, with this PR only containing the implementation

@tomi-msft
Copy link
Contributor Author

tomi-msft commented Jan 5, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 5, 2024

Azure Pipelines successfully started running 4 pipeline(s).

@khmakoto
Copy link
Member

khmakoto commented Jan 5, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 5, 2024

Azure Pipelines successfully started running 4 pipeline(s).

@khmakoto
Copy link
Member

khmakoto commented Jan 5, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 5, 2024

Azure Pipelines successfully started running 4 pipeline(s).

@tomi-msft
Copy link
Contributor Author

tomi-msft commented Jan 5, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 5, 2024

Azure Pipelines successfully started running 4 pipeline(s).

@khmakoto
Copy link
Member

khmakoto commented Jan 5, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 5, 2024

Azure Pipelines successfully started running 4 pipeline(s).

@tomi-msft
Copy link
Contributor Author

tomi-msft commented Jan 8, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 8, 2024

Azure Pipelines successfully started running 4 pipeline(s).

khmakoto
khmakoto reviewed Jan 8, 2024
View reviewed changes
@tomi-msft tomi-msft merged commit 6eaad68 into microsoft:master Jan 9, 2024
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jan 10, 2024
@marcosmoura
Merge branch 'master' into fix/react-card/keyboard-focus-regression
5617a43 
* master: (166 commits)
  Remove v0 dependency from v0 compat package (microsoft#30276)
  applying package updates
  Disallow `window` and `document` access for `@fluentui/react` and related packages. (microsoft#30063)
  Update Rating api and stories (microsoft#30092)
  TeachingPopover: Minor style changes (microsoft#30270)
  feat(scripts-gulp): replace lerna with nx (microsoft#30266)
  ci: remove canary and nightly functionality from northstar (microsoft#30264)
  List: Re-initialize on mount in React 18. (microsoft#29881)
  feat(scripts-monorepo): replace lerna/utils with pure nx apis (microsoft#30178)
  chore: remove react-timepicker-compat-preview (microsoft#30263)
  applying package updates
  feat(TimePicker-compat): stable release  (microsoft#30217)
  feat: Implement onPositioningEnd callback (microsoft#30177)
  applying package updates
  v8 registerIcons compat (microsoft#30003)
  Adding Planner, ToDoItem and updated Project filetype icons. Updating FabricCDN url to latest datecode. (microsoft#30079)
  Scaffolds more Nav components (microsoft#30227)
  chore: migrate to nx 17.2 (microsoft#30187)
  applying package updates
  feat: Update position when target or container dimensions change (microsoft#30179)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khmakoto khmakoto khmakoto approved these changes

@JustSlone JustSlone Awaiting requested review from JustSlone

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@tudorpopams tudorpopams Awaiting requested review from tudorpopams

@Hotell Hotell Awaiting requested review from Hotell

Assignees

No one assigned

Labels

Area: Icons

Projects

None yet

Milestone

January Project Cycle Q1 2024

Development

Successfully merging this pull request may close these issues.

Create new package for registerIcons to split it out from font-icons-mdl2

4 participants

@tomi-msft @fabricteam @Hotell @khmakoto