Scaffolds more Nav components #30227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 83 | 74 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 621 | 624 | 5000 | |
| Button | mount | 322 | 300 | 5000 | |
| Field | mount | 1121 | 1125 | 5000 | |
| FluentProvider | mount | 678 | 709 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 65 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 83 | 74 | 10 | Possible regression |
| MakeStyles | mount | 862 | 861 | 50000 | |
| Persona | mount | 1721 | 1746 | 5000 | |
| SpinButton | mount | 1371 | 1392 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c2ec9cc:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| ButtonMinimalPerf.default | 89 | 82 | 1.09:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 87 | 80 | 1.09:1 |
| AttachmentMinimalPerf.default | 86 | 79 | 1.09:1 |
| BoxMinimalPerf.default | 203 | 190 | 1.07:1 |
| AnimationMinimalPerf.default | 311 | 294 | 1.06:1 |
| AvatarMinimalPerf.default | 114 | 108 | 1.06:1 |
| CarouselMinimalPerf.default | 267 | 255 | 1.05:1 |
| TooltipMinimalPerf.default | 1308 | 1244 | 1.05:1 |
| FlexMinimalPerf.default | 155 | 149 | 1.04:1 |
| ReactionMinimalPerf.default | 219 | 211 | 1.04:1 |
| TreeWith60ListItems.default | 96 | 92 | 1.04:1 |
| AttachmentSlotsPerf.default | 666 | 644 | 1.03:1 |
| ChatWithPopoverPerf.default | 199 | 194 | 1.03:1 |
| GridMinimalPerf.default | 198 | 192 | 1.03:1 |
| HeaderMinimalPerf.default | 211 | 205 | 1.03:1 |
| ListNestedPerf.default | 322 | 313 | 1.03:1 |
| SegmentMinimalPerf.default | 200 | 194 | 1.03:1 |
| TableManyItemsPerf.default | 1119 | 1085 | 1.03:1 |
| ButtonSlotsPerf.default | 309 | 302 | 1.02:1 |
| DropdownManyItemsPerf.default | 400 | 391 | 1.02:1 |
| HeaderSlotsPerf.default | 476 | 465 | 1.02:1 |
| InputMinimalPerf.default | 551 | 541 | 1.02:1 |
| LabelMinimalPerf.default | 219 | 215 | 1.02:1 |
| LayoutMinimalPerf.default | 201 | 197 | 1.02:1 |
| ListMinimalPerf.default | 316 | 309 | 1.02:1 |
| LoaderMinimalPerf.default | 192 | 189 | 1.02:1 |
| ProviderMinimalPerf.default | 205 | 200 | 1.02:1 |
| RadioGroupMinimalPerf.default | 258 | 254 | 1.02:1 |
| ToolbarMinimalPerf.default | 540 | 532 | 1.02:1 |
| DropdownMinimalPerf.default | 1441 | 1427 | 1.01:1 |
| PopupMinimalPerf.default | 350 | 346 | 1.01:1 |
| ButtonOverridesMissPerf.default | 645 | 642 | 1:1 |
| DatepickerMinimalPerf.default | 3595 | 3608 | 1:1 |
| EmbedMinimalPerf.default | 1876 | 1879 | 1:1 |
| MenuButtonMinimalPerf.default | 955 | 952 | 1:1 |
| RosterPerf.default | 1577 | 1578 | 1:1 |
| PortalMinimalPerf.default | 82 | 82 | 1:1 |
| SliderMinimalPerf.default | 738 | 737 | 1:1 |
| IconMinimalPerf.default | 379 | 380 | 1:1 |
| TableMinimalPerf.default | 234 | 233 | 1:1 |
| CustomToolbarPrototype.default | 1469 | 1470 | 1:1 |
| TreeMinimalPerf.default | 477 | 476 | 1:1 |
| DialogMinimalPerf.default | 437 | 442 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2257 | 2282 | 0.99:1 |
| TextMinimalPerf.default | 188 | 190 | 0.99:1 |
| AlertMinimalPerf.default | 153 | 156 | 0.98:1 |
| CheckboxMinimalPerf.default | 1140 | 1162 | 0.98:1 |
| DividerMinimalPerf.default | 205 | 210 | 0.98:1 |
| ListCommonPerf.default | 386 | 393 | 0.98:1 |
| RefMinimalPerf.default | 106 | 108 | 0.98:1 |
| SkeletonMinimalPerf.default | 197 | 201 | 0.98:1 |
| StatusMinimalPerf.default | 403 | 410 | 0.98:1 |
| ItemLayoutMinimalPerf.default | 714 | 738 | 0.97:1 |
| MenuMinimalPerf.default | 499 | 513 | 0.97:1 |
| ProviderMergeThemesPerf.default | 643 | 661 | 0.97:1 |
| TextAreaMinimalPerf.default | 286 | 298 | 0.96:1 |
| VideoMinimalPerf.default | 429 | 447 | 0.96:1 |
| ChatMinimalPerf.default | 416 | 437 | 0.95:1 |
| ImageMinimalPerf.default | 216 | 228 | 0.95:1 |
| ListWith60ListItems.default | 342 | 359 | 0.95:1 |
| CardMinimalPerf.default | 289 | 311 | 0.93:1 |
| FormMinimalPerf.default | 212 | 227 | 0.93:1 |
| ChatDuplicateMessagesPerf.default | 138 | 155 | 0.89:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report🤖 This report was generated against 03a5780b5def7f81f780fce0c00252b9653ead53 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 03a5780b5def7f81f780fce0c00252b9653ead53 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
mltejera
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 616 | 624 | 5000 | |
| Breadcrumb | mount | 1677 | 1657 | 1000 | |
| Checkbox | mount | 1691 | 1704 | 5000 | |
| CheckboxBase | mount | 1489 | 1475 | 5000 | |
| ChoiceGroup | mount | 2903 | 2949 | 5000 | |
| ComboBox | mount | 669 | 673 | 1000 | |
| CommandBar | mount | 6274 | 6293 | 1000 | |
| ContextualMenu | mount | 14932 | 13307 | 1000 | |
| DefaultButton | mount | 763 | 753 | 5000 | |
| DetailsRow | mount | 2249 | 2183 | 5000 | |
| DetailsRowFast | mount | 2200 | 2199 | 5000 | |
| DetailsRowNoStyles | mount | 2007 | 2034 | 5000 | |
| Dialog | mount | 2813 | 2646 | 1000 | |
| DocumentCardTitle | mount | 220 | 227 | 1000 | |
| Dropdown | mount | 1967 | 2000 | 5000 | |
| FocusTrapZone | mount | 1169 | 1098 | 5000 | |
| FocusZone | mount | 1114 | 1070 | 5000 | |
| GroupedList | mount | 41945 | 41837 | 2 | |
| GroupedList | virtual-rerender | 20115 | 20117 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51328 | 51531 | 2 | |
| GroupedListV2 | mount | 224 | 255 | 2 | |
| GroupedListV2 | virtual-rerender | 211 | 209 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 234 | 227 | 2 | |
| IconButton | mount | 1071 | 1101 | 5000 | |
| Label | mount | 336 | 344 | 5000 | |
| Layer | mount | 2795 | 2783 | 5000 | |
| Link | mount | 385 | 406 | 5000 | |
| MenuButton | mount | 943 | 935 | 5000 | |
| MessageBar | mount | 21891 | 21555 | 5000 | |
| Nav | mount | 1940 | 1984 | 1000 | |
| OverflowSet | mount | 821 | 772 | 5000 | |
| Panel | mount | 2064 | 1783 | 1000 | |
| Persona | mount | 726 | 729 | 1000 | |
| Pivot | mount | 880 | 879 | 1000 | |
| PrimaryButton | mount | 838 | 834 | 5000 | |
| Rating | mount | 4578 | 4596 | 5000 | |
| SearchBox | mount | 879 | 905 | 5000 | |
| Shimmer | mount | 1896 | 1858 | 5000 | |
| Slider | mount | 1298 | 1282 | 5000 | |
| SpinButton | mount | 2855 | 2900 | 5000 | |
| Spinner | mount | 397 | 383 | 5000 | |
| SplitButton | mount | 1854 | 1849 | 5000 | |
| Stack | mount | 452 | 396 | 5000 | |
| StackWithIntrinsicChildren | mount | 871 | 851 | 5000 | |
| StackWithTextChildren | mount | 2568 | 2568 | 5000 | |
| SwatchColorPicker | mount | 6070 | 6096 | 5000 | |
| TagPicker | mount | 1429 | 1451 | 5000 | |
| Text | mount | 368 | 372 | 5000 | |
| TextField | mount | 904 | 936 | 5000 | |
| ThemeProvider | mount | 827 | 825 | 5000 | |
| ThemeProvider | virtual-rerender | 600 | 594 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1264 | 1255 | 5000 | |
| Toggle | mount | 610 | 590 | 5000 | |
| buttonNative | mount | 193 | 190 | 5000 |
khmakoto
approved these changes
Jan 5, 2024
packages/react-components/react-nav-preview/src/components/Nav/index.ts
Outdated
Show resolved
Hide resolved
…/index.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…nts' of https://github.com/mltejera/office-ui-fabric-react into user/matejera/scaffold-remaining-accordion-like-components
Leolewin
pushed a commit
to Leolewin/fluentui
that referenced
this pull request
Jan 9, 2024
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jan 10, 2024
* master: (166 commits) Remove v0 dependency from v0 compat package (microsoft#30276) applying package updates Disallow `window` and `document` access for `@fluentui/react` and related packages. (microsoft#30063) Update Rating api and stories (microsoft#30092) TeachingPopover: Minor style changes (microsoft#30270) feat(scripts-gulp): replace lerna with nx (microsoft#30266) ci: remove canary and nightly functionality from northstar (microsoft#30264) List: Re-initialize on mount in React 18. (microsoft#29881) feat(scripts-monorepo): replace lerna/utils with pure nx apis (microsoft#30178) chore: remove react-timepicker-compat-preview (microsoft#30263) applying package updates feat(TimePicker-compat): stable release (microsoft#30217) feat: Implement onPositioningEnd callback (microsoft#30177) applying package updates v8 registerIcons compat (microsoft#30003) Adding Planner, ToDoItem and updated Project filetype icons. Updating FabricCDN url to latest datecode. (microsoft#30079) Scaffolds more Nav components (microsoft#30227) chore: migrate to nx 17.2 (microsoft#30187) applying package updates feat: Update position when target or container dimensions change (microsoft#30179) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scaffolds out a few more components, and tidies the exports.
This is intended to re-implement the accordion component.
NavCategory -> AccordionItem
NavCategoryItem -> AccordionHeader // this already exists
NavSubItemGroup -> AccordionPanel
#26649