Update Rating api and stories #30092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact-rating-api-update
Collaborator
📊 Bundle size report🤖 This report was generated against ab88e52430e612598d9dab20edbaea09346bc0d8 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 53e0c4c:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ab88e52430e612598d9dab20edbaea09346bc0d8 (build) |
Closed
khmakoto
reviewed
Jan 5, 2024
packages/react-components/react-rating-preview/src/components/Rating/useRating.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/index.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/index.stories.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
modified the milestones:
December Project Cycle Q1 2023,
January Project Cycle Q1 2024
behowell
reviewed
Jan 8, 2024
packages/react-components/react-rating-preview/src/components/Rating/Rating.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/Rating/Rating.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/Rating/Rating.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/RatingAppearance.stories.tsx
Outdated
Show resolved
Hide resolved
khmakoto
reviewed
Jan 9, 2024
change/@fluentui-react-rating-preview-94bd847c-77c5-4f2e-8000-acbceb63aa7e.json
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/RatingColor.stories.tsx
Outdated
Show resolved
Hide resolved
khmakoto
approved these changes
Jan 9, 2024
behowell
reviewed
Jan 9, 2024
packages/react-components/react-rating-preview/src/components/Rating/Rating.types.ts
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/RatingItem/useRatingItem.tsx
Show resolved
Hide resolved
...eact-components/react-rating-preview/src/components/RatingItem/useRatingItemStyles.styles.ts
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/RatingMode.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/RatingMode.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/RatingSize.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/RatingStep.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-rating-preview/stories/Rating/RatingColor.stories.tsx
Show resolved
Hide resolved
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jan 10, 2024
* master: (166 commits) Remove v0 dependency from v0 compat package (microsoft#30276) applying package updates Disallow `window` and `document` access for `@fluentui/react` and related packages. (microsoft#30063) Update Rating api and stories (microsoft#30092) TeachingPopover: Minor style changes (microsoft#30270) feat(scripts-gulp): replace lerna with nx (microsoft#30266) ci: remove canary and nightly functionality from northstar (microsoft#30264) List: Re-initialize on mount in React 18. (microsoft#29881) feat(scripts-monorepo): replace lerna/utils with pure nx apis (microsoft#30178) chore: remove react-timepicker-compat-preview (microsoft#30263) applying package updates feat(TimePicker-compat): stable release (microsoft#30217) feat: Implement onPositioningEnd callback (microsoft#30177) applying package updates v8 registerIcons compat (microsoft#30003) Adding Planner, ToDoItem and updated Project filetype icons. Updating FabricCDN url to latest datecode. (microsoft#30079) Scaffolds more Nav components (microsoft#30227) chore: migrate to nx 17.2 (microsoft#30187) applying package updates feat: Update position when target or container dimensions change (microsoft#30179) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the Rating api to remove the
compactandreadonlyprops and add themodeprop. It also updates the stories and adds theSPEC.mdfile.