Skip to content

Remove v0 dependency from v0 compat package #30276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurokapsiar merged 3 commits into from
Jan 10, 2024
Merged

Remove v0 dependency from v0 compat package #30276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
820f901
Remove v0 dependency from v0 compat package
Jan 10, 2024
fc2b83f
change
jurokapsiar Jan 10, 2024
93bf217
fix deps
jurokapsiar Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-migration-v0-v9-f1f7af36-9864-40cc-8dad-6ad1306da991.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Remove dependency on v0",
"packageName": "@fluentui/react-migration-v0-v9",
"email": "jurokapsiar@gmail.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-migration-v0-v9/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"@fluentui/eslint-plugin": "*",
"@fluentui/react-conformance": "*",
"@fluentui/react-conformance-griffel": "*",
"@fluentui/react-northstar": "*",
"@fluentui/scripts-api-extractor": "*",
"@fluentui/scripts-tasks": "*",
"@fluentui/scripts-storybook": "*"
Expand All @@ -37,7 +38,6 @@
"@fluentui/react-context-selector": "^9.1.46",
"@fluentui/react-icons": "^2.0.224",
"@fluentui/react-jsx-runtime": "^9.0.24",
"@fluentui/react-northstar": "^0.66.4",
"@fluentui/react-shared-contexts": "^9.13.2",
"@fluentui/react-tabster": "^9.17.0",
"@fluentui/react-theme": "^9.1.16",
Expand Down
7 changes: 6 additions & 1 deletion ...es/react-components/react-migration-v0-v9/src/components/Button/ButtonMigration.mixins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import { GriffelStyle, shorthands } from '@fluentui/react-components';
import { iconClassNames } from '@fluentui/react-northstar';
import { iconFilledClassName, iconRegularClassName } from '@fluentui/react-icons';

// class names from v0 - not imported as we do not want to keep depending on v0.
const iconClassNames = {
filled: 'ui-icon__filled',
outline: 'ui-icon__outline',
};

export const v9HoverClasses = (): GriffelStyle => ({
[`& .${iconFilledClassName}`]: {
display: 'none',
Expand Down