React icons utility package scaffold #30226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-msft
requested review from
a team,
GeoffCoxMSFT,
JustSlone,
Mitch-At-Work,
behowell,
jurokapsiar,
khmakoto,
micahgodbolt,
ms-acalzaretto,
smhigley,
sopranopillow,
spmonahan and
tudorpopams
as code owners
behowell
previously requested changes
Jan 4, 2024
Contributor
behowell
left a comment
behowell
left a comment
There was a problem hiding this comment.
This PR seems to be combining a version bump of react-icons, with the scaffolding of the new package. Please split out the react-icons version bump into a separate PR. Thanks!
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 72 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 619 | 614 | 5000 | |
| Button | mount | 302 | 304 | 5000 | |
| Field | mount | 1136 | 1116 | 5000 | |
| FluentProvider | mount | 713 | 720 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 63 | 63 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 72 | 10 | Possible regression |
| MakeStyles | mount | 851 | 861 | 50000 | |
| Persona | mount | 1743 | 1692 | 5000 | |
| SpinButton | mount | 1348 | 1385 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f846c8:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AccordionMinimalPerf.default | 89 | 85 | 1.05:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| LabelMinimalPerf.default | 237 | 214 | 1.11:1 |
| TableMinimalPerf.default | 241 | 224 | 1.08:1 |
| ImageMinimalPerf.default | 236 | 221 | 1.07:1 |
| ProviderMinimalPerf.default | 204 | 191 | 1.07:1 |
| ChatWithPopoverPerf.default | 209 | 197 | 1.06:1 |
| LayoutMinimalPerf.default | 206 | 194 | 1.06:1 |
| ButtonMinimalPerf.default | 86 | 82 | 1.05:1 |
| RefMinimalPerf.default | 113 | 108 | 1.05:1 |
| CustomToolbarPrototype.default | 1525 | 1454 | 1.05:1 |
| TreeWith60ListItems.default | 91 | 87 | 1.05:1 |
| AttachmentSlotsPerf.default | 645 | 618 | 1.04:1 |
| BoxMinimalPerf.default | 206 | 198 | 1.04:1 |
| AvatarMinimalPerf.default | 110 | 107 | 1.03:1 |
| CardMinimalPerf.default | 318 | 310 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 160 | 156 | 1.03:1 |
| DividerMinimalPerf.default | 214 | 208 | 1.03:1 |
| EmbedMinimalPerf.default | 1920 | 1862 | 1.03:1 |
| HeaderMinimalPerf.default | 208 | 201 | 1.03:1 |
| TableManyItemsPerf.default | 1120 | 1092 | 1.03:1 |
| TextMinimalPerf.default | 192 | 186 | 1.03:1 |
| TextAreaMinimalPerf.default | 299 | 291 | 1.03:1 |
| VideoMinimalPerf.default | 429 | 416 | 1.03:1 |
| AlertMinimalPerf.default | 157 | 154 | 1.02:1 |
| AttachmentMinimalPerf.default | 84 | 82 | 1.02:1 |
| FlexMinimalPerf.default | 159 | 156 | 1.02:1 |
| FormMinimalPerf.default | 219 | 215 | 1.02:1 |
| PortalMinimalPerf.default | 89 | 87 | 1.02:1 |
| SliderMinimalPerf.default | 758 | 742 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2307 | 2264 | 1.02:1 |
| ButtonOverridesMissPerf.default | 658 | 652 | 1.01:1 |
| DropdownManyItemsPerf.default | 396 | 391 | 1.01:1 |
| ListCommonPerf.default | 389 | 385 | 1.01:1 |
| ListMinimalPerf.default | 308 | 305 | 1.01:1 |
| LoaderMinimalPerf.default | 203 | 201 | 1.01:1 |
| RosterPerf.default | 1583 | 1563 | 1.01:1 |
| RadioGroupMinimalPerf.default | 256 | 253 | 1.01:1 |
| ReactionMinimalPerf.default | 212 | 210 | 1.01:1 |
| TooltipMinimalPerf.default | 1265 | 1254 | 1.01:1 |
| TreeMinimalPerf.default | 484 | 479 | 1.01:1 |
| AnimationMinimalPerf.default | 298 | 298 | 1:1 |
| DialogMinimalPerf.default | 441 | 442 | 1:1 |
| DropdownMinimalPerf.default | 1434 | 1439 | 1:1 |
| HeaderSlotsPerf.default | 464 | 463 | 1:1 |
| ItemLayoutMinimalPerf.default | 709 | 711 | 1:1 |
| ListWith60ListItems.default | 360 | 360 | 1:1 |
| ProviderMergeThemesPerf.default | 638 | 638 | 1:1 |
| SkeletonMinimalPerf.default | 190 | 190 | 1:1 |
| MenuMinimalPerf.default | 496 | 502 | 0.99:1 |
| MenuButtonMinimalPerf.default | 961 | 975 | 0.99:1 |
| ToolbarMinimalPerf.default | 533 | 541 | 0.99:1 |
| CheckboxMinimalPerf.default | 1157 | 1177 | 0.98:1 |
| InputMinimalPerf.default | 524 | 534 | 0.98:1 |
| SegmentMinimalPerf.default | 193 | 197 | 0.98:1 |
| ButtonSlotsPerf.default | 310 | 320 | 0.97:1 |
| CarouselMinimalPerf.default | 262 | 269 | 0.97:1 |
| GridMinimalPerf.default | 187 | 193 | 0.97:1 |
| ListNestedPerf.default | 318 | 327 | 0.97:1 |
| PopupMinimalPerf.default | 344 | 355 | 0.97:1 |
| IconMinimalPerf.default | 382 | 394 | 0.97:1 |
| DatepickerMinimalPerf.default | 3632 | 3769 | 0.96:1 |
| ChatMinimalPerf.default | 427 | 449 | 0.95:1 |
| StatusMinimalPerf.default | 380 | 398 | 0.95:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 630 | 635 | 5000 | |
| Breadcrumb | mount | 1663 | 1689 | 1000 | |
| Checkbox | mount | 1655 | 1646 | 5000 | |
| CheckboxBase | mount | 1442 | 1481 | 5000 | |
| ChoiceGroup | mount | 2933 | 2992 | 5000 | |
| ComboBox | mount | 657 | 656 | 1000 | |
| CommandBar | mount | 6222 | 6154 | 1000 | |
| ContextualMenu | mount | 12544 | 12873 | 1000 | |
| DefaultButton | mount | 755 | 740 | 5000 | |
| DetailsRow | mount | 2123 | 2227 | 5000 | |
| DetailsRowFast | mount | 2180 | 2164 | 5000 | |
| DetailsRowNoStyles | mount | 2017 | 1990 | 5000 | |
| Dialog | mount | 2639 | 2747 | 1000 | |
| DocumentCardTitle | mount | 228 | 221 | 1000 | |
| Dropdown | mount | 1944 | 1933 | 5000 | |
| FocusTrapZone | mount | 1125 | 1115 | 5000 | |
| FocusZone | mount | 1056 | 1067 | 5000 | |
| GroupedList | mount | 41509 | 41895 | 2 | |
| GroupedList | virtual-rerender | 19986 | 20145 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50987 | 50956 | 2 | |
| GroupedListV2 | mount | 227 | 235 | 2 | |
| GroupedListV2 | virtual-rerender | 211 | 210 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 231 | 227 | 2 | |
| IconButton | mount | 1108 | 1078 | 5000 | |
| Label | mount | 335 | 336 | 5000 | |
| Layer | mount | 2735 | 2738 | 5000 | |
| Link | mount | 388 | 392 | 5000 | |
| MenuButton | mount | 928 | 931 | 5000 | |
| MessageBar | mount | 21265 | 21350 | 5000 | |
| Nav | mount | 1946 | 1945 | 1000 | |
| OverflowSet | mount | 787 | 792 | 5000 | |
| Panel | mount | 1770 | 1731 | 1000 | |
| Persona | mount | 751 | 750 | 1000 | |
| Pivot | mount | 867 | 866 | 1000 | |
| PrimaryButton | mount | 823 | 835 | 5000 | |
| Rating | mount | 4588 | 4565 | 5000 | |
| SearchBox | mount | 895 | 911 | 5000 | |
| Shimmer | mount | 1903 | 1884 | 5000 | |
| Slider | mount | 1330 | 1312 | 5000 | |
| SpinButton | mount | 2902 | 2842 | 5000 | |
| Spinner | mount | 400 | 377 | 5000 | |
| SplitButton | mount | 1853 | 1838 | 5000 | |
| Stack | mount | 411 | 413 | 5000 | |
| StackWithIntrinsicChildren | mount | 836 | 861 | 5000 | |
| StackWithTextChildren | mount | 2594 | 2556 | 5000 | |
| SwatchColorPicker | mount | 6132 | 6207 | 5000 | |
| TagPicker | mount | 1430 | 1440 | 5000 | |
| Text | mount | 370 | 372 | 5000 | |
| TextField | mount | 925 | 941 | 5000 | |
| ThemeProvider | mount | 821 | 820 | 5000 | |
| ThemeProvider | virtual-rerender | 595 | 569 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1247 | 1292 | 5000 | |
| Toggle | mount | 597 | 616 | 5000 | |
| buttonNative | mount | 192 | 187 | 5000 |
tomi-msft
force-pushed
the
react-icons-utility-package-scaffold
branch
from
b5a0188 to
ff7e64b
Compare
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5328bbd9d25e2846a4b649c0fd86be600d4bdc32 (build) |
khmakoto
approved these changes
Jan 4, 2024
JustSlone
approved these changes
Jan 4, 2024
Collaborator
JustSlone
left a comment
JustSlone
left a comment
There was a problem hiding this comment.
approving the codeowners change, make sure to resolve the outstanding review comments
micahgodbolt
reviewed
Jan 5, 2024
micahgodbolt
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR to split #30003 into two. This will scaffold, the next will implement.