feat(scripts-task): implement initial verify-packaging task #29595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 63 | 71 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 628 | 643 | 5000 | |
| Button | mount | 308 | 307 | 5000 | |
| Field | mount | 1081 | 1108 | 5000 | |
| FluentProvider | mount | 702 | 695 | 5000 | |
| FluentProviderWithTheme | mount | 78 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 63 | 71 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 72 | 10 | |
| InfoButton | mount | 9 | 17 | 5000 | |
| MakeStyles | mount | 837 | 852 | 50000 | |
| Persona | mount | 1703 | 1697 | 5000 | |
| SpinButton | mount | 1342 | 1309 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b355d28:
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 118 | 100 | 1.18:1 |
| LoaderMinimalPerf.default | 193 | 173 | 1.12:1 |
| IconMinimalPerf.default | 391 | 350 | 1.12:1 |
| ButtonSlotsPerf.default | 336 | 306 | 1.1:1 |
| SkeletonMinimalPerf.default | 200 | 184 | 1.09:1 |
| AttachmentSlotsPerf.default | 687 | 637 | 1.08:1 |
| CarouselMinimalPerf.default | 265 | 246 | 1.08:1 |
| ChatWithPopoverPerf.default | 197 | 186 | 1.06:1 |
| ImageMinimalPerf.default | 217 | 206 | 1.05:1 |
| SliderMinimalPerf.default | 741 | 709 | 1.05:1 |
| TextAreaMinimalPerf.default | 296 | 283 | 1.05:1 |
| ChatMinimalPerf.default | 432 | 415 | 1.04:1 |
| DatepickerMinimalPerf.default | 3803 | 3659 | 1.04:1 |
| HeaderSlotsPerf.default | 477 | 457 | 1.04:1 |
| TreeMinimalPerf.default | 471 | 453 | 1.04:1 |
| AttachmentMinimalPerf.default | 79 | 77 | 1.03:1 |
| DividerMinimalPerf.default | 206 | 200 | 1.03:1 |
| FormMinimalPerf.default | 225 | 219 | 1.03:1 |
| ListMinimalPerf.default | 304 | 295 | 1.03:1 |
| ListNestedPerf.default | 320 | 312 | 1.03:1 |
| ToolbarMinimalPerf.default | 533 | 517 | 1.03:1 |
| VideoMinimalPerf.default | 435 | 423 | 1.03:1 |
| AlertMinimalPerf.default | 155 | 152 | 1.02:1 |
| CardMinimalPerf.default | 302 | 297 | 1.02:1 |
| DialogMinimalPerf.default | 444 | 434 | 1.02:1 |
| FlexMinimalPerf.default | 157 | 154 | 1.02:1 |
| GridMinimalPerf.default | 186 | 183 | 1.02:1 |
| InputMinimalPerf.default | 566 | 554 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 686 | 674 | 1.02:1 |
| MenuButtonMinimalPerf.default | 960 | 938 | 1.02:1 |
| ProviderMergeThemesPerf.default | 648 | 637 | 1.02:1 |
| RadioGroupMinimalPerf.default | 261 | 257 | 1.02:1 |
| ReactionMinimalPerf.default | 207 | 203 | 1.02:1 |
| EmbedMinimalPerf.default | 1870 | 1850 | 1.01:1 |
| ListWith60ListItems.default | 373 | 369 | 1.01:1 |
| MenuMinimalPerf.default | 505 | 498 | 1.01:1 |
| SegmentMinimalPerf.default | 195 | 193 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2239 | 2209 | 1.01:1 |
| CustomToolbarPrototype.default | 1470 | 1456 | 1.01:1 |
| TooltipMinimalPerf.default | 1269 | 1255 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 152 | 152 | 1:1 |
| AnimationMinimalPerf.default | 296 | 298 | 0.99:1 |
| ButtonMinimalPerf.default | 87 | 88 | 0.99:1 |
| DropdownManyItemsPerf.default | 392 | 394 | 0.99:1 |
| DropdownMinimalPerf.default | 1414 | 1429 | 0.99:1 |
| LabelMinimalPerf.default | 213 | 216 | 0.99:1 |
| PortalMinimalPerf.default | 82 | 83 | 0.99:1 |
| TableMinimalPerf.default | 228 | 230 | 0.99:1 |
| ListCommonPerf.default | 376 | 385 | 0.98:1 |
| ProviderMinimalPerf.default | 201 | 205 | 0.98:1 |
| StatusMinimalPerf.default | 377 | 383 | 0.98:1 |
| TableManyItemsPerf.default | 1091 | 1115 | 0.98:1 |
| BoxMinimalPerf.default | 184 | 189 | 0.97:1 |
| CheckboxMinimalPerf.default | 1107 | 1143 | 0.97:1 |
| HeaderMinimalPerf.default | 197 | 203 | 0.97:1 |
| PopupMinimalPerf.default | 342 | 353 | 0.97:1 |
| ButtonOverridesMissPerf.default | 634 | 657 | 0.96:1 |
| RosterPerf.default | 1474 | 1530 | 0.96:1 |
| RefMinimalPerf.default | 109 | 113 | 0.96:1 |
| TextMinimalPerf.default | 188 | 195 | 0.96:1 |
| TreeWith60ListItems.default | 81 | 84 | 0.96:1 |
| AccordionMinimalPerf.default | 74 | 78 | 0.95:1 |
| LayoutMinimalPerf.default | 193 | 203 | 0.95:1 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b5d527237289d185bd58e4500a04f9d3d495662a (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 639 | 611 | 5000 | |
| Breadcrumb | mount | 1664 | 1670 | 1000 | |
| Checkbox | mount | 1663 | 1657 | 5000 | |
| CheckboxBase | mount | 1470 | 1430 | 5000 | |
| ChoiceGroup | mount | 2899 | 2914 | 5000 | |
| ComboBox | mount | 662 | 675 | 1000 | |
| CommandBar | mount | 6149 | 6118 | 1000 | |
| ContextualMenu | mount | 11349 | 11926 | 1000 | |
| DefaultButton | mount | 733 | 741 | 5000 | |
| DetailsRow | mount | 2206 | 2209 | 5000 | |
| DetailsRowFast | mount | 2134 | 2125 | 5000 | |
| DetailsRowNoStyles | mount | 2005 | 1987 | 5000 | |
| Dialog | mount | 2600 | 2790 | 1000 | |
| DocumentCardTitle | mount | 223 | 230 | 1000 | |
| Dropdown | mount | 1944 | 1961 | 5000 | |
| FocusTrapZone | mount | 1169 | 1124 | 5000 | |
| FocusZone | mount | 1049 | 1058 | 5000 | |
| GroupedList | mount | 40687 | 41387 | 2 | |
| GroupedList | virtual-rerender | 17515 | 19826 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50299 | 50059 | 2 | |
| GroupedListV2 | mount | 218 | 226 | 2 | |
| GroupedListV2 | virtual-rerender | 207 | 213 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 241 | 231 | 2 | |
| IconButton | mount | 1066 | 1088 | 5000 | |
| Label | mount | 332 | 325 | 5000 | |
| Layer | mount | 2680 | 2696 | 5000 | |
| Link | mount | 396 | 390 | 5000 | |
| MenuButton | mount | 929 | 951 | 5000 | |
| MessageBar | mount | 21423 | 21433 | 5000 | |
| Nav | mount | 1906 | 1947 | 1000 | |
| OverflowSet | mount | 764 | 782 | 5000 | |
| Panel | mount | 2047 | 1760 | 1000 | |
| Persona | mount | 743 | 717 | 1000 | |
| Pivot | mount | 877 | 863 | 1000 | |
| PrimaryButton | mount | 842 | 843 | 5000 | |
| Rating | mount | 4560 | 4527 | 5000 | |
| SearchBox | mount | 914 | 898 | 5000 | |
| Shimmer | mount | 1856 | 1871 | 5000 | |
| Slider | mount | 1308 | 1287 | 5000 | |
| SpinButton | mount | 2870 | 2853 | 5000 | |
| Spinner | mount | 383 | 402 | 5000 | |
| SplitButton | mount | 1785 | 1781 | 5000 | |
| Stack | mount | 401 | 405 | 5000 | |
| StackWithIntrinsicChildren | mount | 845 | 846 | 5000 | |
| StackWithTextChildren | mount | 2600 | 2632 | 5000 | |
| SwatchColorPicker | mount | 6138 | 6139 | 5000 | |
| TagPicker | mount | 1435 | 1478 | 5000 | |
| Text | mount | 370 | 365 | 5000 | |
| TextField | mount | 917 | 918 | 5000 | |
| ThemeProvider | mount | 819 | 827 | 5000 | |
| ThemeProvider | virtual-rerender | 579 | 593 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1255 | 1236 | 5000 | |
| Toggle | mount | 612 | 613 | 5000 | |
| buttonNative | mount | 192 | 199 | 5000 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
force-pushed
the
hotell/build/verify-packaging
branch
from
e5f8e76 to
b355d28
Compare
1 task
Hotell
added
Fluent UI react (v8)
Contributor
Author
|
review ping @TristanWatanabe @marcosmoura 🙏 |
TristanWatanabe
approved these changes
Oct 25, 2023
tudorpopams
approved these changes
Oct 25, 2023
marcosmoura
approved these changes
Oct 25, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 25, 2023
* master: feat(scripts-task): implement initial verify-packaging task (microsoft#29595)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 26, 2023
* master: chore: migrate to nx 16.10 (microsoft#29617) fix(react-drawer): accessibility tweaks (microsoft#29627) Fixing few legend colors not visible in dark mode (microsoft#29652) applying package updates Fixing dark mode bug for xAxis for Vertical Stacked bar chart (microsoft#29427) chore: Refactor RadioGroup stories to use Field, and remove individual storybook page for Radio (microsoft#29268) docs: fix description of SelectInitialValue story (microsoft#26493) chore: fix specs location (microsoft#29642) feat(scripts-task): implement initial verify-packaging task (microsoft#29595) feat(tools): replace npmignore with package.json#files for robust control over what we ship to npm (microsoft#29616) fix(workspace-plugin): fix storybook and vr-test issues wihtin prepare-initial-release generator (microsoft#29577) feat(react-breadcrumb): removed non-interactive item (microsoft#29623) fix(react-motion): prevent from breaking the rule of hooks (microsoft#29628) fix(react-toast): invoke useCustomStyleHook_unstable() (microsoft#29632) feat: Deprecate Alert component (microsoft#29615) chore(react-infobutton, react-components): Deprecate InfoButton and InfoLabel from react-infobutton (microsoft#29605)
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
we dont know 100% what we actually ship to npm. this caused a lot of headaches in the past while migrating to new major versions of nodejs or in general config tweaks ( see linked epic for more info )
New Behavior
implements
verify-packagingjust-script task ( has nothing in particular with just-scripts and will be migrated to nx executor once we will start migration from lage/just).new task is being added to 1 v9 and 1 v8 package
this is a pre-requirement for safe migration to node v18
v9 (probably v8 should as well) will switch to
"files"specifier in package.json -> thus the logic will of the task will be updatedRelated Issue(s)