chore: use package.json#files setup instead of npmignore for all v9 libraries #29734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 79 | 78 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 612 | 638 | 5000 | |
| Button | mount | 322 | 327 | 5000 | |
| Field | mount | 1094 | 1126 | 5000 | |
| FluentProvider | mount | 696 | 696 | 5000 | |
| FluentProviderWithTheme | mount | 79 | 78 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 61 | 63 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 75 | 10 | |
| MakeStyles | mount | 867 | 861 | 50000 | |
| Persona | mount | 1773 | 1705 | 5000 | |
| SpinButton | mount | 1400 | 1375 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3dd2fbd:
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| PortalMinimalPerf.default | 83 | 85 | 0.98:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 107 | 88 | 1.22:1 |
| LoaderMinimalPerf.default | 208 | 181 | 1.15:1 |
| AttachmentMinimalPerf.default | 86 | 76 | 1.13:1 |
| TreeWith60ListItems.default | 89 | 80 | 1.11:1 |
| AvatarMinimalPerf.default | 109 | 101 | 1.08:1 |
| CardMinimalPerf.default | 329 | 306 | 1.08:1 |
| ChatWithPopoverPerf.default | 204 | 191 | 1.07:1 |
| FlexMinimalPerf.default | 158 | 149 | 1.06:1 |
| LayoutMinimalPerf.default | 204 | 194 | 1.05:1 |
| ProviderMinimalPerf.default | 200 | 191 | 1.05:1 |
| RefMinimalPerf.default | 115 | 110 | 1.05:1 |
| FormMinimalPerf.default | 230 | 222 | 1.04:1 |
| IconMinimalPerf.default | 395 | 379 | 1.04:1 |
| TreeMinimalPerf.default | 480 | 462 | 1.04:1 |
| AnimationMinimalPerf.default | 306 | 297 | 1.03:1 |
| ButtonOverridesMissPerf.default | 680 | 658 | 1.03:1 |
| DividerMinimalPerf.default | 206 | 200 | 1.03:1 |
| HeaderSlotsPerf.default | 474 | 458 | 1.03:1 |
| PopupMinimalPerf.default | 354 | 344 | 1.03:1 |
| TextMinimalPerf.default | 198 | 192 | 1.03:1 |
| AlertMinimalPerf.default | 152 | 149 | 1.02:1 |
| BoxMinimalPerf.default | 196 | 192 | 1.02:1 |
| ButtonSlotsPerf.default | 308 | 303 | 1.02:1 |
| CarouselMinimalPerf.default | 256 | 250 | 1.02:1 |
| ListCommonPerf.default | 397 | 391 | 1.02:1 |
| MenuMinimalPerf.default | 504 | 496 | 1.02:1 |
| DatepickerMinimalPerf.default | 3606 | 3582 | 1.01:1 |
| DialogMinimalPerf.default | 437 | 434 | 1.01:1 |
| DropdownMinimalPerf.default | 1415 | 1401 | 1.01:1 |
| InputMinimalPerf.default | 527 | 521 | 1.01:1 |
| MenuButtonMinimalPerf.default | 947 | 940 | 1.01:1 |
| ToolbarMinimalPerf.default | 533 | 529 | 1.01:1 |
| DropdownManyItemsPerf.default | 392 | 393 | 1:1 |
| LabelMinimalPerf.default | 217 | 217 | 1:1 |
| ListMinimalPerf.default | 310 | 311 | 1:1 |
| SliderMinimalPerf.default | 735 | 733 | 1:1 |
| TableManyItemsPerf.default | 1080 | 1085 | 1:1 |
| AttachmentSlotsPerf.default | 648 | 652 | 0.99:1 |
| ChatMinimalPerf.default | 426 | 429 | 0.99:1 |
| CheckboxMinimalPerf.default | 1110 | 1119 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 715 | 722 | 0.99:1 |
| RosterPerf.default | 1574 | 1594 | 0.99:1 |
| ProviderMergeThemesPerf.default | 638 | 642 | 0.99:1 |
| RadioGroupMinimalPerf.default | 262 | 264 | 0.99:1 |
| ReactionMinimalPerf.default | 208 | 210 | 0.99:1 |
| TableMinimalPerf.default | 232 | 235 | 0.99:1 |
| TooltipMinimalPerf.default | 1253 | 1262 | 0.99:1 |
| VideoMinimalPerf.default | 425 | 429 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 153 | 156 | 0.98:1 |
| EmbedMinimalPerf.default | 1868 | 1900 | 0.98:1 |
| SegmentMinimalPerf.default | 194 | 198 | 0.98:1 |
| SplitButtonMinimalPerf.default | 2201 | 2254 | 0.98:1 |
| StatusMinimalPerf.default | 389 | 397 | 0.98:1 |
| TextAreaMinimalPerf.default | 295 | 301 | 0.98:1 |
| CustomToolbarPrototype.default | 1455 | 1481 | 0.98:1 |
| GridMinimalPerf.default | 187 | 192 | 0.97:1 |
| ListWith60ListItems.default | 354 | 364 | 0.97:1 |
| ListNestedPerf.default | 321 | 336 | 0.96:1 |
| SkeletonMinimalPerf.default | 193 | 202 | 0.96:1 |
| ImageMinimalPerf.default | 224 | 237 | 0.95:1 |
| AccordionMinimalPerf.default | 80 | 85 | 0.94:1 |
| HeaderMinimalPerf.default | 207 | 228 | 0.91:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 667d05dda55b7edbba8e41f483bf27f7dbefbc47 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 629 | 652 | 5000 | |
| Breadcrumb | mount | 1681 | 1665 | 1000 | |
| Checkbox | mount | 1690 | 1676 | 5000 | |
| CheckboxBase | mount | 1474 | 1521 | 5000 | |
| ChoiceGroup | mount | 2884 | 2971 | 5000 | |
| ComboBox | mount | 652 | 662 | 1000 | |
| CommandBar | mount | 6235 | 6254 | 1000 | |
| ContextualMenu | mount | 13071 | 12856 | 1000 | |
| DefaultButton | mount | 749 | 754 | 5000 | |
| DetailsRow | mount | 2247 | 2176 | 5000 | |
| DetailsRowFast | mount | 2204 | 2225 | 5000 | |
| DetailsRowNoStyles | mount | 2027 | 2036 | 5000 | |
| Dialog | mount | 2753 | 2772 | 1000 | |
| DocumentCardTitle | mount | 230 | 232 | 1000 | |
| Dropdown | mount | 1990 | 1994 | 5000 | |
| FocusTrapZone | mount | 1117 | 1164 | 5000 | |
| FocusZone | mount | 1042 | 1058 | 5000 | |
| GroupedList | mount | 41470 | 41753 | 2 | |
| GroupedList | virtual-rerender | 19899 | 19920 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51068 | 50619 | 2 | |
| GroupedListV2 | mount | 221 | 237 | 2 | |
| GroupedListV2 | virtual-rerender | 219 | 215 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 230 | 236 | 2 | |
| IconButton | mount | 1106 | 1109 | 5000 | |
| Label | mount | 332 | 338 | 5000 | |
| Layer | mount | 2770 | 2758 | 5000 | |
| Link | mount | 405 | 387 | 5000 | |
| MenuButton | mount | 956 | 940 | 5000 | |
| MessageBar | mount | 21413 | 21426 | 5000 | |
| Nav | mount | 1925 | 1951 | 1000 | |
| OverflowSet | mount | 779 | 798 | 5000 | |
| Panel | mount | 1770 | 1830 | 1000 | |
| Persona | mount | 739 | 731 | 1000 | |
| Pivot | mount | 862 | 875 | 1000 | |
| PrimaryButton | mount | 854 | 850 | 5000 | |
| Rating | mount | 4678 | 4655 | 5000 | |
| SearchBox | mount | 897 | 912 | 5000 | |
| Shimmer | mount | 1919 | 1856 | 5000 | |
| Slider | mount | 1326 | 1341 | 5000 | |
| SpinButton | mount | 2871 | 2879 | 5000 | |
| Spinner | mount | 374 | 399 | 5000 | |
| SplitButton | mount | 1843 | 1825 | 5000 | |
| Stack | mount | 418 | 408 | 5000 | |
| StackWithIntrinsicChildren | mount | 850 | 856 | 5000 | |
| StackWithTextChildren | mount | 2581 | 2578 | 5000 | |
| SwatchColorPicker | mount | 6071 | 6123 | 5000 | |
| TagPicker | mount | 1442 | 1491 | 5000 | |
| Text | mount | 370 | 371 | 5000 | |
| TextField | mount | 938 | 914 | 5000 | |
| ThemeProvider | mount | 849 | 835 | 5000 | |
| ThemeProvider | virtual-rerender | 581 | 594 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1278 | 1280 | 5000 | |
| Toggle | mount | 594 | 601 | 5000 | |
| buttonNative | mount | 193 | 200 | 5000 |
Hotell
force-pushed
the
build/releases/migrate-to-files
branch
from
cbb3132 to
42b2854
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Hotell
force-pushed
the
build/releases/migrate-to-files
branch
from
b024295 to
3dd2fbd
Compare
Hotell
requested review from
a team,
GeoffCoxMSFT,
Mitch-At-Work,
khmakoto,
marcosmoura,
mltejera,
sopranopillow and
tomi-msft
as code owners
Hotell
requested review from
a team,
behowell,
chpalac,
ling1726,
micahgodbolt,
ms-acalzaretto,
smhigley and
spmonahan
as code owners
behowell
approved these changes
Nov 6, 2023
ling1726
approved these changes
Nov 7, 2023
ValentinaKozlova
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
we use mix of npmignore + gitignore resolution to determine what should be published to
npm.This appraoch doesn't work as expected and also makes hard to reason about what is actually being published. Last but not least this combo caused a lot of issues when migrating to new major node versions in the past.
New Behavior
filesinstead ofnpmignorefilesis build via known project patterns. Some exotic patterns need to be maintained manually (seereact-componentssuite orreact-jsx-runtimeproject )verify-packagingtask to verify we ship our core package as expectedRelated Issue(s)