feat(scripts-tasks): make verify-packaging more roubst and exit early for private packages #29743

Hotell · 2023-11-03T12:03:15Z

Previous Behavior

New Behavior

verify-packaging

does noop for private packages
uses micromatch to allow more robust file matching/verification
properly processes --production flag on release builds

@fluentui/utilities

migrated to use files instead npmignore+gitignore mix, in order to help verify-packaging stay generic enough
this mitigates unwanted assets being published to npm

Related Issue(s)

Follows feat(scripts-task): implement initial verify-packaging task #29595
Implements partially [Epic]: make release pipelines more reliable #27758

fabricteam · 2023-11-03T12:13:09Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	630	636	5000
Button	mount	318	316	5000
Field	mount	1166	1134	5000
FluentProvider	mount	714	702	5000
FluentProviderWithTheme	mount	75	84	10
FluentProviderWithTheme	virtual-rerender	65	68	10
FluentProviderWithTheme	virtual-rerender-with-unmount	75	86	10
MakeStyles	mount	861	862	50000
Persona	mount	1775	1724	5000
SpinButton	mount	1391	1400	5000

codesandbox-ci · 2023-11-03T12:16:03Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 578104c:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-11-03T12:17:33Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
PortalMinimalPerf.default	89	89	1:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	85	73	1.16:1
GridMinimalPerf.default	202	186	1.09:1
IconMinimalPerf.default	400	370	1.08:1
CardMinimalPerf.default	318	297	1.07:1
ListNestedPerf.default	323	303	1.07:1
ProviderMinimalPerf.default	207	193	1.07:1
ChatDuplicateMessagesPerf.default	161	152	1.06:1
LabelMinimalPerf.default	227	215	1.06:1
ListMinimalPerf.default	310	293	1.06:1
ButtonMinimalPerf.default	84	80	1.05:1
StatusMinimalPerf.default	405	385	1.05:1
TextAreaMinimalPerf.default	289	276	1.05:1
CarouselMinimalPerf.default	272	261	1.04:1
HeaderSlotsPerf.default	465	449	1.04:1
InputMinimalPerf.default	545	526	1.04:1
ListCommonPerf.default	391	376	1.04:1
SliderMinimalPerf.default	762	732	1.04:1
TreeMinimalPerf.default	479	462	1.04:1
AttachmentSlotsPerf.default	652	632	1.03:1
ItemLayoutMinimalPerf.default	692	670	1.03:1
DividerMinimalPerf.default	210	206	1.02:1
FormMinimalPerf.default	219	214	1.02:1
ProviderMergeThemesPerf.default	655	642	1.02:1
SplitButtonMinimalPerf.default	2268	2225	1.02:1
CustomToolbarPrototype.default	1465	1437	1.02:1
TooltipMinimalPerf.default	1287	1262	1.02:1
AnimationMinimalPerf.default	294	291	1.01:1
ChatMinimalPerf.default	433	429	1.01:1
DialogMinimalPerf.default	443	438	1.01:1
EmbedMinimalPerf.default	1869	1853	1.01:1
HeaderMinimalPerf.default	200	198	1.01:1
RosterPerf.default	1582	1564	1.01:1
PopupMinimalPerf.default	354	351	1.01:1
SkeletonMinimalPerf.default	198	197	1.01:1
AlertMinimalPerf.default	149	149	1:1
CheckboxMinimalPerf.default	1111	1112	1:1
MenuMinimalPerf.default	484	483	1:1
MenuButtonMinimalPerf.default	958	962	1:1
RadioGroupMinimalPerf.default	256	255	1:1
SegmentMinimalPerf.default	191	191	1:1
TableManyItemsPerf.default	1096	1098	1:1
AccordionMinimalPerf.default	77	78	0.99:1
DropdownMinimalPerf.default	1420	1432	0.99:1
FlexMinimalPerf.default	157	159	0.99:1
LayoutMinimalPerf.default	195	197	0.99:1
ListWith60ListItems.default	368	372	0.99:1
TextMinimalPerf.default	188	190	0.99:1
ToolbarMinimalPerf.default	523	529	0.99:1
BoxMinimalPerf.default	188	192	0.98:1
ChatWithPopoverPerf.default	190	193	0.98:1
ReactionMinimalPerf.default	206	211	0.98:1
RefMinimalPerf.default	110	112	0.98:1
VideoMinimalPerf.default	425	434	0.98:1
AvatarMinimalPerf.default	105	108	0.97:1
ButtonOverridesMissPerf.default	635	655	0.97:1
DatepickerMinimalPerf.default	3654	3786	0.97:1
LoaderMinimalPerf.default	187	192	0.97:1
TableMinimalPerf.default	224	233	0.96:1
ButtonSlotsPerf.default	305	320	0.95:1
ImageMinimalPerf.default	220	231	0.95:1
DropdownManyItemsPerf.default	365	388	0.94:1
TreeWith60ListItems.default	87	94	0.93:1

fabricteam · 2023-11-03T12:21:42Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-11-03T12:23:18Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.341 kB` `1.81 kB`
`react-accordion` Accordion (including children components)	`92.983 kB` `28.418 kB`
`react-alert` Alert	`84.293 kB` `23.456 kB`
`react-avatar` Avatar	`50.534 kB` `15.923 kB`
`react-avatar` AvatarGroup	`20.064 kB` `7.894 kB`
`react-avatar` AvatarGroupItem	`65.19 kB` `20.259 kB`
`react-badge` Badge	`27.264 kB` `8.808 kB`
`react-badge` CounterBadge	`28.165 kB` `9.101 kB`
`react-badge` PresenceBadge	`25.67 kB` `9.313 kB`
`react-button` Button	`40.074 kB` `11.292 kB`
`react-button` CompoundButton	`47.43 kB` `12.787 kB`
`react-button` MenuButton	`44.848 kB` `12.668 kB`
`react-button` SplitButton	`52.862 kB` `14.254 kB`
`react-button` ToggleButton	`57.122 kB` `13.194 kB`
`react-calendar-compat` Calendar Compat	`141.364 kB` `36.841 kB`
`react-card` Card - All	`92.955 kB` `26.977 kB`
`react-card` Card	`87.781 kB` `25.462 kB`
`react-card` CardFooter	`13.423 kB` `5.481 kB`
`react-card` CardHeader	`15.666 kB` `6.235 kB`
`react-card` CardPreview	`14.374 kB` `5.854 kB`
`react-checkbox` Checkbox	`37.505 kB` `12.327 kB`
`react-combobox` Combobox (including child components)	`92.195 kB` `30.069 kB`
`react-combobox` Dropdown (including child components)	`90.605 kB` `29.726 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`70.013 kB` `20.17 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`207.755 kB` `59.417 kB`
`react-components` react-components: FluentProvider & webLightTheme	`42.297 kB` `14.008 kB`
`react-datepicker-compat` DatePicker Compat	`212.866 kB` `59.446 kB`
`react-dialog` Dialog (including children components)	`94.473 kB` `28.28 kB`
`react-divider` Divider	`21.179 kB` `7.839 kB`
`react-field` Field	`22.788 kB` `8.639 kB`
`react-image` Image	`16.096 kB` `6.317 kB`
`react-infobutton` InfoButton	`131.061 kB` `41.305 kB`
`react-infobutton` InfoLabel	`134.745 kB` `42.459 kB`
`react-input` Input	`27.247 kB` `9.194 kB`
`react-jsx-runtime` Classic Pragma	`1.049 kB` `531 B`
`react-jsx-runtime` JSX Dev Runtime	`4.14 kB` `1.741 kB`
`react-jsx-runtime` JSX Runtime	`4.734 kB` `1.983 kB`
`react-label` Label	`14.508 kB` `5.857 kB`
`react-link` Link	`17.4 kB` `6.977 kB`
`react-menu` Menu (including children components)	`140.508 kB` `43.108 kB`
`react-menu` Menu (including selectable components)	`143.194 kB` `43.615 kB`
`react-message-bar` MessageBar (all components)	`25.54 kB` `9.102 kB`
`react-overflow` hooks only	`12.598 kB` `4.754 kB`
`react-persona` Persona	`57.425 kB` `17.798 kB`
`react-popover` Popover	`119.792 kB` `37.816 kB`
`react-portal` Portal	`12.4 kB` `4.541 kB`
`react-portal-compat` PortalCompatProvider	`6.651 kB` `2.252 kB`
`react-positioning` usePositioning	`25.637 kB` `9.263 kB`
`react-progress` ProgressBar	`17.788 kB` `6.986 kB`
`react-provider` FluentProvider	`22.837 kB` `8.434 kB`
`react-radio` Radio	`31.266 kB` `10.267 kB`
`react-radio` RadioGroup	`15.704 kB` `6.35 kB`
`react-select` Select	`28.968 kB` `10.269 kB`
`react-slider` Slider	`38.349 kB` `12.595 kB`
`react-spinbutton` SpinButton	`37.133 kB` `11.856 kB`
`react-spinner` Spinner	`23.762 kB` `8.556 kB`
`react-switch` Switch	`33.731 kB` `10.899 kB`
`react-table` DataGrid	`157.084 kB` `43.906 kB`
`react-table` Table (Primitives only)	`43.941 kB` `13.76 kB`
`react-table` Table as DataGrid	`130.165 kB` `35.174 kB`
`react-table` Table (Selection only)	`75.777 kB` `20.477 kB`
`react-table` Table (Sort only)	`74.384 kB` `20.075 kB`
`react-tags` InteractionTag	`15.618 kB` `6.152 kB`
`react-tags` Tag	`30.341 kB` `9.505 kB`
`react-tags` TagGroup	`73.816 kB` `22.097 kB`
`react-text` Text - Default	`17.065 kB` `6.645 kB`
`react-text` Text - Wrappers	`20.237 kB` `6.965 kB`
`react-textarea` Textarea	`31.306 kB` `10.549 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.616 kB` `7.299 kB`
`react-theme` Teams: Light theme	`19.287 kB` `5.49 kB`
`react-timepicker-compat-preview` TimePicker	`93.596 kB` `31.349 kB`
`react-toast` Toast (including Toaster)	`92.725 kB` `27.876 kB`
`react-tooltip` Tooltip	`52.798 kB` `18.569 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 9343f295b18084e44f6751081907aa7e9987b767}

size-auditor · 2023-11-03T12:24:44Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9343f295b18084e44f6751081907aa7e9987b767 (build)

fabricteam · 2023-11-03T12:26:04Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-11-03T12:28:26Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	632	630	5000
Breadcrumb	mount	1672	1683	1000
Checkbox	mount	1661	1675	5000
CheckboxBase	mount	1462	1446	5000
ChoiceGroup	mount	3000	2999	5000
ComboBox	mount	677	671	1000
CommandBar	mount	6263	6237	1000
ContextualMenu	mount	14089	12471	1000
DefaultButton	mount	730	742	5000
DetailsRow	mount	2207	2211	5000
DetailsRowFast	mount	2202	2210	5000
DetailsRowNoStyles	mount	1958	2008	5000
Dialog	mount	2637	2646	1000
DocumentCardTitle	mount	229	237	1000
Dropdown	mount	1962	1932	5000
FocusTrapZone	mount	1163	1132	5000
FocusZone	mount	1046	1030	5000
GroupedList	mount	41744	41709	2
GroupedList	virtual-rerender	17922	20079	2
GroupedList	virtual-rerender-with-unmount	53410	55866	2
GroupedListV2	mount	228	238	2
GroupedListV2	virtual-rerender	215	212	2
GroupedListV2	virtual-rerender-with-unmount	235	239	2
IconButton	mount	1098	1080	5000
Label	mount	329	331	5000
Layer	mount	2686	2738	5000
Link	mount	397	382	5000
MenuButton	mount	933	940	5000
MessageBar	mount	21274	21372	5000
Nav	mount	1911	1937	1000
OverflowSet	mount	781	763	5000
Panel	mount	1768	1799	1000
Persona	mount	725	766	1000
Pivot	mount	877	867	1000
PrimaryButton	mount	860	854	5000
Rating	mount	4679	4679	5000
SearchBox	mount	947	906	5000
Shimmer	mount	1930	1911	5000
Slider	mount	1299	1334	5000
SpinButton	mount	2918	2887	5000
Spinner	mount	403	391	5000
SplitButton	mount	1842	1866	5000
Stack	mount	404	438	5000
StackWithIntrinsicChildren	mount	873	851	5000
StackWithTextChildren	mount	2573	2651	5000
SwatchColorPicker	mount	6164	6284	5000
TagPicker	mount	1470	1491	5000
Text	mount	372	383	5000
TextField	mount	967	933	5000
ThemeProvider	mount	840	835	5000
ThemeProvider	virtual-rerender	602	591	5000
ThemeProvider	virtual-rerender-with-unmount	1266	1295	5000
Toggle	mount	632	620	5000
buttonNative	mount	196	197	5000

packages/utilities/package.json

… for private packages

fabricteam · 2023-11-07T15:04:29Z

🕵 fluentuiv8 No visual regressions between this PR and main

scripts/tasks/src/verify-packaging.ts

Co-authored-by: Tristan Watanabe <[email protected]>

github-actions bot added this to the November Project Cycle Q1 2024 milestone Nov 3, 2023

Hotell changed the title ~~Build/releases/improve verify packaging~~ feat(scripts-tasks): make verify-packaging more roubst and exit early for private packages Nov 3, 2023

Hotell added Area: Build System Fluent UI react (v8) Issues about @fluentui/react (v8) Package: utilities labels Nov 3, 2023

Hotell marked this pull request as ready for review November 3, 2023 13:05

Hotell requested review from a team as code owners November 3, 2023 13:05

TristanWatanabe reviewed Nov 3, 2023

View reviewed changes

packages/utilities/package.json Show resolved Hide resolved

Hotell requested a review from TristanWatanabe November 6, 2023 12:40

Hotell added 3 commits November 7, 2023 15:49

feat(scripts-tasks): make verify-packaging more robust and exit early…

71115e2

… for private packages

chore: use package.json#files setup instead of npmignore

130c6f5

generate change files

891dc9f

Hotell force-pushed the build/releases/improve-verify-packaging branch from be754c3 to 891dc9f Compare November 7, 2023 14:49

TristanWatanabe approved these changes Nov 7, 2023

View reviewed changes

scripts/tasks/src/verify-packaging.ts Outdated Show resolved Hide resolved

scripts/tasks/src/verify-packaging.ts Outdated Show resolved Hide resolved

Hotell and others added 2 commits November 8, 2023 11:27

Update scripts/tasks/src/verify-packaging.ts

8976c13

Co-authored-by: Tristan Watanabe <[email protected]>

Update scripts/tasks/src/verify-packaging.ts

578104c

Co-authored-by: Tristan Watanabe <[email protected]>

Hotell enabled auto-merge (squash) November 8, 2023 10:28

Hotell merged commit 175914f into microsoft:master Nov 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(scripts-tasks): make verify-packaging more roubst and exit early for private packages #29743

feat(scripts-tasks): make verify-packaging more roubst and exit early for private packages #29743

Uh oh!

Hotell commented Nov 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Nov 3, 2023 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Nov 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Nov 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Nov 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Nov 3, 2023 •

edited

Loading

Uh oh!

size-auditor bot commented Nov 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Nov 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Nov 3, 2023 •

edited

Loading

Uh oh!

Uh oh!

fabricteam commented Nov 7, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(scripts-tasks): make verify-packaging more roubst and exit early for private packages #29743

feat(scripts-tasks): make verify-packaging more roubst and exit early for private packages #29743

Uh oh!

Conversation

Hotell commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

size-auditor bot commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

fabricteam commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented Nov 3, 2023 •

edited

Loading

fabricteam commented Nov 3, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

codesandbox-ci bot commented Nov 3, 2023 •

edited

Loading

fabricteam commented Nov 3, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Nov 3, 2023 •

edited

Loading

fabricteam commented Nov 3, 2023 •

edited

Loading

size-auditor bot commented Nov 3, 2023 •

edited

Loading

fabricteam commented Nov 3, 2023 •

edited

Loading

fabricteam commented Nov 3, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Nov 7, 2023 •

edited

Loading