chore: migrate to node 18 #29598
Merged
chore: migrate to node 18 #29598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 670 | 608 | 5000 | |
| Button | mount | 320 | 322 | 5000 | |
| Field | mount | 1112 | 1134 | 5000 | |
| FluentProvider | mount | 715 | 709 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 63 | 63 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 73 | 10 | |
| MakeStyles | mount | 880 | 858 | 50000 | |
| Persona | mount | 1741 | 1725 | 5000 | |
| SpinButton | mount | 1410 | 1396 | 5000 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| FlexMinimalPerf.default | 151 | 151 | 1:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 86 | 71 | 1.21:1 |
| RefMinimalPerf.default | 109 | 99 | 1.1:1 |
| AttachmentMinimalPerf.default | 81 | 74 | 1.09:1 |
| CarouselMinimalPerf.default | 271 | 248 | 1.09:1 |
| SegmentMinimalPerf.default | 207 | 191 | 1.08:1 |
| BoxMinimalPerf.default | 202 | 188 | 1.07:1 |
| ButtonSlotsPerf.default | 328 | 306 | 1.07:1 |
| PopupMinimalPerf.default | 374 | 351 | 1.07:1 |
| TooltipMinimalPerf.default | 1276 | 1197 | 1.07:1 |
| TreeWith60ListItems.default | 81 | 76 | 1.07:1 |
| ChatWithPopoverPerf.default | 201 | 190 | 1.06:1 |
| GridMinimalPerf.default | 201 | 190 | 1.06:1 |
| HeaderSlotsPerf.default | 484 | 458 | 1.06:1 |
| LabelMinimalPerf.default | 233 | 219 | 1.06:1 |
| MenuMinimalPerf.default | 510 | 483 | 1.06:1 |
| PortalMinimalPerf.default | 84 | 79 | 1.06:1 |
| TextMinimalPerf.default | 198 | 187 | 1.06:1 |
| DialogMinimalPerf.default | 457 | 436 | 1.05:1 |
| HeaderMinimalPerf.default | 221 | 211 | 1.05:1 |
| ImageMinimalPerf.default | 221 | 210 | 1.05:1 |
| LayoutMinimalPerf.default | 207 | 198 | 1.05:1 |
| ReactionMinimalPerf.default | 217 | 206 | 1.05:1 |
| AttachmentSlotsPerf.default | 668 | 640 | 1.04:1 |
| CardMinimalPerf.default | 315 | 303 | 1.04:1 |
| FormMinimalPerf.default | 225 | 216 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 712 | 686 | 1.04:1 |
| SplitButtonMinimalPerf.default | 2275 | 2196 | 1.04:1 |
| VideoMinimalPerf.default | 435 | 419 | 1.04:1 |
| AnimationMinimalPerf.default | 307 | 297 | 1.03:1 |
| ListMinimalPerf.default | 310 | 300 | 1.03:1 |
| ProviderMinimalPerf.default | 203 | 197 | 1.03:1 |
| TableManyItemsPerf.default | 1137 | 1101 | 1.03:1 |
| ToolbarMinimalPerf.default | 542 | 524 | 1.03:1 |
| ButtonMinimalPerf.default | 89 | 87 | 1.02:1 |
| ButtonOverridesMissPerf.default | 652 | 641 | 1.02:1 |
| CheckboxMinimalPerf.default | 1158 | 1132 | 1.02:1 |
| DatepickerMinimalPerf.default | 3713 | 3643 | 1.02:1 |
| ListCommonPerf.default | 389 | 383 | 1.02:1 |
| LoaderMinimalPerf.default | 197 | 194 | 1.02:1 |
| MenuButtonMinimalPerf.default | 977 | 961 | 1.02:1 |
| TextAreaMinimalPerf.default | 290 | 283 | 1.02:1 |
| ChatMinimalPerf.default | 428 | 423 | 1.01:1 |
| DropdownMinimalPerf.default | 1438 | 1428 | 1.01:1 |
| EmbedMinimalPerf.default | 1881 | 1856 | 1.01:1 |
| RadioGroupMinimalPerf.default | 271 | 267 | 1.01:1 |
| SliderMinimalPerf.default | 759 | 760 | 1:1 |
| TableMinimalPerf.default | 237 | 236 | 1:1 |
| CustomToolbarPrototype.default | 1474 | 1475 | 1:1 |
| TreeMinimalPerf.default | 483 | 482 | 1:1 |
| ChatDuplicateMessagesPerf.default | 150 | 151 | 0.99:1 |
| DropdownManyItemsPerf.default | 387 | 389 | 0.99:1 |
| ListWith60ListItems.default | 366 | 368 | 0.99:1 |
| ProviderMergeThemesPerf.default | 645 | 650 | 0.99:1 |
| AlertMinimalPerf.default | 153 | 156 | 0.98:1 |
| RosterPerf.default | 1569 | 1594 | 0.98:1 |
| SkeletonMinimalPerf.default | 192 | 196 | 0.98:1 |
| StatusMinimalPerf.default | 391 | 397 | 0.98:1 |
| DividerMinimalPerf.default | 202 | 208 | 0.97:1 |
| InputMinimalPerf.default | 528 | 547 | 0.97:1 |
| ListNestedPerf.default | 326 | 337 | 0.97:1 |
| AvatarMinimalPerf.default | 106 | 110 | 0.96:1 |
| IconMinimalPerf.default | 378 | 399 | 0.95:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 634 | 641 | 5000 | |
| Breadcrumb | mount | 1662 | 1696 | 1000 | |
| Checkbox | mount | 1688 | 1705 | 5000 | |
| CheckboxBase | mount | 1455 | 1493 | 5000 | |
| ChoiceGroup | mount | 2928 | 2961 | 5000 | |
| ComboBox | mount | 677 | 670 | 1000 | |
| CommandBar | mount | 6334 | 6259 | 1000 | |
| ContextualMenu | mount | 13568 | 13188 | 1000 | |
| DefaultButton | mount | 743 | 748 | 5000 | |
| DetailsRow | mount | 2221 | 2212 | 5000 | |
| DetailsRowFast | mount | 2239 | 2210 | 5000 | |
| DetailsRowNoStyles | mount | 2021 | 2024 | 5000 | |
| Dialog | mount | 2651 | 2644 | 1000 | |
| DocumentCardTitle | mount | 227 | 223 | 1000 | |
| Dropdown | mount | 1973 | 1988 | 5000 | |
| FocusTrapZone | mount | 1153 | 1142 | 5000 | |
| FocusZone | mount | 1044 | 1101 | 5000 | |
| GroupedList | mount | 41818 | 41661 | 2 | |
| GroupedList | virtual-rerender | 20156 | 20018 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51990 | 51280 | 2 | |
| GroupedListV2 | mount | 216 | 236 | 2 | |
| GroupedListV2 | virtual-rerender | 218 | 209 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 231 | 234 | 2 | |
| IconButton | mount | 1103 | 1055 | 5000 | |
| Label | mount | 345 | 334 | 5000 | |
| Layer | mount | 2710 | 2743 | 5000 | |
| Link | mount | 386 | 392 | 5000 | |
| MenuButton | mount | 950 | 908 | 5000 | |
| MessageBar | mount | 21902 | 21823 | 5000 | |
| Nav | mount | 1964 | 1965 | 1000 | |
| OverflowSet | mount | 789 | 777 | 5000 | |
| Panel | mount | 1820 | 1840 | 1000 | |
| Persona | mount | 746 | 752 | 1000 | |
| Pivot | mount | 867 | 865 | 1000 | |
| PrimaryButton | mount | 873 | 834 | 5000 | |
| Rating | mount | 4564 | 4578 | 5000 | |
| SearchBox | mount | 941 | 903 | 5000 | |
| Shimmer | mount | 1868 | 1842 | 5000 | |
| Slider | mount | 1326 | 1302 | 5000 | |
| SpinButton | mount | 2954 | 2953 | 5000 | |
| Spinner | mount | 391 | 392 | 5000 | |
| SplitButton | mount | 1800 | 1828 | 5000 | |
| Stack | mount | 417 | 408 | 5000 | |
| StackWithIntrinsicChildren | mount | 849 | 863 | 5000 | |
| StackWithTextChildren | mount | 2642 | 2623 | 5000 | |
| SwatchColorPicker | mount | 6180 | 6170 | 5000 | |
| TagPicker | mount | 1481 | 1514 | 5000 | |
| Text | mount | 365 | 375 | 5000 | |
| TextField | mount | 941 | 933 | 5000 | |
| ThemeProvider | mount | 878 | 842 | 5000 | |
| ThemeProvider | virtual-rerender | 603 | 602 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1300 | 1267 | 5000 | |
| Toggle | mount | 605 | 599 | 5000 | |
| buttonNative | mount | 183 | 201 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b0fa9c:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
force-pushed
the
hotell/node-18-migration
branch
from
1413648 to
54d327c
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d22e99a22d1e52347c3c0a8c9cd1ff870b528a9d (build) |
Hotell
force-pushed
the
hotell/node-18-migration
branch
2 times, most recently
from
14bbcac to
e03f4bd
Compare
ling1726
approved these changes
Oct 24, 2023
…ailures introduced with node 18 types
…nes::unsupported' webpack error within local-sandbox
Hotell
force-pushed
the
hotell/node-18-migration
branch
from
16a975c to
0b0fa9c
Compare
TristanWatanabe
pushed a commit
to TristanWatanabe/fluentui
that referenced
this pull request
Dec 7, 2023
* chore: migrate to node 18 * chore: bump eslint-plugin-jsdoc which support node 18 * generate changefile * chore: ignore plugin-jsdoc from syncpack * chore(utilities): use Timers types based on environment to avoid TS failures introduced with node 18 types * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * generate changefiles
TristanWatanabe
added a commit
that referenced
this pull request
Dec 13, 2023
* chore: migrate to node 18 (#29598) * chore: migrate to node 18 * chore: bump eslint-plugin-jsdoc which support node 18 * generate changefile * chore: ignore plugin-jsdoc from syncpack * chore(utilities): use Timers types based on environment to avoid TS failures introduced with node 18 types * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * generate changefiles * restrict node version * update yarn.lock * ci: bump devcontainer to node 18 (#29759) * deduplicate semver * theme designers: changes based on dan and daisy's feedback (#24038) * for daisy: Can the default theme be the Web one (not Teams)? Web should be the first one selected by default. Teams is one option in the menu. * suggestion from dan: when he inputted his own custom Hex#, the color indicator to the right didn't change -- added rules to hex input * remove teams theme * capitalize for consistency * custom theme now applies to sidebar per dan's request * uppercase consistency * revert sidebar change * theme designer: make name editable (#24098) * add dropdown * Update yarn.lock * cleanup dropdown use * lock update * remove unread values * use dropdown + add avatar * add editable name * palette change * force alphanumeric * filter input name string * update name * revert palette change Co-authored-by: Micah Godbolt <[email protected]> * Theme designer: Move colors to local files (#27191) * move colors code locally to allow for customization * clean up files * deduplicate prettier * fix: UseNode@1 instead of NodeTool * format files * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * update yarn.lock * chore: comment out unused codeblock to fix TS transpile errors --------- Co-authored-by: Martin Hochel <[email protected]> Co-authored-by: Emma Jiang <[email protected]> Co-authored-by: Micah Godbolt <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore: migrate to node 18 (#29598) * chore: migrate to node 18 * chore: bump eslint-plugin-jsdoc which support node 18 * generate changefile * chore: ignore plugin-jsdoc from syncpack * chore(utilities): use Timers types based on environment to avoid TS failures introduced with node 18 types * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * generate changefiles * restrict node version * update yarn.lock * ci: bump devcontainer to node 18 (#29759) * deduplicate semver * theme designers: changes based on dan and daisy's feedback (#24038) * for daisy: Can the default theme be the Web one (not Teams)? Web should be the first one selected by default. Teams is one option in the menu. * suggestion from dan: when he inputted his own custom Hex#, the color indicator to the right didn't change -- added rules to hex input * remove teams theme * capitalize for consistency * custom theme now applies to sidebar per dan's request * uppercase consistency * revert sidebar change * theme designer: make name editable (#24098) * add dropdown * Update yarn.lock * cleanup dropdown use * lock update * remove unread values * use dropdown + add avatar * add editable name * palette change * force alphanumeric * filter input name string * update name * revert palette change Co-authored-by: Micah Godbolt <[email protected]> * Theme designer: Move colors to local files (#27191) * move colors code locally to allow for customization * clean up files * deduplicate prettier * fix: UseNode@1 instead of NodeTool * format files * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * update yarn.lock * chore: comment out unused codeblock to fix TS transpile errors --------- Co-authored-by: Martin Hochel <[email protected]> Co-authored-by: Emma Jiang <[email protected]> Co-authored-by: Micah Godbolt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requirement
Previous Behavior
New Behavior
migrate to LTS node -> 18
Related Issue(s)