Skip to content

Conversation

@srmukher
Copy link
Contributor

Fixing few legend colors not visible in dark mode.
Work item https://uifabric.visualstudio.com/iss/_workitems/edit/8744/

Legend Styled:
Before fix:
image

After fix:
image

Legend Wrap Lines:
Before fix:
image

After fix:
image

@srmukher srmukher requested a review from a team as a code owner October 26, 2023 08:23
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 2210212d48e81327d1e869dff8e4c176cf3b12ef

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d350de3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 26, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2210212d48e81327d1e869dff8e4c176cf3b12ef (build)

@srmukher srmukher merged commit 25e02bd into microsoft:master Oct 26, 2023
@srmukher srmukher deleted the users/srmukher/LegendsDarkMode branch October 26, 2023 09:42
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 26, 2023
* master:
  chore: migrate to nx 16.10 (microsoft#29617)
  fix(react-drawer): accessibility tweaks (microsoft#29627)
  Fixing few legend colors not visible in dark mode (microsoft#29652)
  applying package updates
  Fixing dark mode bug for xAxis for Vertical Stacked bar chart (microsoft#29427)
  chore: Refactor RadioGroup stories to use Field, and remove individual storybook page for Radio (microsoft#29268)
  docs: fix description of SelectInitialValue story (microsoft#26493)
  chore: fix specs location (microsoft#29642)
  feat(scripts-task): implement initial verify-packaging task (microsoft#29595)
  feat(tools): replace npmignore with package.json#files for robust control over what we ship to npm (microsoft#29616)
  fix(workspace-plugin): fix storybook and vr-test issues wihtin prepare-initial-release generator (microsoft#29577)
  feat(react-breadcrumb): removed non-interactive item  (microsoft#29623)
  fix(react-motion): prevent from breaking the rule of hooks (microsoft#29628)
  fix(react-toast): invoke useCustomStyleHook_unstable() (microsoft#29632)
  feat: Deprecate Alert component (microsoft#29615)
  chore(react-infobutton, react-components): Deprecate InfoButton and InfoLabel from react-infobutton (microsoft#29605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants