Skip to content

Conversation

@AtishayMsft
Copy link
Contributor

@AtishayMsft AtishayMsft commented Sep 21, 2023

Previous Behavior

New Behavior

This PR has all the changes to enable publishing the charting controls on fluent 1 doc site. This PR contains the changes that are specific to charting and examples package.

  • Enabled API extraction that is used to publish content to the docsite.
  • Added md files for overview, best practices, do's and donts'.
  • Added doc pages used by public docsite.

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2023

📊 Bundle size report

🤖 This report was generated against 86dd76990e3da5af1f2b6b04a3aec46141d5a653

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50871a0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Sep 21, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: adaf81c0a2a25e2c78001272240065f09bac9217 (build)

@AtishayMsft AtishayMsft changed the title Usr/atisjai/docsite chartingpackage2 Changes to enable charting on fluent docsite Sep 21, 2023
@AtishayMsft AtishayMsft marked this pull request as ready for review September 22, 2023 04:39
@AtishayMsft AtishayMsft requested review from a team as code owners September 22, 2023 04:39
@tudorpopams tudorpopams requested a review from Hotell September 26, 2023 12:19
@AtishayMsft AtishayMsft enabled auto-merge (squash) October 4, 2023 13:41
@AtishayMsft AtishayMsft merged commit e27181b into master Oct 4, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 4, 2023
* master: (35 commits)
  bugfix(react-dialog): removes context hooks invocations from styles hook (microsoft#29396)
  chore(react-dialog): exports DialogSurface context types and hooks (microsoft#29397)
  Minimum height feature for bar chart (microsoft#29359)
  (feat) Breadcrumb - register items via context (microsoft#29393)
  fix: Consider all parents as scroll parents (microsoft#29378)
  Changes to enable charting on fluent docsite (microsoft#29210)
  bugfix: ensure TreeItem emits events properly (microsoft#29390)
  chore(deps): bump get-func-name from 2.0.0 to 2.0.2 (microsoft#29320)
  chore: migrate from getNativeElementProps to getIntrinsicElementProps (microsoft#29387)
  applying package updates
  applying package updates
  fix: Icon in disabled Button shouldn't change color on hover or pressed (microsoft#29342)
  Squish changes for rebase (microsoft#28705)
  fix: GroupedListV2 scrollToIndex now works correctly (microsoft#29332)
  Fix 27482: ProgressBar has an optional state variable  (microsoft#29366)
  remove a11y test ux from theme designer (microsoft#29379)
  feat: preview release (microsoft#29377)
  Fixed divider in the tooltip (microsoft#29357)
  fix (microsoft#29376)
  docs: Initial documentation pass (microsoft#29372)
  ...
@khmakoto khmakoto deleted the usr/atisjai/docsiteChartingpackage2 branch April 22, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants