bugfix(react-dialog): removes context hooks invocations from styles hook #29396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
force-pushed
the
react-dialog/bugfix/removes-context-hook-from-styles-hook
branch
from
dc64b9e to
760e518
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 614 | 622 | 5000 | |
| Button | mount | 323 | 311 | 5000 | |
| Field | mount | 1120 | 1103 | 5000 | |
| FluentProvider | mount | 686 | 690 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 75 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 61 | 65 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 68 | 10 | |
| InfoButton | mount | 15 | 8 | 5000 | |
| MakeStyles | mount | 848 | 835 | 50000 | |
| Persona | mount | 1687 | 1692 | 5000 | |
| SpinButton | mount | 1335 | 1362 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 70cf9a4:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b4611f7230fa90d1f01ab92ded39ebe2f02298f3 (build) |
layershifter
approved these changes
Oct 4, 2023
+ removes native backdrop styles (as we don't support native dialog)
bsunderhus
force-pushed
the
react-dialog/bugfix/removes-context-hook-from-styles-hook
branch
from
760e518 to
70cf9a4
Compare
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
deleted the
react-dialog/bugfix/removes-context-hook-from-styles-hook
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 4, 2023
* master: (35 commits) bugfix(react-dialog): removes context hooks invocations from styles hook (microsoft#29396) chore(react-dialog): exports DialogSurface context types and hooks (microsoft#29397) Minimum height feature for bar chart (microsoft#29359) (feat) Breadcrumb - register items via context (microsoft#29393) fix: Consider all parents as scroll parents (microsoft#29378) Changes to enable charting on fluent docsite (microsoft#29210) bugfix: ensure TreeItem emits events properly (microsoft#29390) chore(deps): bump get-func-name from 2.0.0 to 2.0.2 (microsoft#29320) chore: migrate from getNativeElementProps to getIntrinsicElementProps (microsoft#29387) applying package updates applying package updates fix: Icon in disabled Button shouldn't change color on hover or pressed (microsoft#29342) Squish changes for rebase (microsoft#28705) fix: GroupedListV2 scrollToIndex now works correctly (microsoft#29332) Fix 27482: ProgressBar has an optional state variable (microsoft#29366) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
useDialogSurfaceStylesis invokinguseDialogContextinternally, according to our composition API each composition hook should be independant, and any dependency should be provided through arguments (in the style case, throughstate)New Behavior
DialogSurfaceStateto include necessary value to makeuseDialogSurfaceStylesindependent fromuseDialogContexthookFixes
Problem originally identified here #29392 (comment)