Fix contrast issues in V8 Fluent2 Dark Theme #28486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 83629aa:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 61ce122207774ee3b4193d111bb061e0acd75787 |
Asset size changes
Baseline commit: 61ce122207774ee3b4193d111bb061e0acd75787 (build) |
behowell
approved these changes
Jul 10, 2023
brandonthomas
requested changes
Jul 11, 2023
Contributor
brandonthomas
left a comment
brandonthomas
left a comment
There was a problem hiding this comment.
I noticed the hover color on the secondary text in the CompoundButton is dark in the Fluent 2 dark theme. It should be white as well I believe. Rest looks good.
Contributor
Author
Good catch, I ended up modifying the colors slightly for hovered/pressed after review, it should match what we see in https://react.fluentui.dev/ dark mode now. (Not exactly the same UX coloring as light theme, but it borrows from light themes color schema.) |
brandonthomas
approved these changes
Jul 11, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: (105 commits) fix(react-card): use resolved slot instead of raw prop object (microsoft#28517) applying package updates Expose virtualize index/length for casual use (microsoft#28450) applying package updates chore: update projects to use `*` for inner workspace dependencies (microsoft#28426) Update react-components/react-portal README.md (microsoft#28520) [2 of N] Changes for Making first render cycle faster and fixing test cases (microsoft#27721) applying package updates docs(react-search): Add README, description, best practices (microsoft#28507) Fix contrast issues in V8 Fluent2 Dark Theme (microsoft#28486) [VR-Approval-Cli] Fixed the Bug & Added the pipelineID (microsoft#28506) [Onboarding] Generalized VR-Approval-Cli (microsoft#28255) Onboarding [VR-Approval-CLI] To upload baseline screenshots (microsoft#28294) feat: migrate private v9 react packages to new preview versioning scheme (microsoft#28474) applying package updates applying package updates chore: openItems property added to TreeOpenChangeData + minor internal improvements (microsoft#28491) Fix Virtualizers 'start buffer' overflow (microsoft#28437) docs(v0 migration): add note about nested popups (microsoft#28480) chore: move slots back to TreeItem and creates slot context (microsoft#28492) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Fluent2 Dark Theme for V8 did not respect 'isInverted' flag and used lightmode high-contrast colors for background in some scenarios (message bar warnings etc.)
Primary button color was a slightly lighter shade in dark theme.
New Behavior
IsInverted: true set on Fluent 2 Dark Theme for v8, all background colors should now be appropriate lower-contrast colors.
Primary button color is the same on V8 Fluent 2 dark and light themes.
Related Issue(s)