Skip to content

Fix contrast issues in V8 Fluent2 Dark Theme #28486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mitch-At-Work merged 4 commits into from
Jul 12, 2023
Merged

Fix contrast issues in V8 Fluent2 Dark Theme #28486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90bfe98
Fix up fluent-2 v8 theme contrast colors in dark mode
Mitch-At-Work Jul 10, 2023
df75519
Add change log
Mitch-At-Work Jul 10, 2023
c43f26c
Add all color types
Mitch-At-Work Jul 11, 2023
83629aa
Make sure theme aligns
Mitch-At-Work Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-fluent2-theme-ef95a929-6b64-477a-a5b8-9a5b59e53221.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Ensure fluent2 dark theme isInverted:true, set primary fluent2darktheme button color to match light theme",
"packageName": "@fluentui/fluent2-theme",
"email": "mifraser@microsoft.com",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions packages/fluent2-theme/src/componentStyles/Button.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ export function getPrimaryButtonStyles(theme: ITheme): Partial<IButtonStyles> {
description: {
color: semanticColors.primaryButtonText,
},
descriptionHovered: {
color: semanticColors.primaryButtonText,
},
};

return styles;
Expand Down
7 changes: 7 additions & 0 deletions packages/fluent2-theme/src/fluent2WebDarkTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { createTheme } from '@fluentui/react';
import { IExtendedEffects, IExtendedSemanticColors } from './types';
import { fluent2ComponentStyles } from './fluent2ComponentStyles';
import { fluent2SharedColors } from './fluent2SharedColors';
import { Fluent2WebLightTheme } from './fluent2WebLightTheme';

const fluent2ForV8DarkEffects: IExtendedEffects = {
elevation4: '0px 2px 4px rgba(0, 0, 0, 0.14), 0px 0px 2px rgba(0, 0, 0, 0.12)',
Expand Down Expand Up @@ -56,6 +57,11 @@ const p = fluent2ForV8DarkPalette;
const grey36 = '#5C5C5C';

const semanticColorMappingOverridesForDark: Partial<IExtendedSemanticColors> = {
// Primary button is unique, it's background color is shared across themes
primaryButtonBackgroundHovered: Fluent2WebLightTheme.palette.themePrimary,
primaryButtonBackgroundPressed: Fluent2WebLightTheme.palette.themeDarker,
primaryButtonBackground: Fluent2WebLightTheme.palette.themeDarkAlt,

// This hex matches the v9 theme.
link: p.themeDark,

Expand Down Expand Up @@ -104,4 +110,5 @@ export const Fluent2WebDarkTheme: ITheme = createTheme({
semanticColors: semanticColorMappingOverridesForDark,
components: fluent2ComponentStyles,
effects: fluent2ForV8DarkEffects,
isInverted: true,
});