[Onboarding] Generalized VR-Approval-Cli #28255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 302d94b596b3a81797b5c3207fcc13366d326e93 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1719403:
|
Devjoyti-Barman
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 64 | 66 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 592 | 582 | 5000 | |
| Button | mount | 297 | 278 | 5000 | |
| Field | mount | 1054 | 1039 | 5000 | |
| FluentProvider | mount | 643 | 644 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 74 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 59 | 66 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 64 | 66 | 10 | Possible regression |
| InfoButton | mount | 6 | 11 | 5000 | |
| MakeStyles | mount | 853 | 876 | 50000 | |
| Persona | mount | 1678 | 1605 | 5000 | |
| SpinButton | mount | 1307 | 1316 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 92 | 83 | 1.11:1 |
| TextAreaMinimalPerf.default | 309 | 278 | 1.11:1 |
| HeaderMinimalPerf.default | 213 | 197 | 1.08:1 |
| TreeWith60ListItems.default | 91 | 84 | 1.08:1 |
| RadioGroupMinimalPerf.default | 269 | 251 | 1.07:1 |
| RefMinimalPerf.default | 115 | 107 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 162 | 153 | 1.06:1 |
| CheckboxMinimalPerf.default | 1186 | 1119 | 1.06:1 |
| AttachmentSlotsPerf.default | 630 | 604 | 1.04:1 |
| PopupMinimalPerf.default | 351 | 339 | 1.04:1 |
| ProviderMinimalPerf.default | 203 | 196 | 1.04:1 |
| SplitButtonMinimalPerf.default | 2337 | 2237 | 1.04:1 |
| FlexMinimalPerf.default | 159 | 154 | 1.03:1 |
| FormMinimalPerf.default | 229 | 222 | 1.03:1 |
| GridMinimalPerf.default | 184 | 179 | 1.03:1 |
| ListCommonPerf.default | 394 | 382 | 1.03:1 |
| ListNestedPerf.default | 317 | 307 | 1.03:1 |
| TableManyItemsPerf.default | 1151 | 1122 | 1.03:1 |
| ToolbarMinimalPerf.default | 532 | 519 | 1.03:1 |
| BoxMinimalPerf.default | 194 | 190 | 1.02:1 |
| CarouselMinimalPerf.default | 263 | 259 | 1.02:1 |
| DialogMinimalPerf.default | 455 | 448 | 1.02:1 |
| ListWith60ListItems.default | 374 | 365 | 1.02:1 |
| ProviderMergeThemesPerf.default | 669 | 654 | 1.02:1 |
| SegmentMinimalPerf.default | 198 | 194 | 1.02:1 |
| ChatMinimalPerf.default | 436 | 430 | 1.01:1 |
| DatepickerMinimalPerf.default | 3600 | 3579 | 1.01:1 |
| DropdownManyItemsPerf.default | 396 | 394 | 1.01:1 |
| ListMinimalPerf.default | 307 | 305 | 1.01:1 |
| MenuButtonMinimalPerf.default | 965 | 959 | 1.01:1 |
| RosterPerf.default | 1522 | 1507 | 1.01:1 |
| StatusMinimalPerf.default | 389 | 386 | 1.01:1 |
| CustomToolbarPrototype.default | 1490 | 1481 | 1.01:1 |
| TooltipMinimalPerf.default | 1277 | 1270 | 1.01:1 |
| AnimationMinimalPerf.default | 299 | 300 | 1:1 |
| ButtonOverridesMissPerf.default | 656 | 658 | 1:1 |
| DropdownMinimalPerf.default | 1440 | 1441 | 1:1 |
| InputMinimalPerf.default | 544 | 542 | 1:1 |
| LayoutMinimalPerf.default | 194 | 194 | 1:1 |
| TreeMinimalPerf.default | 477 | 476 | 1:1 |
| DividerMinimalPerf.default | 200 | 203 | 0.99:1 |
| EmbedMinimalPerf.default | 1833 | 1857 | 0.99:1 |
| LabelMinimalPerf.default | 216 | 219 | 0.99:1 |
| LoaderMinimalPerf.default | 192 | 193 | 0.99:1 |
| SliderMinimalPerf.default | 753 | 757 | 0.99:1 |
| TableMinimalPerf.default | 238 | 240 | 0.99:1 |
| AttachmentMinimalPerf.default | 78 | 80 | 0.98:1 |
| ButtonMinimalPerf.default | 85 | 87 | 0.98:1 |
| CardMinimalPerf.default | 306 | 313 | 0.98:1 |
| ItemLayoutMinimalPerf.default | 708 | 719 | 0.98:1 |
| ReactionMinimalPerf.default | 208 | 212 | 0.98:1 |
| ImageMinimalPerf.default | 217 | 224 | 0.97:1 |
| TextMinimalPerf.default | 193 | 200 | 0.97:1 |
| AlertMinimalPerf.default | 158 | 164 | 0.96:1 |
| AvatarMinimalPerf.default | 108 | 112 | 0.96:1 |
| HeaderSlotsPerf.default | 458 | 476 | 0.96:1 |
| MenuMinimalPerf.default | 489 | 509 | 0.96:1 |
| SkeletonMinimalPerf.default | 192 | 200 | 0.96:1 |
| ChatWithPopoverPerf.default | 179 | 188 | 0.95:1 |
| VideoMinimalPerf.default | 413 | 434 | 0.95:1 |
| AccordionMinimalPerf.default | 77 | 82 | 0.94:1 |
| ButtonSlotsPerf.default | 303 | 322 | 0.94:1 |
| IconMinimalPerf.default | 371 | 394 | 0.94:1 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 631 | 622 | 5000 | |
| Breadcrumb | mount | 1651 | 1646 | 1000 | |
| Checkbox | mount | 1706 | 1677 | 5000 | |
| CheckboxBase | mount | 1503 | 1477 | 5000 | |
| ChoiceGroup | mount | 2921 | 2891 | 5000 | |
| ComboBox | mount | 643 | 650 | 1000 | |
| CommandBar | mount | 6251 | 6320 | 1000 | |
| ContextualMenu | mount | 13825 | 13692 | 1000 | |
| DefaultButton | mount | 743 | 767 | 5000 | |
| DetailsRow | mount | 2191 | 2164 | 5000 | |
| DetailsRowFast | mount | 2309 | 2195 | 5000 | |
| DetailsRowNoStyles | mount | 2001 | 2051 | 5000 | |
| Dialog | mount | 2924 | 2584 | 1000 | |
| DocumentCardTitle | mount | 242 | 224 | 1000 | |
| Dropdown | mount | 1977 | 1982 | 5000 | |
| FocusTrapZone | mount | 1186 | 1132 | 5000 | |
| FocusZone | mount | 1023 | 1053 | 5000 | |
| GroupedList | mount | 41658 | 41777 | 2 | |
| GroupedList | virtual-rerender | 20030 | 20039 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50212 | 50564 | 2 | |
| GroupedListV2 | mount | 238 | 226 | 2 | |
| GroupedListV2 | virtual-rerender | 222 | 212 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 228 | 225 | 2 | |
| IconButton | mount | 1074 | 1095 | 5000 | |
| Label | mount | 344 | 324 | 5000 | |
| Layer | mount | 2706 | 2753 | 5000 | |
| Link | mount | 394 | 402 | 5000 | |
| MenuButton | mount | 952 | 954 | 5000 | |
| MessageBar | mount | 21297 | 21233 | 5000 | |
| Nav | mount | 1923 | 1926 | 1000 | |
| OverflowSet | mount | 760 | 777 | 5000 | |
| Panel | mount | 1819 | 1816 | 1000 | |
| Persona | mount | 739 | 744 | 1000 | |
| Pivot | mount | 887 | 855 | 1000 | |
| PrimaryButton | mount | 844 | 829 | 5000 | |
| Rating | mount | 4699 | 4628 | 5000 | |
| SearchBox | mount | 928 | 898 | 5000 | |
| Shimmer | mount | 1890 | 1836 | 5000 | |
| Slider | mount | 1328 | 1325 | 5000 | |
| SpinButton | mount | 2862 | 2866 | 5000 | |
| Spinner | mount | 384 | 392 | 5000 | |
| SplitButton | mount | 1839 | 1782 | 5000 | |
| Stack | mount | 415 | 403 | 5000 | |
| StackWithIntrinsicChildren | mount | 878 | 861 | 5000 | |
| StackWithTextChildren | mount | 2687 | 2628 | 5000 | |
| SwatchColorPicker | mount | 6215 | 6205 | 5000 | |
| TagPicker | mount | 1412 | 1450 | 5000 | |
| Text | mount | 381 | 381 | 5000 | |
| TextField | mount | 923 | 1049 | 5000 | |
| ThemeProvider | mount | 832 | 840 | 5000 | |
| ThemeProvider | virtual-rerender | 589 | 587 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1279 | 1282 | 5000 | |
| Toggle | mount | 617 | 630 | 5000 | |
| buttonNative | mount | 191 | 191 | 5000 |
Devjoyti-Barman
force-pushed
the
user/debarman/testing/vr-approval-tool/test
branch
from
505b87d to
7e86376
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Devjoyti-Barman
force-pushed
the
user/debarman/testing/vr-approval-tool/test
branch
2 times, most recently
from
b71c369 to
e8b9326
Compare
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Devjoyti-Barman
force-pushed
the
user/debarman/testing/vr-approval-tool/test
branch
from
e8b9326 to
91b8f5e
Compare
Devjoyti-Barman
changed the title
Devjoyti-Barman
changed the title
Member
|
/azp run Fluent UI React - PR and CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run Fluent UI React - PR and CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
TristanWatanabe
approved these changes
Jul 6, 2023
Contributor
Author
|
/azp run Fluent UI React - PR and CI |
|
Commenter does not have sufficient privileges for PR 28255 in repo microsoft/fluentui |
Member
|
/azp run Fluent UI React - PR and CI |
|
No commit pushedDate could be found for PR 28255 in repo microsoft/fluentui |
Member
|
/azp run Fluent UI React - PR and CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
piyush-2712
approved these changes
Jul 12, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: (105 commits) fix(react-card): use resolved slot instead of raw prop object (microsoft#28517) applying package updates Expose virtualize index/length for casual use (microsoft#28450) applying package updates chore: update projects to use `*` for inner workspace dependencies (microsoft#28426) Update react-components/react-portal README.md (microsoft#28520) [2 of N] Changes for Making first render cycle faster and fixing test cases (microsoft#27721) applying package updates docs(react-search): Add README, description, best practices (microsoft#28507) Fix contrast issues in V8 Fluent2 Dark Theme (microsoft#28486) [VR-Approval-Cli] Fixed the Bug & Added the pipelineID (microsoft#28506) [Onboarding] Generalized VR-Approval-Cli (microsoft#28255) Onboarding [VR-Approval-CLI] To upload baseline screenshots (microsoft#28294) feat: migrate private v9 react packages to new preview versioning scheme (microsoft#28474) applying package updates applying package updates chore: openItems property added to TreeOpenChangeData + minor internal improvements (microsoft#28491) Fix Virtualizers 'start buffer' overflow (microsoft#28437) docs(v0 migration): add note about nested popups (microsoft#28480) chore: move slots back to TreeItem and creates slot context (microsoft#28492) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We used to do diffing with the old vr-approval-cli.
New Behavior
In this PR, we will use generalized version of vr-approval-cli.
Related Issue(s)