fix(react-card): use resolved slot instead of raw prop object #28517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 600 | 586 | 5000 | |
| Button | mount | 289 | 288 | 5000 | |
| Field | mount | 1049 | 1082 | 5000 | |
| FluentProvider | mount | 655 | 638 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 68 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 66 | 66 | 10 | |
| InfoButton | mount | 15 | 9 | 5000 | |
| MakeStyles | mount | 849 | 848 | 50000 | |
| Persona | mount | 1687 | 1598 | 5000 | |
| SpinButton | mount | 1360 | 1298 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c15ba47:
|
Asset size changes
Baseline commit: 57de08c18915440cdc54a1242bbdf948e2b0f562 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
behowell
approved these changes
Jul 13, 2023
Contributor
behowell
left a comment
behowell
left a comment
There was a problem hiding this comment.
Added a comment about how to simplify this logic. It's probably better to merge this PR as it is now, and address my comment in a future PR, so as not to delay this bugfix.
packages/react-components/react-card/src/components/CardHeader/useCardHeader.ts
Show resolved
Hide resolved
ValentinaKozlova
approved these changes
Jul 14, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: (105 commits) fix(react-card): use resolved slot instead of raw prop object (microsoft#28517) applying package updates Expose virtualize index/length for casual use (microsoft#28450) applying package updates chore: update projects to use `*` for inner workspace dependencies (microsoft#28426) Update react-components/react-portal README.md (microsoft#28520) [2 of N] Changes for Making first render cycle faster and fixing test cases (microsoft#27721) applying package updates docs(react-search): Add README, description, best practices (microsoft#28507) Fix contrast issues in V8 Fluent2 Dark Theme (microsoft#28486) [VR-Approval-Cli] Fixed the Bug & Added the pipelineID (microsoft#28506) [Onboarding] Generalized VR-Approval-Cli (microsoft#28255) Onboarding [VR-Approval-CLI] To upload baseline screenshots (microsoft#28294) feat: migrate private v9 react packages to new preview versioning scheme (microsoft#28474) applying package updates applying package updates chore: openItems property added to TreeOpenChangeData + minor internal improvements (microsoft#28491) Fix Virtualizers 'start buffer' overflow (microsoft#28437) docs(v0 migration): add note about nested popups (microsoft#28480) chore: move slots back to TreeItem and creates slot context (microsoft#28492) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with card trying to resolve the header prop before calling
resolveShorthand. For more information, please refer to the original bug.