feat: migrate private v9 react packages to new preview versioning scheme #28474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
force-pushed
the
hotell/release/migrate-v9-private-to-new-versioning-scheme
branch
from
bd1c3f2 to
d3a0b6c
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 12 | 14 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 585 | 605 | 5000 | |
| Button | mount | 302 | 296 | 5000 | |
| Field | mount | 1090 | 1054 | 5000 | |
| FluentProvider | mount | 659 | 638 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 77 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 70 | 60 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 77 | 10 | |
| InfoButton | mount | 12 | 14 | 5000 | Possible regression |
| MakeStyles | mount | 849 | 834 | 50000 | |
| Persona | mount | 1653 | 1640 | 5000 | |
| SpinButton | mount | 1318 | 1290 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 81 | 73 | 1.11:1 |
| PortalMinimalPerf.default | 89 | 83 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 150 | 142 | 1.06:1 |
| LabelMinimalPerf.default | 236 | 222 | 1.06:1 |
| SkeletonMinimalPerf.default | 202 | 191 | 1.06:1 |
| TableMinimalPerf.default | 250 | 236 | 1.06:1 |
| TextAreaMinimalPerf.default | 302 | 284 | 1.06:1 |
| AttachmentMinimalPerf.default | 87 | 83 | 1.05:1 |
| ButtonMinimalPerf.default | 96 | 91 | 1.05:1 |
| SegmentMinimalPerf.default | 193 | 183 | 1.05:1 |
| CarouselMinimalPerf.default | 265 | 255 | 1.04:1 |
| ChatWithPopoverPerf.default | 192 | 185 | 1.04:1 |
| DividerMinimalPerf.default | 216 | 207 | 1.04:1 |
| GridMinimalPerf.default | 195 | 187 | 1.04:1 |
| ProviderMergeThemesPerf.default | 714 | 685 | 1.04:1 |
| TreeWith60ListItems.default | 86 | 83 | 1.04:1 |
| DialogMinimalPerf.default | 456 | 444 | 1.03:1 |
| FlexMinimalPerf.default | 157 | 152 | 1.03:1 |
| MenuMinimalPerf.default | 509 | 494 | 1.03:1 |
| CustomToolbarPrototype.default | 1515 | 1471 | 1.03:1 |
| AlertMinimalPerf.default | 169 | 165 | 1.02:1 |
| AttachmentSlotsPerf.default | 659 | 646 | 1.02:1 |
| DatepickerMinimalPerf.default | 3718 | 3646 | 1.02:1 |
| ListWith60ListItems.default | 378 | 369 | 1.02:1 |
| TableManyItemsPerf.default | 1137 | 1114 | 1.02:1 |
| BoxMinimalPerf.default | 199 | 197 | 1.01:1 |
| HeaderMinimalPerf.default | 212 | 209 | 1.01:1 |
| MenuButtonMinimalPerf.default | 961 | 954 | 1.01:1 |
| ProviderMinimalPerf.default | 203 | 201 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2284 | 2252 | 1.01:1 |
| StatusMinimalPerf.default | 398 | 394 | 1.01:1 |
| TreeMinimalPerf.default | 491 | 488 | 1.01:1 |
| AvatarMinimalPerf.default | 106 | 106 | 1:1 |
| ButtonOverridesMissPerf.default | 655 | 653 | 1:1 |
| CheckboxMinimalPerf.default | 1162 | 1164 | 1:1 |
| EmbedMinimalPerf.default | 1876 | 1880 | 1:1 |
| FormMinimalPerf.default | 226 | 227 | 1:1 |
| ImageMinimalPerf.default | 229 | 229 | 1:1 |
| ListMinimalPerf.default | 306 | 307 | 1:1 |
| ListNestedPerf.default | 325 | 324 | 1:1 |
| PopupMinimalPerf.default | 346 | 347 | 1:1 |
| RefMinimalPerf.default | 108 | 108 | 1:1 |
| TooltipMinimalPerf.default | 1252 | 1246 | 1:1 |
| VideoMinimalPerf.default | 426 | 426 | 1:1 |
| AnimationMinimalPerf.default | 292 | 294 | 0.99:1 |
| DropdownManyItemsPerf.default | 397 | 399 | 0.99:1 |
| InputMinimalPerf.default | 536 | 540 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 719 | 723 | 0.99:1 |
| LoaderMinimalPerf.default | 193 | 194 | 0.99:1 |
| ToolbarMinimalPerf.default | 538 | 544 | 0.99:1 |
| ButtonSlotsPerf.default | 302 | 309 | 0.98:1 |
| ChatMinimalPerf.default | 428 | 438 | 0.98:1 |
| ReactionMinimalPerf.default | 210 | 215 | 0.98:1 |
| SliderMinimalPerf.default | 741 | 755 | 0.98:1 |
| CardMinimalPerf.default | 304 | 312 | 0.97:1 |
| DropdownMinimalPerf.default | 1405 | 1445 | 0.97:1 |
| RadioGroupMinimalPerf.default | 257 | 265 | 0.97:1 |
| IconMinimalPerf.default | 370 | 381 | 0.97:1 |
| ListCommonPerf.default | 399 | 417 | 0.96:1 |
| HeaderSlotsPerf.default | 454 | 479 | 0.95:1 |
| LayoutMinimalPerf.default | 198 | 210 | 0.94:1 |
| RosterPerf.default | 1436 | 1531 | 0.94:1 |
| TextMinimalPerf.default | 182 | 205 | 0.89:1 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 622 | 610 | 5000 | |
| Breadcrumb | mount | 1690 | 1685 | 1000 | |
| Checkbox | mount | 1671 | 1702 | 5000 | |
| CheckboxBase | mount | 1499 | 1486 | 5000 | |
| ChoiceGroup | mount | 2965 | 2937 | 5000 | |
| ComboBox | mount | 652 | 648 | 1000 | |
| CommandBar | mount | 6163 | 6178 | 1000 | |
| ContextualMenu | mount | 11954 | 12603 | 1000 | |
| DefaultButton | mount | 725 | 751 | 5000 | |
| DetailsRow | mount | 2166 | 2158 | 5000 | |
| DetailsRowFast | mount | 2180 | 2170 | 5000 | |
| DetailsRowNoStyles | mount | 1998 | 1996 | 5000 | |
| Dialog | mount | 2652 | 2768 | 1000 | |
| DocumentCardTitle | mount | 233 | 235 | 1000 | |
| Dropdown | mount | 1939 | 1946 | 5000 | |
| FocusTrapZone | mount | 1143 | 1152 | 5000 | |
| FocusZone | mount | 1053 | 1065 | 5000 | |
| GroupedList | mount | 40796 | 41038 | 2 | |
| GroupedList | virtual-rerender | 19639 | 19637 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50584 | 50283 | 2 | |
| GroupedListV2 | mount | 212 | 216 | 2 | |
| GroupedListV2 | virtual-rerender | 205 | 207 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 221 | 234 | 2 | |
| IconButton | mount | 1051 | 1088 | 5000 | |
| Label | mount | 344 | 350 | 5000 | |
| Layer | mount | 2742 | 2730 | 5000 | |
| Link | mount | 393 | 390 | 5000 | |
| MenuButton | mount | 899 | 938 | 5000 | |
| MessageBar | mount | 21409 | 21386 | 5000 | |
| Nav | mount | 1916 | 1921 | 1000 | |
| OverflowSet | mount | 740 | 778 | 5000 | |
| Panel | mount | 2089 | 1761 | 1000 | |
| Persona | mount | 719 | 755 | 1000 | |
| Pivot | mount | 833 | 874 | 1000 | |
| PrimaryButton | mount | 841 | 851 | 5000 | |
| Rating | mount | 4538 | 4644 | 5000 | |
| SearchBox | mount | 920 | 908 | 5000 | |
| Shimmer | mount | 1807 | 1869 | 5000 | |
| Slider | mount | 1351 | 1318 | 5000 | |
| SpinButton | mount | 2881 | 2831 | 5000 | |
| Spinner | mount | 380 | 395 | 5000 | |
| SplitButton | mount | 1793 | 1838 | 5000 | |
| Stack | mount | 399 | 406 | 5000 | |
| StackWithIntrinsicChildren | mount | 851 | 865 | 5000 | |
| StackWithTextChildren | mount | 2600 | 2637 | 5000 | |
| SwatchColorPicker | mount | 6007 | 5930 | 5000 | |
| TagPicker | mount | 1419 | 1424 | 5000 | |
| Text | mount | 371 | 374 | 5000 | |
| TextField | mount | 946 | 938 | 5000 | |
| ThemeProvider | mount | 822 | 823 | 5000 | |
| ThemeProvider | virtual-rerender | 571 | 587 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1259 | 1288 | 5000 | |
| Toggle | mount | 596 | 629 | 5000 | |
| buttonNative | mount | 185 | 190 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 49b1656:
|
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1c318c5cfaee8e50fd644f02d21ffa8cbc2f99e0 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
JustSlone
reviewed
Jul 10, 2023
JustSlone
approved these changes
Jul 10, 2023
Hotell
force-pushed
the
hotell/release/migrate-v9-private-to-new-versioning-scheme
branch
from
1c85499 to
af0a970
Compare
emmayjiang
approved these changes
Jul 10, 2023
behowell
approved these changes
Jul 10, 2023
ling1726
approved these changes
Jul 11, 2023
…view versioning scheme for v9 react packages
Hotell
force-pushed
the
hotell/release/migrate-v9-private-to-new-versioning-scheme
branch
from
e5d575c to
49b1656
Compare
fabricteam
reviewed
Jul 12, 2023
marcosmoura
approved these changes
Jul 12, 2023
Contributor
marcosmoura
left a comment
marcosmoura
left a comment
There was a problem hiding this comment.
Approved for files owned by @microsoft/cxe-prg
tudorpopams
approved these changes
Jul 12, 2023
Hotell
deleted the
hotell/release/migrate-v9-private-to-new-versioning-scheme
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: (105 commits) fix(react-card): use resolved slot instead of raw prop object (microsoft#28517) applying package updates Expose virtualize index/length for casual use (microsoft#28450) applying package updates chore: update projects to use `*` for inner workspace dependencies (microsoft#28426) Update react-components/react-portal README.md (microsoft#28520) [2 of N] Changes for Making first render cycle faster and fixing test cases (microsoft#27721) applying package updates docs(react-search): Add README, description, best practices (microsoft#28507) Fix contrast issues in V8 Fluent2 Dark Theme (microsoft#28486) [VR-Approval-Cli] Fixed the Bug & Added the pipelineID (microsoft#28506) [Onboarding] Generalized VR-Approval-Cli (microsoft#28255) Onboarding [VR-Approval-CLI] To upload baseline screenshots (microsoft#28294) feat: migrate private v9 react packages to new preview versioning scheme (microsoft#28474) applying package updates applying package updates chore: openItems property added to TreeOpenChangeData + minor internal improvements (microsoft#28491) Fix Virtualizers 'start buffer' overflow (microsoft#28437) docs(v0 migration): add note about nested popups (microsoft#28480) chore: move slots back to TreeItem and creates slot context (microsoft#28492) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
updates
create-packagescaffold to accomodate new preview/unstable versioning schememigrates 3 v9 packages that have not been released yet to npm:
Related Issue(s)