chore(react-utilities): simplifies useControllableState hook internals #27702
+13
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df609f8:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 37e89b9319db7f31f3afe0d38fc31eac40cb5eaf (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 22 | 19 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 824 | 841 | 5000 | |
| Button | mount | 454 | 434 | 5000 | |
| Field | mount | 1507 | 1566 | 5000 | |
| FluentProvider | mount | 1073 | 1079 | 5000 | |
| FluentProviderWithTheme | mount | 133 | 132 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 110 | 118 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 123 | 116 | 10 | |
| InfoButton | mount | 22 | 19 | 5000 | Possible regression |
| MakeStyles | mount | 1307 | 1318 | 50000 | |
| Persona | mount | 2444 | 2364 | 5000 | |
| SpinButton | mount | 1870 | 1856 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
approved these changes
Apr 26, 2023
Contributor
|
@bsunderhus I think this PR also fixes #25748, would you be able to check? |
bsunderhus
deleted the
react-utilities/chore--simplifies-useControllableState-hook
branch
| * @returns - whether the value is controlled | ||
| */ | ||
| const useIsControlled = (controlledValue: unknown) => { | ||
| const useIsControlled = <V>(controlledValue?: V): controlledValue is V => { |
Member
There was a problem hiding this comment.
nit: value should be always passed
const useIsControlled = <V>(controlledValue: V | undefined): controlledValue is V => {
Comment on lines
41
to
42
| const initialState = typeof options.defaultState === 'undefined' ? options.initialState : options.defaultState; | ||
| const [internalState, setInternalState] = React.useState<State>(initialState); |
Member
There was a problem hiding this comment.
One more improvement might to move the check to factory, so it will be executed once:
const [internalState, setInternalState] = React.useState<State>(
() => typeof options.defaultState === 'undefined' ? options.initialState : options.defaultState
);
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 27, 2023
* master: chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707) chore: migrate to NodeJS v16 (microsoft#27711) remove react-avatar-context package (microsoft#27709) test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669) chore: Add caret to react-datepicker-compat dependencies (microsoft#27671) test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661) chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702) chore: enforce files naming to use .styles.ts (microsoft#27698) feat: adds lazy loading example (microsoft#27587) feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025) chore(react-tree): updates useOpenItemsState internals (microsoft#27697) feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668) test: use `isolatedModules` for all ts-jest configs to lower memory footprint on CI (microsoft#27670) chore: bump @griffel/eslint-plugin & enable @griffel/hook-naming (microsoft#27687) feat(react-tree): makes useFlatTree generic (microsoft#27682) Enable export to codepen for charting library (microsoft#27539) Overflow: added useOverflowCount to exports (microsoft#27678) fix: Menu should not steal focus on re-render (microsoft#27688) feat(react-conformance): add new TS config api to be able to specify configName and configDir (microsoft#27664)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 27, 2023
* feat/drawer-components: (28 commits) docs: update API feat: add style overrides for upcoming drawer components feat: add support to override drawer styles fix: prevent elements from stretching chore: upgrade devcontainer node version to 16 (microsoft#27716) fix: rename styles file to use the newer naming conventions test: add cypress tests for scroll positions chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707) feat: add support to override drawer body styles chore: migrate to NodeJS v16 (microsoft#27711) remove react-avatar-context package (microsoft#27709) test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669) chore: Add caret to react-datepicker-compat dependencies (microsoft#27671) test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661) chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702) chore: enforce files naming to use .styles.ts (microsoft#27698) feat: adds lazy loading example (microsoft#27587) feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025) chore(react-tree): updates useOpenItemsState internals (microsoft#27697) feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668) ...
Collaborator
|
🎉 Handy links: |
2 tasks
layershifter
added a commit
to layershifter/office-ui-fabric-react
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
useControllableStateimplementation but ensuring same functionality according to tests