Overflow: added useOverflowCount to exports #27678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesUnable to find bundle size details for Baseline commit: 3a6bbb0 Possible causes
Recommendations
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 719 | 699 | 5000 | |
| Button | mount | 380 | 378 | 5000 | |
| Field | mount | 1265 | 1296 | 5000 | |
| FluentProvider | mount | 911 | 911 | 5000 | |
| FluentProviderWithTheme | mount | 112 | 120 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 94 | 96 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 101 | 106 | 10 | |
| InfoButton | mount | 20 | 18 | 5000 | |
| MakeStyles | mount | 1130 | 1128 | 50000 | |
| Persona | mount | 2036 | 1984 | 5000 | |
| SpinButton | mount | 1580 | 1574 | 5000 |
Contributor
|
@kkakroo thanks for contributing. To make CI pass please do the following:
|
Contributor
Author
|
Hi @ling1726, have updated the api markdown file but |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c88fd14:
|
ling1726
reviewed
Apr 25, 2023
change/@fluentui-react-components-9cf91ecc-b503-4ff6-92cb-f50e3d21b209.json
Outdated
Show resolved
Hide resolved
ling1726
approved these changes
Apr 25, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 27, 2023
* master: chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707) chore: migrate to NodeJS v16 (microsoft#27711) remove react-avatar-context package (microsoft#27709) test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669) chore: Add caret to react-datepicker-compat dependencies (microsoft#27671) test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661) chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702) chore: enforce files naming to use .styles.ts (microsoft#27698) feat: adds lazy loading example (microsoft#27587) feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025) chore(react-tree): updates useOpenItemsState internals (microsoft#27697) feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668) test: use `isolatedModules` for all ts-jest configs to lower memory footprint on CI (microsoft#27670) chore: bump @griffel/eslint-plugin & enable @griffel/hook-naming (microsoft#27687) feat(react-tree): makes useFlatTree generic (microsoft#27682) Enable export to codepen for charting library (microsoft#27539) Overflow: added useOverflowCount to exports (microsoft#27678) fix: Menu should not steal focus on re-render (microsoft#27688) feat(react-conformance): add new TS config api to be able to specify configName and configDir (microsoft#27664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
useOverflowCount was not exported from fluentui/react-components
New Behavior
useOverflowCount is now being exported from fluentui/react-components
Related Issue(s)