-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(react-utilities): updates useControllableState comments #27754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-utilities): updates useControllableState comments #27754
Conversation
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 21 | 19 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 710 | 712 | 5000 | |
| Button | mount | 376 | 370 | 5000 | |
| Field | mount | 1271 | 1244 | 5000 | |
| FluentProvider | mount | 919 | 919 | 5000 | |
| FluentProviderWithTheme | mount | 120 | 120 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 96 | 99 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 108 | 110 | 10 | |
| InfoButton | mount | 21 | 19 | 5000 | Possible regression |
| MakeStyles | mount | 1128 | 1128 | 50000 | |
| Persona | mount | 2029 | 1955 | 5000 | |
| SpinButton | mount | 1553 | 1549 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34773da:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 43d6e99d28aa0e7bd7111f1043348683646eaa5b (build) |
📊 Bundle size reportUnchanged fixtures
|
|
Can you please also apply comments from the previous PR #27702 (review)? 🙏 |
🕵 fluentuiv9 No visual regressions between this PR and main |
The follow up on that is here: #27717 |
|
🎉 Handy links: |
New Behavior
Improves documentation for
useControllableStateto ensure a better understanding of how the hook properly operates.Related Issue(s)
useControllableStateis not able to sync internal state with incoming state #25748