Enable export to codepen for charting library #27539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report🤖 This report was generated against d80eca9d508c9a8afe4b461d56fb172cd2d557b5 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3babbf1:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d80eca9d508c9a8afe4b461d56fb172cd2d557b5 (build) |
AtishayMsft
changed the title
khmakoto
approved these changes
Apr 25, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 27, 2023
* master: chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707) chore: migrate to NodeJS v16 (microsoft#27711) remove react-avatar-context package (microsoft#27709) test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669) chore: Add caret to react-datepicker-compat dependencies (microsoft#27671) test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661) chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702) chore: enforce files naming to use .styles.ts (microsoft#27698) feat: adds lazy loading example (microsoft#27587) feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025) chore(react-tree): updates useOpenItemsState internals (microsoft#27697) feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668) test: use `isolatedModules` for all ts-jest configs to lower memory footprint on CI (microsoft#27670) chore: bump @griffel/eslint-plugin & enable @griffel/hook-naming (microsoft#27687) feat(react-tree): makes useFlatTree generic (microsoft#27682) Enable export to codepen for charting library (microsoft#27539) Overflow: added useOverflowCount to exports (microsoft#27678) fix: Menu should not steal focus on re-render (microsoft#27688) feat(react-conformance): add new TS config api to be able to specify configName and configDir (microsoft#27664)
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉This issue was addressed in #27728, which has now been successfully released as Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
There is no export to codepen button for charting library.
As the charting library is getting adopted by more teams, there is an increasing need to quickly try out the charting components with different scenarios and properties.
There is also a need to quickly validate the behavior, bugfixes or reproing issues in different build versions of the library.
New Behavior
To solve the above problem, we have decided to support export to codepen functionality for react charting library.
To prevent any unintended behavior, I have limited this functionality only for charting demo site.
Try it here: https://fluentuipr.z22.web.core.windows.net/pull/27539/react-charting/demo/index.html#/examples/areachart
Related Issue(s)