Skip to content

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented May 24, 2023

New Behavior

Fixes regression introduced in #27702.

New test is added for the scenario used in DataGrid hooks.

Related Issue(s)

Fixes #27896

@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 24, 2023
@layershifter layershifter marked this pull request as ready for review May 24, 2023 08:52
@layershifter layershifter requested a review from a team as a code owner May 24, 2023 08:52
@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 559 575 5000
Button mount 283 295 5000
Field mount 985 1051 5000
FluentProvider mount 639 651 5000
FluentProviderWithTheme mount 81 85 10
FluentProviderWithTheme virtual-rerender 67 69 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 75 10
InfoButton mount 14 12 5000
MakeStyles mount 863 851 50000
Persona mount 1613 1584 5000
SpinButton mount 1231 1276 5000

@size-auditor
Copy link

size-auditor bot commented May 24, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dc612644bc698fa8a8f315167d759f16c9a41d82 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e401a37:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
88.329 kB
26.706 kB
88.473 kB
26.754 kB
144 B
48 B
react-button
ToggleButton
54.866 kB
11.367 kB
55.01 kB
11.4 kB
144 B
33 B
react-checkbox
Checkbox
34.268 kB
10.793 kB
34.413 kB
10.827 kB
145 B
34 B
react-combobox
Combobox (including child components)
87.251 kB
28.1 kB
87.396 kB
28.137 kB
145 B
37 B
react-combobox
Dropdown (including child components)
85.635 kB
27.697 kB
85.78 kB
27.744 kB
145 B
47 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
205.944 kB
57.706 kB
206.09 kB
57.742 kB
146 B
36 B
react-datepicker-compat
DatePicker Compat
221.446 kB
58.861 kB
221.597 kB
58.904 kB
151 B
43 B
react-dialog
Dialog (including children components)
91.892 kB
27.42 kB
92.035 kB
27.441 kB
143 B
21 B
react-infobutton
InfoButton
129.685 kB
39.584 kB
129.836 kB
39.619 kB
151 B
35 B
react-infobutton
InfoLabel
133.154 kB
40.672 kB
133.305 kB
40.691 kB
151 B
19 B
react-input
Input
24.024 kB
7.682 kB
24.167 kB
7.719 kB
143 B
37 B
react-menu
Menu (including children components)
130.392 kB
39.788 kB
130.537 kB
39.824 kB
145 B
36 B
react-menu
Menu (including selectable components)
133.376 kB
40.307 kB
133.521 kB
40.345 kB
145 B
38 B
react-popover
Popover
116.676 kB
35.957 kB
116.812 kB
36.006 kB
136 B
49 B
react-slider
Slider
34.164 kB
11.024 kB
34.308 kB
11.063 kB
144 B
39 B
react-spinbutton
SpinButton
33.934 kB
10.328 kB
34.079 kB
10.372 kB
145 B
44 B
react-table
DataGrid
149.721 kB
41.154 kB
149.871 kB
41.174 kB
150 B
20 B
react-table
Table as DataGrid
132.279 kB
33.668 kB
132.427 kB
33.748 kB
148 B
80 B
react-table
Table (Selection only)
78.056 kB
19.084 kB
78.201 kB
19.143 kB
145 B
59 B
react-table
Table (Sort only)
77.386 kB
18.896 kB
77.531 kB
18.953 kB
145 B
57 B
react-textarea
Textarea
27.528 kB
9.051 kB
27.673 kB
9.089 kB
145 B
38 B
react-tooltip
Tooltip
46.708 kB
16.376 kB
46.853 kB
16.408 kB
145 B
32 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
560 B
352 B
react-alert
Alert
93.534 kB
22.497 kB
react-avatar
Avatar
57.754 kB
15.041 kB
react-avatar
AvatarGroup
15.632 kB
6.258 kB
react-avatar
AvatarGroupItem
73.968 kB
19.552 kB
react-badge
Badge
23.512 kB
7.197 kB
react-badge
CounterBadge
24.416 kB
7.506 kB
react-badge
PresenceBadge
32.094 kB
8.367 kB
react-button
Button
36.724 kB
9.458 kB
react-button
CompoundButton
43.873 kB
10.939 kB
react-button
MenuButton
41.411 kB
10.791 kB
react-button
SplitButton
49.635 kB
12.364 kB
react-card
Card - All
88.428 kB
25.004 kB
react-card
Card
83.363 kB
23.556 kB
react-card
CardFooter
9.158 kB
3.844 kB
react-card
CardHeader
11.048 kB
4.538 kB
react-card
CardPreview
9.963 kB
4.192 kB
react-components
react-components: Button, FluentProvider & webLightTheme
64.855 kB
17.852 kB
react-components
react-components: FluentProvider & webLightTheme
36.086 kB
11.9 kB
react-divider
Divider
17.399 kB
6.298 kB
react-field
Field
18.864 kB
7.004 kB
react-image
Image
11.479 kB
4.573 kB
react-label
Label
10.104 kB
4.185 kB
react-link
Link
12.304 kB
5.061 kB
react-overflow
hooks only
11.214 kB
4.271 kB
react-persona
Persona
64.675 kB
16.968 kB
react-portal
Portal
11.649 kB
4.262 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.186 kB
react-positioning
usePositioning
24.008 kB
8.798 kB
react-progress
ProgressBar
13.856 kB
5.434 kB
react-provider
FluentProvider
18.033 kB
6.666 kB
react-radio
Radio
27.282 kB
8.661 kB
react-radio
RadioGroup
11.312 kB
4.71 kB
react-select
Select
25.357 kB
8.798 kB
react-spinner
Spinner
20.882 kB
6.798 kB
react-switch
Switch
29.806 kB
9.274 kB
react-table
Table (Primitives only)
44.348 kB
12.347 kB
react-tags
Tag
21.99 kB
7.887 kB
react-text
Text - Default
12.492 kB
4.92 kB
react-text
Text - Wrappers
15.624 kB
5.232 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against dc612644bc698fa8a8f315167d759f16c9a41d82

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@layershifter layershifter force-pushed the fix/use-controllable-state branch from 2a20fea to e401a37 Compare May 24, 2023 11:40
@layershifter layershifter changed the title fix(react-utilities): revert #27702 fix(react-utilities): fix dispatcher behavior May 24, 2023
@layershifter layershifter merged commit 4e46338 into microsoft:master May 25, 2023
@layershifter layershifter deleted the fix/use-controllable-state branch May 25, 2023 08:17
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DataGrid single and multiple select controlled not work

5 participants