fix: TableCellActions displays correctly inside TableHeaderCell
#24829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button slot in `TableHeaderCell` did not have `position: relative` so the absolute positioning of the actions made them appear incorrectly when placed within a header cell
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ef7f86:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 17278782ca2c1d4051389cf8741224cde6672e88 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1286 | 1251 | 5000 | |
| Button | mount | 930 | 935 | 5000 | |
| FluentProvider | mount | 1480 | 1487 | 5000 | |
| FluentProviderWithTheme | mount | 580 | 574 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 537 | 542 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 583 | 576 | 10 | |
| MakeStyles | mount | 1961 | 1966 | 50000 | |
| SpinButton | mount | 2378 | 2371 | 5000 |
bsunderhus
approved these changes
Sep 16, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 20, 2022
* master: feat(cicd): update docsite publish workflow to publish to github pages (microsoft#24846) docs(README): add EP03 (microsoft#24854) applying package updates Set minimum width of 1% for multi stacked horizontal bar chart (microsoft#24835) ci: make create-milestone work by adding missing permissions (microsoft#24851) fix: `TableCellActions` displays correctly inside `TableHeaderCell` (microsoft#24829) ci(github): fix invalid json string in issues.yml (microsoft#24853)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 20, 2022
* master: feat(cicd): update docsite publish workflow to publish to github pages (microsoft#24846) docs(README): add EP03 (microsoft#24854) applying package updates Set minimum width of 1% for multi stacked horizontal bar chart (microsoft#24835) ci: make create-milestone work by adding missing permissions (microsoft#24851) fix: `TableCellActions` displays correctly inside `TableHeaderCell` (microsoft#24829) ci(github): fix invalid json string in issues.yml (microsoft#24853)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button slot in
TableHeaderCelldid not haveposition: relativeso the absolute positioning of the actions made them appear incorrectly when placed within a header cellFixes #