Skip to content

Conversation

@layershifter
Copy link
Member

This PR adds a reference to EP03 about Griffel.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 15ccfe5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 19, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cd9c220e8ca2c6ab0bc4b598801ce38eee21688f (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1269 1297 5000
Button mount 931 932 5000
FluentProvider mount 1493 1505 5000
FluentProviderWithTheme mount 587 574 10
FluentProviderWithTheme virtual-rerender 550 553 10
FluentProviderWithTheme virtual-rerender-with-unmount 583 579 10
MakeStyles mount 1952 1944 50000
SpinButton mount 2323 2392 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 195 173 1.13:1
TreeWith60ListItems.default 189 169 1.12:1
RefMinimalPerf.default 236 214 1.1:1
ChatDuplicateMessagesPerf.default 326 304 1.07:1
SkeletonMinimalPerf.default 384 360 1.07:1
TextAreaMinimalPerf.default 568 531 1.07:1
AvatarMinimalPerf.default 212 200 1.06:1
DividerMinimalPerf.default 393 374 1.05:1
ReactionMinimalPerf.default 425 405 1.05:1
BoxMinimalPerf.default 374 358 1.04:1
SegmentMinimalPerf.default 371 357 1.04:1
FormMinimalPerf.default 431 418 1.03:1
ImageMinimalPerf.default 452 440 1.03:1
ItemLayoutMinimalPerf.default 1306 1265 1.03:1
ListNestedPerf.default 643 627 1.03:1
MenuButtonMinimalPerf.default 1857 1801 1.03:1
CardMinimalPerf.default 599 585 1.02:1
InputMinimalPerf.default 1237 1212 1.02:1
LayoutMinimalPerf.default 392 385 1.02:1
ListCommonPerf.default 706 692 1.02:1
ListMinimalPerf.default 563 550 1.02:1
PopupMinimalPerf.default 678 664 1.02:1
CustomToolbarPrototype.default 2765 2704 1.02:1
TooltipMinimalPerf.default 2495 2451 1.02:1
AccordionMinimalPerf.default 160 159 1.01:1
ButtonSlotsPerf.default 576 569 1.01:1
EmbedMinimalPerf.default 3934 3907 1.01:1
LabelMinimalPerf.default 416 413 1.01:1
LoaderMinimalPerf.default 715 707 1.01:1
MenuMinimalPerf.default 912 901 1.01:1
PortalMinimalPerf.default 171 170 1.01:1
ProviderMinimalPerf.default 415 411 1.01:1
RadioGroupMinimalPerf.default 486 483 1.01:1
IconMinimalPerf.default 716 712 1.01:1
TableMinimalPerf.default 436 431 1.01:1
TextMinimalPerf.default 368 366 1.01:1
AnimationMinimalPerf.default 562 560 1:1
ButtonOverridesMissPerf.default 1423 1416 1:1
CarouselMinimalPerf.default 497 496 1:1
ChatWithPopoverPerf.default 427 428 1:1
CheckboxMinimalPerf.default 2241 2230 1:1
DialogMinimalPerf.default 815 813 1:1
DropdownManyItemsPerf.default 741 742 1:1
HeaderMinimalPerf.default 379 378 1:1
HeaderSlotsPerf.default 841 839 1:1
RosterPerf.default 2348 2346 1:1
ProviderMergeThemesPerf.default 1285 1281 1:1
SliderMinimalPerf.default 1698 1690 1:1
SplitButtonMinimalPerf.default 4698 4709 1:1
StatusMinimalPerf.default 739 738 1:1
TableManyItemsPerf.default 2086 2091 1:1
ChatMinimalPerf.default 775 786 0.99:1
DropdownMinimalPerf.default 2760 2778 0.99:1
GridMinimalPerf.default 352 354 0.99:1
FlexMinimalPerf.default 294 301 0.98:1
ToolbarMinimalPerf.default 996 1014 0.98:1
TreeMinimalPerf.default 863 881 0.98:1
AlertMinimalPerf.default 289 298 0.97:1
AttachmentSlotsPerf.default 1145 1180 0.97:1
DatepickerMinimalPerf.default 6275 6469 0.97:1
ListWith60ListItems.default 670 690 0.97:1
VideoMinimalPerf.default 801 826 0.97:1
AttachmentMinimalPerf.default 164 172 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
78.914 kB
24.06 kB
react-alert
Alert
83.511 kB
20.921 kB
react-avatar
Avatar
48.381 kB
13.696 kB
react-avatar
AvatarGroup
14.95 kB
5.989 kB
react-avatar
AvatarGroupItem
68.349 kB
19.039 kB
react-badge
Badge
22.6 kB
7.205 kB
react-badge
CounterBadge
23.503 kB
7.497 kB
react-badge
PresenceBadge
24.05 kB
7.067 kB
react-button
Button
36.119 kB
9.647 kB
react-button
CompoundButton
43.144 kB
10.86 kB
react-button
MenuButton
38.813 kB
10.551 kB
react-button
SplitButton
46.228 kB
11.933 kB
react-button
ToggleButton
51.888 kB
11.127 kB
react-card
Card - All
67.002 kB
19.261 kB
react-card
Card
62.684 kB
18.177 kB
react-card
CardFooter
8.561 kB
3.601 kB
react-card
CardHeader
9.604 kB
3.94 kB
react-card
CardPreview
8.662 kB
3.656 kB
react-combobox
Combobox (including child components)
74.636 kB
24.186 kB
react-combobox
Dropdown (including child components)
74.236 kB
24.086 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.672 kB
52.359 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-dialog
Dialog (including children components)
81.199 kB
24.196 kB
react-divider
Divider
16.459 kB
5.902 kB
react-image
Image
10.78 kB
4.264 kB
react-input
Input
23.757 kB
7.704 kB
react-label
Label
9.338 kB
3.86 kB
react-link
Link
11.784 kB
4.867 kB
react-menu
Menu (including children components)
116.572 kB
35.778 kB
react-menu
Menu (including selectable components)
119.641 kB
36.297 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.963 kB
31.553 kB
react-portal
Portal
10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.755 kB
5.883 kB
react-radio
Radio
35.56 kB
11.929 kB
react-radio
RadioGroup
14.248 kB
5.7 kB
react-select
Select
20.846 kB
7.346 kB
react-slider
Slider
31.526 kB
10.046 kB
react-spinbutton
SpinButton
44.102 kB
12.425 kB
react-spinner
Spinner
19.977 kB
6.438 kB
react-switch
Switch
32.097 kB
10.27 kB
react-text
Text - Default
11.782 kB
4.605 kB
react-text
Text - Wrappers
15.092 kB
5.044 kB
react-textarea
Textarea
25.013 kB
8.133 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.65 kB
6.444 kB
react-theme
Teams: Light theme
17.486 kB
5.057 kB
react-tooltip
Tooltip
41.502 kB
14.623 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 8e656f25a3867cefcb60c0ae6e156fee3a674277

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1197 1189 5000
Breadcrumb mount 2778 2829 1000
Checkbox mount 2659 2635 5000
CheckboxBase mount 2365 2370 5000
ChoiceGroup mount 4282 4266 5000
ComboBox mount 1196 1163 1000
CommandBar mount 9383 9238 1000
ContextualMenu mount 10606 10400 1000
DefaultButton mount 1363 1364 5000
DetailsRow mount 3368 3349 5000
DetailsRowFast mount 3391 3397 5000
DetailsRowNoStyles mount 3226 3184 5000
Dialog mount 2974 2994 1000
DocumentCardTitle mount 579 574 1000
Dropdown mount 3170 3194 5000
FocusTrapZone mount 1952 1946 5000
FocusZone mount 1909 1905 5000
GroupedList mount 47849 52901 2
GroupedList virtual-rerender 23125 22902 2
GroupedList virtual-rerender-with-unmount 82040 81923 2
GroupedListV2 mount 565 559 2
GroupedListV2 virtual-rerender 531 520 2
GroupedListV2 virtual-rerender-with-unmount 564 568 2
IconButton mount 1799 1790 5000
Label mount 752 759 5000
Layer mount 4112 4135 5000
Link mount 859 859 5000
MenuButton mount 1613 1625 5000
MessageBar mount 2320 2360 5000
Nav mount 3091 3075 1000
OverflowSet mount 1403 1436 5000
Panel mount 2498 2492 1000
Persona mount 1240 1246 1000
Pivot mount 1543 1548 1000
PrimaryButton mount 1503 1493 5000
Rating mount 6985 7005 5000
SearchBox mount 1478 1499 5000
Shimmer mount 2938 2902 5000
Slider mount 2104 2120 5000
SpinButton mount 4287 4318 5000
Spinner mount 834 841 5000
SplitButton mount 2849 2881 5000
Stack mount 898 900 5000
StackWithIntrinsicChildren mount 2248 2239 5000
StackWithTextChildren mount 4944 4915 5000
SwatchColorPicker mount 9503 9577 5000
TagPicker mount 2329 2350 5000
TeachingBubble mount 78762 77904 5000
Text mount 809 826 5000
TextField mount 1545 1541 5000
ThemeProvider mount 1444 1452 5000
ThemeProvider virtual-rerender 1143 1145 5000
ThemeProvider virtual-rerender-with-unmount 2000 1997 5000
Toggle mount 1134 1117 5000
buttonNative mount 524 535 5000

@layershifter layershifter marked this pull request as ready for review September 19, 2022 16:46
@layershifter layershifter enabled auto-merge (squash) September 19, 2022 16:47
auto-merge was automatically disabled September 19, 2022 17:35

Pull request was closed

@layershifter layershifter reopened this Sep 19, 2022
Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work once again 👍

@layershifter layershifter merged commit 070dd0a into microsoft:master Sep 20, 2022
@layershifter layershifter deleted the docs/ep03 branch September 20, 2022 07:50
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 20, 2022
* master:
  feat(cicd): update docsite publish workflow to publish to github pages (microsoft#24846)
  docs(README): add EP03 (microsoft#24854)
  applying package updates
  Set minimum width of 1% for multi stacked horizontal bar chart (microsoft#24835)
  ci: make create-milestone work by adding missing permissions (microsoft#24851)
  fix: `TableCellActions` displays correctly inside `TableHeaderCell` (microsoft#24829)
  ci(github): fix invalid json string in issues.yml (microsoft#24853)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 20, 2022
* master:
  feat(cicd): update docsite publish workflow to publish to github pages (microsoft#24846)
  docs(README): add EP03 (microsoft#24854)
  applying package updates
  Set minimum width of 1% for multi stacked horizontal bar chart (microsoft#24835)
  ci: make create-milestone work by adding missing permissions (microsoft#24851)
  fix: `TableCellActions` displays correctly inside `TableHeaderCell` (microsoft#24829)
  ci(github): fix invalid json string in issues.yml (microsoft#24853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants