Skip to content

ci(github): fix invalid json string in issues.yml #24853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hotell merged 1 commit into from
Sep 19, 2022
Merged

ci(github): fix invalid json string in issues.yml #24853

Hotell merged 1 commit into from
Sep 19, 2022

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 19, 2022 •
edited
Loading

@Hotell Hotell marked this pull request as ready for review September 19, 2022 14:24
@Hotell Hotell requested a review from a team as a code owner September 19, 2022 14:24
@Hotell Hotell added the CI label Sep 19, 2022
@Hotell Hotell enabled auto-merge (squash) September 19, 2022 14:25
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b40674d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 19, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 656d46097c5c85e9866e8b1e3951e2036f1a859a (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1571 1569 5000
Button mount 1154 1174 5000
FluentProvider mount 1894 1900 5000
FluentProviderWithTheme mount 754 756 10
FluentProviderWithTheme virtual-rerender 696 702 10
FluentProviderWithTheme virtual-rerender-with-unmount 744 761 10
MakeStyles mount 2303 2272 50000
SpinButton mount 3005 3005 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 78.914 kB
24.06 kB
react-alert
Alert		 83.511 kB
20.921 kB
react-avatar
Avatar		 48.381 kB
13.696 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.349 kB
19.039 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.503 kB
7.497 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 36.119 kB
9.647 kB
react-button
CompoundButton		 43.144 kB
10.86 kB
react-button
MenuButton		 38.813 kB
10.551 kB
react-button
SplitButton		 46.228 kB
11.933 kB
react-button
ToggleButton		 51.888 kB
11.127 kB
react-card
Card - All		 67.002 kB
19.261 kB
react-card
Card		 62.684 kB
18.177 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 74.636 kB
24.186 kB
react-combobox
Dropdown (including child components)		 74.236 kB
24.086 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 188.672 kB
52.359 kB
react-components
react-components: FluentProvider & webLightTheme		 33.394 kB
11.007 kB
react-dialog
Dialog (including children components)		 81.199 kB
24.196 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.757 kB
7.704 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.784 kB
4.867 kB
react-menu
Menu (including children components)		 116.572 kB
35.778 kB
react-menu
Menu (including selectable components)		 119.641 kB
36.297 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-popover
Popover		 102.963 kB
31.553 kB
react-portal
Portal		 10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.851 kB
1.964 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-provider
FluentProvider		 15.755 kB
5.883 kB
react-radio
Radio		 35.56 kB
11.929 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.526 kB
10.046 kB
react-spinbutton
SpinButton		 44.102 kB
12.425 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 32.097 kB
10.27 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 25.013 kB
8.133 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 41.502 kB
14.623 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 656d46097c5c85e9866e8b1e3951e2036f1a859a

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 138 126 1.1:1
DividerMinimalPerf.default 298 285 1.05:1
ListNestedPerf.default 461 439 1.05:1
CardMinimalPerf.default 439 424 1.04:1
CarouselMinimalPerf.default 384 369 1.04:1
DropdownManyItemsPerf.default 555 534 1.04:1
FormMinimalPerf.default 314 302 1.04:1
SkeletonMinimalPerf.default 286 276 1.04:1
AccordionMinimalPerf.default 120 117 1.03:1
AnimationMinimalPerf.default 446 434 1.03:1
AttachmentMinimalPerf.default 124 120 1.03:1
AvatarMinimalPerf.default 157 153 1.03:1
ChatDuplicateMessagesPerf.default 247 239 1.03:1
ChatMinimalPerf.default 592 574 1.03:1
GridMinimalPerf.default 280 271 1.03:1
HeaderMinimalPerf.default 297 287 1.03:1
LoaderMinimalPerf.default 557 543 1.03:1
PortalMinimalPerf.default 141 137 1.03:1
RadioGroupMinimalPerf.default 361 350 1.03:1
RefMinimalPerf.default 181 176 1.03:1
IconMinimalPerf.default 544 526 1.03:1
TextMinimalPerf.default 280 273 1.03:1
AttachmentSlotsPerf.default 915 900 1.02:1
ChatWithPopoverPerf.default 304 298 1.02:1
ItemLayoutMinimalPerf.default 981 963 1.02:1
LayoutMinimalPerf.default 294 289 1.02:1
MenuMinimalPerf.default 698 685 1.02:1
RosterPerf.default 1780 1750 1.02:1
SegmentMinimalPerf.default 287 281 1.02:1
SplitButtonMinimalPerf.default 3657 3601 1.02:1
TextAreaMinimalPerf.default 386 380 1.02:1
ToolbarMinimalPerf.default 765 750 1.02:1
ButtonOverridesMissPerf.default 1091 1078 1.01:1
CheckboxMinimalPerf.default 1740 1723 1.01:1
DialogMinimalPerf.default 641 634 1.01:1
EmbedMinimalPerf.default 3045 3023 1.01:1
HeaderSlotsPerf.default 629 623 1.01:1
ListMinimalPerf.default 423 418 1.01:1
MenuButtonMinimalPerf.default 1415 1399 1.01:1
ProviderMinimalPerf.default 333 330 1.01:1
StatusMinimalPerf.default 555 551 1.01:1
TreeMinimalPerf.default 666 660 1.01:1
VideoMinimalPerf.default 594 589 1.01:1
DropdownMinimalPerf.default 2244 2239 1:1
FlexMinimalPerf.default 231 232 1:1
LabelMinimalPerf.default 314 315 1:1
PopupMinimalPerf.default 527 525 1:1
SliderMinimalPerf.default 1354 1348 1:1
TableManyItemsPerf.default 1537 1542 1:1
TableMinimalPerf.default 332 331 1:1
CustomToolbarPrototype.default 2240 2234 1:1
BoxMinimalPerf.default 280 283 0.99:1
ButtonMinimalPerf.default 117 118 0.99:1
ButtonSlotsPerf.default 462 468 0.99:1
DatepickerMinimalPerf.default 4797 4864 0.99:1
ImageMinimalPerf.default 317 320 0.99:1
InputMinimalPerf.default 946 952 0.99:1
ProviderMergeThemesPerf.default 1051 1057 0.99:1
TooltipMinimalPerf.default 1924 1952 0.99:1
ListWith60ListItems.default 512 520 0.98:1
ReactionMinimalPerf.default 297 303 0.98:1
AlertMinimalPerf.default 217 224 0.97:1
ListCommonPerf.default 504 521 0.97:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 19, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1174 1180 5000
Breadcrumb mount 2940 2938 1000
Checkbox mount 2657 2640 5000
CheckboxBase mount 2339 2367 5000
ChoiceGroup mount 4377 4411 5000
ComboBox mount 1236 1253 1000
CommandBar mount 9591 9582 1000
ContextualMenu mount 11280 11399 1000
DefaultButton mount 1380 1384 5000
DetailsRow mount 3629 3609 5000
DetailsRowFast mount 3611 3598 5000
DetailsRowNoStyles mount 3408 3507 5000
Dialog mount 3086 3113 1000
DocumentCardTitle mount 593 584 1000
Dropdown mount 3469 3257 5000
FocusTrapZone mount 2024 2010 5000
FocusZone mount 1941 1968 5000
GroupedList mount 52542 59649 2
GroupedList virtual-rerender 25053 25119 2
GroupedList virtual-rerender-with-unmount 93226 93199 2
GroupedListV2 mount 563 561 2
GroupedListV2 virtual-rerender 530 540 2
GroupedListV2 virtual-rerender-with-unmount 553 568 2
IconButton mount 1920 1924 5000
Label mount 752 739 5000
Layer mount 4294 4239 5000
Link mount 835 833 5000
MenuButton mount 1663 1663 5000
MessageBar mount 2263 2336 5000
Nav mount 3248 3264 1000
OverflowSet mount 1368 1360 5000
Panel mount 2551 2525 1000
Persona mount 1266 1274 1000
Pivot mount 1612 1635 1000
PrimaryButton mount 1522 1502 5000
Rating mount 6955 6998 5000
SearchBox mount 1507 1502 5000
Shimmer mount 2856 2875 5000
Slider mount 2089 2050 5000
SpinButton mount 4695 4652 5000
Spinner mount 792 818 5000
SplitButton mount 3057 3072 5000
Stack mount 861 861 5000
StackWithIntrinsicChildren mount 2374 2347 5000
StackWithTextChildren mount 4797 4792 5000
SwatchColorPicker mount 10530 10435 5000
TagPicker mount 2628 2641 5000
TeachingBubble mount 87226 87131 5000
Text mount 799 793 5000
TextField mount 1581 1599 5000
ThemeProvider mount 1535 1525 5000
ThemeProvider virtual-rerender 1083 1072 5000
ThemeProvider virtual-rerender-with-unmount 2156 2171 5000
Toggle mount 1085 1112 5000
buttonNative mount 543 525 5000

@Hotell Hotell merged commit 8e656f2 into microsoft:master Sep 19, 2022
@Hotell Hotell deleted the hotell/ci/fix-issues-gha branch September 20, 2022 10:10
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 20, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/fix/card-codesandbox-examples
39be7fc 
* master:
  feat(cicd): update docsite publish workflow to publish to github pages (microsoft#24846)
  docs(README): add EP03 (microsoft#24854)
  applying package updates
  Set minimum width of 1% for multi stacked horizontal bar chart (microsoft#24835)
  ci: make create-milestone work by adding missing permissions (microsoft#24851)
  fix: `TableCellActions` displays correctly inside `TableHeaderCell` (microsoft#24829)
  ci(github): fix invalid json string in issues.yml (microsoft#24853)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 20, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
7b866ce 
* master:
  feat(cicd): update docsite publish workflow to publish to github pages (microsoft#24846)
  docs(README): add EP03 (microsoft#24854)
  applying package updates
  Set minimum width of 1% for multi stacked horizontal bar chart (microsoft#24835)
  ci: make create-milestone work by adding missing permissions (microsoft#24851)
  fix: `TableCellActions` displays correctly inside `TableHeaderCell` (microsoft#24829)
  ci(github): fix invalid json string in issues.yml (microsoft#24853)
@Hotell Hotell mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tomi-msft tomi-msft

Labels

CI

Projects

None yet

Milestone

September Project Cycle Q1 2022

Development

Successfully merging this pull request may close these issues.

4 participants

@Hotell @fabricteam @ling1726 @tomi-msft