Skip to content

fix: TableCellActions displays correctly inside TableHeaderCell #24829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ling1726 merged 3 commits into from
Sep 19, 2022
Merged

fix: TableCellActions displays correctly inside TableHeaderCell #24829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b2f5dd
fix: `TableCellActions` displays correctly inside `TableHeaderCell`
ling1726 Sep 16, 2022
a606985
changeifle
ling1726 Sep 16, 2022
9ef7f86
merge master
ling1726 Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions apps/vr-tests-react-components/src/stories/Table.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,46 @@ storiesOf('Table - cell actions', module)
</Table>
),
{ includeDarkMode: true, includeHighContrast: true, includeRtl: true },
);
)
.addStory('in header cell', () => (
<Table>
<TableHeader>
<TableRow>
{columns.map(column => (
<TableHeaderCell key={column.columnKey}>{column.label}</TableHeaderCell>
))}
</TableRow>
</TableHeader>
<TableBody>
{items.map(item => (
<TableRow key={item.file.label} className="row">
<TableHeaderCell>
<TableCellLayout media={item.file.icon}>
{item.file.label}
<TableCellActions>
<Button icon={<EditRegular />} appearance="subtle" />
<Button icon={<MoreHorizontalRegular />} appearance="subtle" />
</TableCellActions>
</TableCellLayout>
</TableHeaderCell>
<TableCell>
<TableCellLayout
media={
<Avatar name={item.author.label} badge={{ status: item.author.status as PresenceBadgeStatus }} />
}
>
{item.author.label}
</TableCellLayout>
</TableCell>
<TableCell>{item.lastUpdated.label}</TableCell>
<TableCell>
<TableCellLayout media={item.lastUpdate.icon}>{item.lastUpdate.label}</TableCellLayout>
</TableCell>
</TableRow>
))}
</TableBody>
</Table>
));

storiesOf('Table', module)
.addStory(
Expand Down Expand Up @@ -290,7 +329,7 @@ storiesOf('Table', module)
{items.map(item => (
<TableRow key={item.file.label}>
<TableCell>
<TableCellLayout media={item.file.icon} description="Your organization">
<TableCellLayout media={item.file.icon} description="Your organization" appearance="primary">
{item.file.label}
</TableCellLayout>
</TableCell>
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-react-table-bc9b996e-76bf-44d5-b7a4-0f716a7a6276.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: `TableCellActions` displays correctly inside `TableHeaderCell`",
"packageName": "@fluentui/react-table",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions ...s/react-components/react-table/src/components/TableHeaderCell/useTableHeaderCellStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const useStyles = makeStyles({
textAlign: 'unset',
},
button: {
position: 'relative',
width: '100%',
display: 'flex',
flexGrow: 1,
Expand Down