Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix current eslint warnings #2745

Closed
stevengum opened this issue Aug 25, 2020 · 1 comment
Closed

Fix current eslint warnings #2745

stevengum opened this issue Aug 25, 2020 · 1 comment
Assignees
@JuanAr
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P2 Nice to have Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete
Milestone
R16

Comments

@stevengum
Copy link
Member

Per discussion with @mrivera-ms.
@stevengum stevengum added triaged Reviewed by the Triage Team Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. R11 labels Aug 25, 2020
@stevengum stevengum added this to the R11 milestone Aug 25, 2020
@denscollo denscollo mentioned this issue Sep 1, 2020
Closed
@gabog gabog removed the R11 label Sep 2, 2020
@joshgummersall joshgummersall added the backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. label Oct 14, 2020
@joshgummersall joshgummersall removed this from the R11 milestone Oct 14, 2020
@joshgummersall joshgummersall added P2 Nice to have Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete labels Nov 4, 2020
@joshgummersall joshgummersall added this to the R12 milestone Nov 4, 2020
@joshgummersall joshgummersall removed this from the R12 milestone Jan 27, 2021
@joshgummersall joshgummersall mentioned this issue Mar 2, 2021
Merged
@joshgummersall joshgummersall added this to the R14 milestone Apr 6, 2021
@joshgummersall joshgummersall removed the triaged Reviewed by the Triage Team label Apr 6, 2021
@joshgummersall joshgummersall mentioned this issue Apr 9, 2021
Closed
@joshgummersall joshgummersall mentioned this issue Apr 19, 2021
Closed
@joshgummersall joshgummersall modified the milestones: R14, R15 Jun 14, 2021
@mrivera-ms mrivera-ms assigned JuanAr and unassigned joshgummersall Dec 8, 2021
@mrivera-ms mrivera-ms modified the milestones: R15, R16 Dec 8, 2021
This was referenced Dec 30, 2021
Merged
Merged
This was referenced Dec 30, 2021
Merged
Merged
This was referenced Jan 20, 2022
Merged
Merged
Merged
Merged
Merged
mrivera-ms added a commit that referenced this issue Jan 31, 2022
@ceciliaavila @sw-joelmut @mrivera-ms
fix: [#2745] Fix current eslint warnings - adaptive-expressions libra…
5efa0a8 
…ry (1/2) (#4034)

* Fix eslint issues adaptive-expressions (1/2)

* Update project's API signature .md

* Fix test:compat

Co-authored-by: Joel Mut <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
mrivera-ms added a commit that referenced this issue Jan 31, 2022
@ceciliaavila @sw-joelmut @mrivera-ms
fix: [#2745] Fix current eslint warnings - botbuilder-azure library (#…
f04e8d1 
…4036)

* Apply eslint auto-fix

* Fix eslint issues in botbuilder-azure

* Add lodash to package.json

* Fix comment and import.

Co-authored-by: Joel Mut <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
mrivera-ms added a commit that referenced this issue Feb 1, 2022
@sw-joelmut @NahuelPerales @mrivera-ms
fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptiv…
768e63b 
…e library - misc (#4068)

* Fix eslint warnings

* Fix pr comments

Co-authored-by: Nahuel Perales <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
mrivera-ms added a commit that referenced this issue Feb 1, 2022
@ceciliaavila @sw-joelmut @mrivera-ms
fix: [#2745] Fix current eslint warnings - adaptive-expressions libra…
ba638f1 
…ry (2/2) (#4035)

* Fix eslint issues adaptive-expressions (2/2)

* Fix test:compat

Co-authored-by: Joel Mut <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
mrivera-ms added a commit that referenced this issue Feb 1, 2022
@sw-joelmut @NahuelPerales @mrivera-ms
fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptiv…
4a11f5d 
…e library - recognizers (#4067)

* Fix eslint warnings - recognizers

* Fix api.md

Co-authored-by: Nahuel Perales <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
mrivera-ms added a commit that referenced this issue Feb 1, 2022
@sw-joelmut @NahuelPerales @mrivera-ms
fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptiv…
aee6ae0 
…e library - tests (#4065)

* Fix eslint erros - tests

* Fix pr comments.

* Fix Pr comments

Co-authored-by: Nahuel Perales <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
mrivera-ms added a commit that referenced this issue Feb 1, 2022
@ceciliaavila @NahuelPerales
@sw-joelmut @mrivera-ms
fix: [#2745] Fix current eslint warnings - botbuilder library (#4037)
d55b5b9 
* Auto fixes from lint

* Fix eslint errors

Co-authored-by: Nahuel Perales <[email protected]>
Co-authored-by: Joel Mut <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
mrivera-ms pushed a commit that referenced this issue Feb 3, 2022
@sw-joelmut @NahuelPerales
fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptiv…
fdd51fd 
…e library - src & conditions (#4069)

* Fix eslint warnings - src & conditions

* Revert dialogContext

* Apply feedback for botbuilder-dialogs-adaptive eslint jsdoc

* Fix test:compat for botbuilder-dialogs-adaptive

Co-authored-by: Nahuel Perales <[email protected]>
@mrivera-ms
Copy link
Contributor

Closing as 'Completed'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P2 Nice to have Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

[ESLint] Fix auto fixable warnings southworks/botbuilder-js
5 participants
@JuanAr @joshgummersall @gabog @stevengum @mrivera-ms