Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptive library - actions #4066

Merged

Conversation

sw-joelmut
Copy link
Collaborator

Adresses #2745
#minor

Description

When reviewing the botbuilder-js project, it was found that eslint is showing several warnings for the botbuilder-dialogs-adaptive library.

Specific Changes

  • Replaced strings quotes with the correct one depending on the case
  • Replaced hasOwnProperty with Object.prototype.hasOwnProperty.call
  • Adjusted formatting
  • Limited importing scopes
  • Added missing jsdocs documentation for parameters and returns for functions
  • Removed unused variables
  • Added _ (underscore) to unused parameters that couldn't be removed to omit them in the eslint validation
  • Omitted validation for unknow/any/object variables as they will be treated in a different task

Testing

Eslint with no warnings and tests passed
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner January 20, 2022 19:43
@coveralls
Copy link

coveralls commented Jan 20, 2022

Pull Request Test Coverage Report for Build 1729054614

  • 7 of 12 (58.33%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.545%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/actions/editActions.ts 1 2 50.0%
libraries/botbuilder-dialogs-adaptive/src/actions/forEachPage.ts 0 1 0.0%
libraries/botbuilder-dialogs-adaptive/src/actions/gotoAction.ts 0 1 0.0%
libraries/botbuilder-dialogs-adaptive/src/actions/sendActivity.ts 0 1 0.0%
libraries/botbuilder-dialogs-adaptive/src/actions/updateActivity.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/actions/forEachPage.ts 1 72.29%
Totals Coverage Status
Change from base Build 1725520852: -0.003%
Covered Lines: 19667
Relevant Lines: 22035

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit b1e65fa into main Feb 1, 2022
@mrivera-ms mrivera-ms deleted the southworks/fix/eslint/botbuilder-dialogs-adaptive/actions branch February 1, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants