Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptive library - misc #4068

Merged
merged 4 commits into from
Feb 1, 2022
Merged

fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptive library - misc #4068

merged 4 commits into from
Feb 1, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Adresses #2745
#minor

Description

When reviewing the botbuilder-js project, it was found that eslint is showing several warnings for the botbuilder-dialogs-adaptive library.

Specific Changes

  • Replaced strings quotes with the correct one depending on the case
  • Replaced hasOwnProperty with Object.prototype.hasOwnProperty.call
  • Adjusted formatting
  • Limited importing scopes
  • Added missing jsdocs documentation for parameters and returns for functions
  • Removed unused variables

Testing

Eslint with no warnings and tests passed
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner January 20, 2022 19:48
@coveralls
Copy link

coveralls commented Jan 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1775460004

  • 5 of 6 (83.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 84.546%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/input/oauthInput.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 1775406937: -0.04%
Covered Lines: 19668
Relevant Lines: 22036
💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 768e63b into main Feb 1, 2022
@mrivera-ms mrivera-ms deleted the southworks/fix/eslint/botbuilder-dialogs-adaptive/misc branch February 1, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrivera-ms mrivera-ms mrivera-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sw-joelmut @coveralls @mrivera-ms @NahuelPerales