Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint settings, lint errors #3348

Merged
merged 9 commits into from
Mar 5, 2021
Merged

fix: eslint settings, lint errors #3348

merged 9 commits into from
Mar 5, 2021

Conversation

joshgummersall
Copy link
Contributor

Linked with #2840 and #2745 but doesn't quite close out either.

@joshgummersall joshgummersall requested review from stevengum and a team as code owners March 2, 2021 00:27
@joshgummersall joshgummersall requested a review from Stevenic March 2, 2021 00:27
@coveralls
Copy link

coveralls commented Mar 2, 2021

Pull Request Test Coverage Report for Build 625614696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 60 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 84.887%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-azure/src/cosmosDbKeyEscape.ts 2 90.48%
libraries/botbuilder-testing/src/dialogTestClient.ts 2 91.89%
libraries/botbuilder-testing/src/dialogTestLogger.ts 3 88.57%
libraries/botbuilder-azure/src/blobStorage.ts 7 88.03%
libraries/botbuilder-azure/src/cosmosDbStorage.ts 10 83.7%
libraries/botbuilder-azure/src/azureBlobTranscriptStore.ts 17 79.01%
libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts 19 61.65%
Totals Coverage Status
Change from base Build 625614124: 0.02%
Covered Lines: 18646
Relevant Lines: 20923

💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/eslint-fixup branch 2 times, most recently from 6511501 to ca9a0d4 Compare March 2, 2021 17:20
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joshgummersall joshgummersall merged commit 866b662 into main Mar 5, 2021
@joshgummersall joshgummersall deleted the jpg/eslint-fixup branch March 5, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants