fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptive library - src & conditions #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1729055735
💛 - Coveralls |
…ptive/src&conditions
mrivera-ms
suggested changes
Feb 2, 2022
There was a problem hiding this comment.
@sw-joelmut, I don't see a lint rule recommending the change to dependencies. Please see my question below.
mrivera-ms
approved these changes
Feb 3, 2022
mrivera-ms
deleted the
southworks/fix/eslint/botbuilder-dialogs-adaptive/src&conditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #2745
#minor
Description
When reviewing the botbuilder-js project, it was found that eslint is showing several warnings for the botbuilder-dialogs-adaptive library.
Specific Changes
Testing
Eslint with no warnings and tests passed
