Intl 2021 Updates #45647
Merged
Intl 2021 Updates #45647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snext.intl around)
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot run dt |
|
I've double checked all the es5 |
|
@longlho any chance I could get your eyes over this? (and sorry it's taken a while!) |
|
Yup will take a look asap |
sandersn
requested changes
Sep 3, 2021
src/lib/es2020.intl.d.ts
Outdated
Comment on lines
220
to
223
| hourCycle?: "h11" | "h12" | "h23" | "h24" | undefined; | ||
| } | ||
|
|
||
| interface DateTimeFormatOptions { |
There was a problem hiding this comment.
Probably should merge these two DateTimeFormatOptions declarations
longlho
suggested changes
Sep 4, 2021
Co-authored-by: Nathan Shively-Sanders <[email protected]>
|
OK, thanks for the feedback everyone - assuming this is green I will merge weds and start closing all the linked PRs |
longlho
approved these changes
Sep 6, 2021
|
Editorial suggestions but overall lgtm |
|
@oceandrama I think that can be a follow-up diff. ES2021 in this diff is still missing a bunch of normative changes |
sandersn
approved these changes
Sep 7, 2021
|
Thanks folks |
This was referenced Sep 8, 2021
Closed
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #45646 - no breaking changes in here though
This is quite a few PRs + issues combined, rebased etc:
I've tried to reduce the overall character count for some of the docs (e.g. removing some JSDocs which are redundant because the type system will tell you the types of things) and removed all the specs links, I can't imagine your average
IntlAPI consumer wanting to read the spec (over MDN).Also adds some fresh docs about how lib files work to the README, covering how
Intlis a wee bit special in comparison to some of the other cases we have in the.d.tsfiles.