feat(46907): Add Intl.ListFormat type declarations
#47254
Conversation
|
|
predetermined
changed the title
ListFormat type declarationsIntl.ListFormat type declarations
…n, link to Array MDN page
V8 has supported `Intl.ListFormat` since version 7.2, but TypeScript doesn't have typings for it yet. This PR manually adds those typings, copying them from microsoft/TypeScript#47254. Fixes denoland#13199.
V8 has supported `Intl.ListFormat` since version 7.2, but TypeScript doesn't have typings for it yet. This PR manually adds those typings, copying them from microsoft/TypeScript#47254.
| * | ||
| * [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/ListFormat/ListFormat#parameters). | ||
| */ | ||
| type ListFormatLocaleMatcher = "lookup" | "best fit"; |
There was a problem hiding this comment.
One final comment: I'm noticing that none of the options above have defined types (or make use of the new ones); is that intentional? Is it more "correct" to not have defined types for any of them? Or do they need to be fixed to have defined types too?
(I'm also noticing that there are some silly things above like "best fit" | "best fit".)
There was a problem hiding this comment.
I'd rather not touch it in this PR, but create a follow-up PR in the next days instead.
- Create named types for the options above, remove duplicate
"best fit" - Investigate if
ResolvedDateTimeFormatOptionsis even correct (at a first glance, it seems wrong, but might be to match some unique browser behavior?)
Feel free to disagree, I can also tackle them here
There was a problem hiding this comment.
I'm sure a second PR is fine, I just wasn't sure (I have no major knowledge of these types) whether or not it's normal to have top level declared type names or not.
Fixes #46907