Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intl.DisplayNames.prototype.of should return string | undefined #47143

Closed
tao-cumplido opened this issue Dec 14, 2021 · 1 comment · Fixed by #47157
Closed

Intl.DisplayNames.prototype.of should return string | undefined #47143

tao-cumplido opened this issue Dec 14, 2021 · 1 comment · Fixed by #47157
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Effort: Casual Good issue if you're already used to contributing to the codebase. Harder than "good first issue". Fix Available A PR has been opened for this issue
Milestone
TypeScript 4.6.0

Comments

@tao-cumplido
Copy link
Contributor

Bug Report

🔎 Search Terms

  • intl
  • displaynames

🕗 Version & Regression Information

The type information didn't exist before 4.5
PR by @orta #45647

🙁 Actual behavior

Intl.DisplayNames.prototype.of returns string in lib.es2020.intl.d.ts

🙂 Expected behavior

It should return string | undefined
See spec https://tc39.es/ecma402/#sec-Intl.DisplayNames.prototype.of
@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Dec 14, 2021
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 4.6.0 milestone Dec 14, 2021
@orta
Copy link
Contributor

orta commented Dec 15, 2021

Yep, agree, open to PRs for this 👍🏻

@orta orta added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Effort: Casual Good issue if you're already used to contributing to the codebase. Harder than "good first issue". and removed Needs Investigation This issue needs a team member to investigate its status. labels Dec 15, 2021
@tao-cumplido tao-cumplido mentioned this issue Dec 15, 2021
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Dec 15, 2021
@gfyoung gfyoung mentioned this issue Dec 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Effort: Casual Good issue if you're already used to contributing to the codebase. Harder than "good first issue". Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 4.6.0
Development

Successfully merging a pull request may close this issue.

update es2020.intl DisplayNames#of tao-cumplido/TypeScript
4 participants
@orta @tao-cumplido @RyanCavanaugh @typescript-bot