Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es2020.intl.d.ts is inaccurate #42944

Closed
longlho opened this issue Feb 24, 2021 · 1 comment
Closed

es2020.intl.d.ts is inaccurate #42944

longlho opened this issue Feb 24, 2021 · 1 comment
Labels
Bug A bug in TypeScript Help Wanted You can do this

Comments

@longlho
Copy link
Contributor

longlho commented Feb 24, 2021 •
edited
Loading

lib Update Request

  • fractionalSecondDigits, dateStyle, timeStyle, dayPeriod are in ES2021 draft, not ES2020.
  • NumberFormatOptions should have the list of sanctioned unit to prevent RangeError.

Reference upstream issue: formatjs/formatjs#2616

Configuration Check

Missing / Incorrect Definition

lib/es202.intl.d.ts

Sample Code

Documentation Link

https://402.ecma-international.org/7.0/
@longlho longlho mentioned this issue Feb 24, 2021
Closed
@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this labels Feb 24, 2021
@longlho longlho changed the title fractionalSecondDigits should not be in es2020.intl.d.ts es2020.intl.d.ts is inaccurate Feb 25, 2021
orta added a commit to orta/TypeScript that referenced this issue Aug 30, 2021
@orta
Remove attributes added in es2021 from es2020 - re: microsoft#42944
df508a0
@orta orta mentioned this issue Aug 30, 2021
Merged
orta pushed a commit that referenced this issue Sep 8, 2021
@sandersn
Intl 2021 Updates (#45647)
07fd7bc 
* Import of Intl.Locale from #39664

* Handle updating es2020.intl and add es2021 for new DateTimeFormatOptions options - re: #39664

* Extends DateTimeFormatOptions for new Intl APIs - re: #45420

* Handle migrating Intl.NumberFormat.formatToParts to es2018 (keeping esnext.intl around)

* Adds Intl.DisplayNames to es2020 - re: #44022

* Remove attributes added in es2021 from es2020 - re: #42944

* Add a reference to es2021 in the command line parser

* Adds some docs about the lib files

* Baselines

* Allow undefined in Intl inputs to allow for ergonomic usage of exactOptionalPropertyTypes - see #45652

* Adds some tests covering the APIs

* Apply suggestions from code review

Co-authored-by: Nathan Shively-Sanders <[email protected]>

* Handle PR feedback

* More review improvements

Co-authored-by: Nathan Shively-Sanders <[email protected]>
@orta
Copy link
Contributor

orta commented Sep 8, 2021

In with #45647 👍🏻

@orta orta closed this as completed Sep 8, 2021
@ilogico ilogico mentioned this issue Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: revamp es2020.intl.d.ts longlho/TypeScript
3 participants
@orta @longlho @RyanCavanaugh