Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intl.locale types #39664

Closed
wants to merge 4 commits into from
Closed

Add Intl.locale types #39664

wants to merge 4 commits into from

Conversation

Dangoo
Copy link
Contributor

@Dangoo Dangoo commented Jul 19, 2020

Fixes #37326

I'm aware there's currently no entry in the Backlog for it, but a PR makes discussion easier.

Thanks for @boenrobot for bringing the issue up and @longlho for giving feedback on this!

@longlho
Copy link
Contributor

longlho commented Jul 19, 2020

Thanks a lot for the changes @Dangoo. 1 last thing I'd say is to rename LDMLHourCycleKey & LDMLCollationCaseFirst since they're not LDML concepts (LDML refers to UTS35 Unicode Locale Data Markup Language) but rather just ECMA402.

@Dangoo Dangoo marked this pull request as ready for review July 21, 2020 15:14
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 21, 2020
@hbroer
Copy link

hbroer commented Nov 21, 2020

Hi, what is the current state for this PR and when will it be merged? Can we do something? @orta

@Dangoo
Copy link
Contributor Author

Dangoo commented Apr 22, 2021

Hey, are there any blockers stopping you on bringing this in, or is there something we can do to support review/merging? @orta @RyanCavanaugh

@szuend
Copy link

szuend commented May 11, 2021

Hey, we would like to use this PR in our project until it is merged. Can you confirm that the substance of this PR is available under TypeScript's Apache 2 license?

@JustJenFelice
Copy link

What is the status of this PR?

This request for support for Intl spec doesn't seem like it would be controversial, yet the delay in resolving the lack of support is inexplicable. This PR was approved October 2020.

orta added a commit to orta/TypeScript that referenced this pull request Aug 30, 2021
@orta
Import of Intl.Locale from microsoft#39664
ad15e54
orta added a commit to orta/TypeScript that referenced this pull request Aug 30, 2021
@orta
Handle updating es2020.intl and add es2021 for new DateTimeFormatOpti…
872894d 
…ons options - re: microsoft#39664
@orta orta mentioned this pull request Aug 30, 2021
Merged
orta pushed a commit that referenced this pull request Sep 8, 2021
@sandersn
Intl 2021 Updates (#45647)
07fd7bc 
* Import of Intl.Locale from #39664

* Handle updating es2020.intl and add es2021 for new DateTimeFormatOptions options - re: #39664

* Extends DateTimeFormatOptions for new Intl APIs - re: #45420

* Handle migrating Intl.NumberFormat.formatToParts to es2018 (keeping esnext.intl around)

* Adds Intl.DisplayNames to es2020 - re: #44022

* Remove attributes added in es2021 from es2020 - re: #42944

* Add a reference to es2021 in the command line parser

* Adds some docs about the lib files

* Baselines

* Allow undefined in Intl inputs to allow for ergonomic usage of exactOptionalPropertyTypes - see #45652

* Adds some tests covering the APIs

* Apply suggestions from code review

Co-authored-by: Nathan Shively-Sanders <[email protected]>

* Handle PR feedback

* More review improvements

Co-authored-by: Nathan Shively-Sanders <[email protected]>
@orta
Copy link
Contributor

orta commented Sep 8, 2021

Thanks @Dangoo - I've taken these changes and integrated them into #45647 which I've just merged into main for 4.5 👍🏻

@orta orta closed this Sep 8, 2021
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #37326. If you can get it accepted, this PR will have a better chance of being reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbroer hbroer hbroer approved these changes

Assignees

@orta orta

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Intl.Locale to es2020 lib
7 participants
@Dangoo @longlho @hbroer @szuend @JustJenFelice @orta @typescript-bot