Adjust MA0007 trailing comma behavior for collection expressions#1127
Merged
Adjust MA0007 trailing comma behavior for collection expressions#1127
Conversation
Allow omitting the trailing comma in collection expressions when the last element is directly followed by ] on the same line, while still requiring a comma when ] is on a following line. Update MA0007 documentation and extend CommaAnalyzerTests with same-line and next-line closing bracket scenarios, including trailing comment coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 5, 2026
Closed
Merged
Merged
This was referenced May 6, 2026
IhateTrains
added a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
May 6, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.61 to 3.0.70. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.70 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.70> ## What's Changed * Update diagnostic helpers and tests for flexibility and clarity by @meziantou in meziantou/Meziantou.Analyzer#1131 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.69...3.0.70 ## 3.0.69 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.69> ## What's Changed * Broaden MA0042/MA0045 SQLite special-case exclusions by @meziantou in meziantou/Meziantou.Analyzer#1130 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.68...3.0.69 ## 3.0.68 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.68> ## What's Changed * Skip SqliteConnection.Open in MA0042 and MA0045 by @meziantou in meziantou/Meziantou.Analyzer#1129 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.67...3.0.68 ## 3.0.67 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.67> ## What's Changed * Add configurable SQLite special cases for MA0042 and MA0045 by @meziantou in meziantou/Meziantou.Analyzer#1128 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.66...3.0.67 ## 3.0.66 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.66> ## What's Changed * Adjust MA0007 trailing comma behavior for collection expressions by @meziantou in meziantou/Meziantou.Analyzer#1127 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.65...3.0.66 ## 3.0.65 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.65> ## What's Changed * Fix MA0004 code fix crash in nested await using declarations by @meziantou in meziantou/Meziantou.Analyzer#1125 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.64...3.0.65 ## 3.0.64 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.64> ## What's Changed * MA0109: Skip diagnostic for program entry point `Main(string[] args)` by @Copilot in meziantou/Meziantou.Analyzer#1123 * MA0042: add DbCommand await-using parity with DbConnection by @meziantou in meziantou/Meziantou.Analyzer#1124 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.63...3.0.64 ## 3.0.63 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.63> ## What's Changed * MA0042: check if DisposeAsync is declared directly when runtime type is known by @meziantou in meziantou/Meziantou.Analyzer#1118 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.62...3.0.63 ## 3.0.62 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.62> ## What's Changed * Fix MA0042 comment placement for await using by @meziantou in meziantou/Meziantou.Analyzer#1120 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.61...3.0.62 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.61...3.0.70). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced May 6, 2026
Open
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0007 currently reports on multiline collection expressions even when the last element is directly followed by the closing bracket on the same line. This produces noise for common spread-element formatting.
This change updates MA0007 so collection expressions only require a trailing comma when the closing
]is on a later line than the last element. If the last element and]are on the same line, no diagnostic is reported.It also adds focused C# 12 tests for:
Finally, the MA0007 rule documentation is updated to describe the new default behavior for collection expressions.
Fix #1126