MA0042: add DbCommand await-using parity with DbConnection#1124
Merged
MA0042: add DbCommand await-using parity with DbConnection#1124
Conversation
Add DbCommand parity with DbConnection for direct object creation in await-using diagnostics, and update tests and MA0042 documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 5, 2026
Closed
Merged
Merged
This was referenced May 8, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0042 already avoids reporting
using->await usingfor directly instantiatedDbConnectionsubclasses when they do not overrideDisposeAsync, because the base implementation is synchronous. This change applies the same behavior toDbCommandto avoid unnecessary diagnostics in equivalent cases.What changed
DoNotUseBlockingCallInAsyncContextAnalyzerto resolveSystem.Data.Common.DbCommandand apply the same direct-newsubclass check used forDbConnection.DbCommandinstances created withnew, diagnostics are now reported only whenDisposeAsyncis declared in the subclass chain (excludingDbCommanditself).DbCommandinstances, which still report because runtime types may overrideDisposeAsync.newwith no override (no diagnostic)newwith override (diagnostic)docs/Rules/MA0042.mdto document the newDbCommandbehavior alongsideStreamandDbConnection.Validation
DoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContextTestson default Roslyn./p:RoslynVersion=roslyn4.2.dotnet run --project src/DocumentationGeneratoruntil stable (no further markdown updates).Contributes to #1121