Add configurable SQLite special cases for MA0042 and MA0045#1128
Merged
Add configurable SQLite special cases for MA0042 and MA0045#1128
Conversation
Add opt-out config (MA0042.enable_sqlite_special_cases), extend SQLite method coverage, update docs, and add regression tests for MA0042/MA0045 including option-disabled behavior and API contract validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 5, 2026
Closed
Merged
Merged
This was referenced May 6, 2026
Closed
This was referenced May 7, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite async recommendations in MA0042/MA0045 were previously hardcoded for
SqliteConnection.CreateCommand(). Because SQLite types are not sealed and derived implementations may provide meaningful async behavior, this change makes SQLite exceptions configurable and extends the coverage to the commonly reported command execution methods.What changed
MA0042.enable_sqlite_special_cases(default:true).SqliteConnection.CreateCommand()SqliteCommand.ExecuteNonQuery()SqliteCommand.ExecuteScalar()SqliteCommand.ExecuteReader()MA0042.enable_sqlite_special_cases = false.SqliteConnection.CreateCommand()returnsSqliteCommand.Notable implementation detail
Invocation-level method caching in
DoNotUseBlockingCallInAsyncContextAnalyzerwas adjusted so SQLite-special-case methods are not cached as permanently "no async equivalent". This avoids stale behavior when the new configuration is toggled.Validation
DocumentationGenerator.Meziantou.Analyzer.slnx).Fix #1121