Skip SqliteConnection.Open in MA0042 and MA0045#1129
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 5, 2026
Closed
Merged
Merged
Merged
Merged
This was referenced May 7, 2026
This was referenced May 7, 2026
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite in Microsoft.Data.Sqlite has documented async limitations, and
SqliteConnection.Open()is effectively a synchronous API. Reporting MA0042/MA0045 for this call when SQLite special-cases are enabled produces noise.This updates the shared blocking-call analyzer logic to treat
SqliteConnection.Open()as a SQLite special-case alongside existing SQLite exemptions. The behavior is still configurable: whenMA0042.enable_sqlite_special_cases = false, diagnostics are reported as before.I also added regression tests for both MA0042 (async context) and MA0045 (non-async context) to cover enabled and disabled flag behavior, and updated the MA0042/MA0045 rule docs to list
SqliteConnection.Open()in the SQLite special-case APIs.Fix #1121 (comment)