Broaden MA0042/MA0045 SQLite special-case exclusions#1130
Merged
Conversation
Treat all method calls on SqliteConnection, SqliteCommand, and SqliteDataReader as SQLite special cases for MA0042/MA0045 by default. Update tests and rule docs to reflect the broader type-based behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 6, 2026
Merged
Merged
Merged
Merged
This was referenced May 6, 2026
Closed
This was referenced May 7, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recent SQLite handling for MA0042/MA0045 only excluded a small set of specific methods, which still left other synchronous SQLite calls flagged even though Microsoft.Data.Sqlite async APIs are documented with limitations.
What changed
SqliteConnection,SqliteCommand, andSqliteDataReaderwhen SQLite special-cases are enabled.using/await usinganalysis path.SqliteDataReadercoverage, with option-enabled and option-disabled cases.Notes for reviewers
The config switch (
MA0042.enable_sqlite_special_cases, shared with MA0045) is unchanged. This PR only broadens what is considered a SQLite special-case when that option is enabled.