-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert /learn folder to Markdown (es) #7431
Conversation
Hi! @queengooborg thank you so much for your PRs. I assume that it is by the automate conversor for html to md, as we said on the matrix channel at least in |
Ah I see, thanks for the head's up about the new frontmatter key! Yes, these changes are almost all automated with the conversion script (specifically, my fork of it), with additional manual tweaks to convert HTML the script doesn't know how to handle. |
Thanks to you! I'm going to start reviewing and adding that info to all your modified files in the last PRs |
Hi! @queengooborg I added the attribute htmlDate to identify the outdated content, also we usually avoid doing big PRs to avoid and control this kind of risks #7436 Did you check if that error did't happend in this or others PRs? if yes, how? Thank you so much for your time |
Thank you! I'll tweak the Markdown conversion script to automatically add this property in as well. 👍
Makes sense -- over on the English content side, and for BCD (my main project), larger PRs are preferred when they're scripted changes, so that's what I'm accustomed to doing. I'm hoping that by the time I'm finished with the Spanish locale, the script will handle everything and no manual review will be required any longer!
I did -- I checked out a commit earlier to my prior PRs' merge commits and searched for "Quick_links" in all the affected files. Luckily, the Glossary folder was the only one that had those sections in them, I'm guessing that the macros handle most of the sidebar stuff.
Of course, always happy to help out wherever I can! |
In regards to the Also, is there an issue or discussion about this frontmatter key somewhere here or on |
Sorry I'll change it, thank you We talk about this key in the matrix chat with @schalkneethling only for the
https://pad.mozilla.org/p/mdn-markdown-hack-day About larger PRs, you can find in various sites that the recomendation is small PRs and emphasizes in always do a manual review, here's an example
https://github.com/mdn/content/blob/main/README.md#pull-request-etiquette Thank you so much again EDIT: for future info the bot fails due the amount of files https://github.com/mdn/translated-content/runs/7735327304?check_suite_focus=true |
That makes sense -- I think that larger PRs have been preferred for me because I'm an MDN and OWD contractor (and have write access to the repos accordingly), so I'm a much more trustworthy user -- I definitely wouldn't want some random user submitting a larger PR, even if it did mostly come from a (trustworthy) script. ;P I'm happy to split this PR up into smaller chunks to make reviews easier, by the way!
Forgive me for asking about matters that have already been discussed and whatnot, I'm just going by what I have been told to do in similar scenarios for other parts of MDN (I'm fairly new to the MDN localization community)! |
Everything its ok, we are almost new too, it's only that spanish has a lot of work and doing it well and step by step help us to offer better content to the readers and this is only for the es-team, I don't know how each localization team works, but each team are for help to everyone :) I'll just do some reviews and add the key Thank you! |
Hi! @queengooborg I hope you're having a great day, I'm still reviewing the files and notice this piece of code deleted from a file and just want to know how's the code to remove it to ensure not repeat errors like #7436. Note: I think the deletion of that code is OK, I just want to guarantee that other files don't have an error due to the automation. Also notice that there's an error formating "Notes" with more than one line Code:
|
About all the mentioned above we think the best it's going to be close this kind of big PRs due to the large list of files and lack of reviewing before making it. I reviewed some random files and notice various inconsistencies and it's going to be so hard to our team to review the integrity of the entire PR. Thank you so much for all your time and hope in future PRs with mayor changes we can have a manual reviews before doing the PR |
The section that was removed was basically original wiki information -- since that is all in the By the way, I spoke to Schalk about the |
Of course, I'm not saying that we shouldn't add something to make it clear how outdated a converted HTML document is -- but let's make sure that everyone, including other localization teams and MDN engineers, are all on the same page and in agreement about how to do it first! Would you like to open a discussion in the mdn-community about the frontmatter key to get planning going? Happy to open it as well! |
Thank you so much, I opened it, hope to get that to start converting es files into md and keep the work of the es team under control |
I've also reopened this PR and marked it as a draft instead (I didn't see it was closed until just now) -- I'm happy to split this off into smaller bits to make it easier to review, but let's leave this open as a breakdown PR to show what is affected and better represent my intent of what files I'm handling, so that others don't perform duplicate work. :) |
if you can split this it's going to be great! Also as I notice the script don't put correctly the "Note:" format when have more than one line (I don't know if have the same error on other kind of notes) and it's going to be helpfull to have a mention of deleted sections in case that apply. Thank you so much and sorry about the inconvenients, I'm very glad to talk and proceed with this |
This PR converts the
/learn
folder to Markdown for the Spanish locale, using my fork of themdn-markdown
repository.Disclaimer: I am an English content writer rather than a localization expert, and as such I strive to keep my changes purely editorial.