IndexedDB: Clean up code after EventCacheStore-MediaStore split

[mgoldenberg]

Background

This pull request is part of a series of pull requests to add a full IndexedDB implementation of the EventCacheStore (see #4617, #4996, #5090, #5138, #5226, #5274, #5343, #5384, #5406, #5414, #5497, #5506, #5540, #5574, #5603). This particular pull request cleans up duplicated code and various warnings introduced during the EventCacheStore-MediaStore split (see #5568).

Changes

Deduplication

The primary changes are de-duplicating the transaction and serializer modules in event_cache_store and media_store. This additionally required some renaming of existing types in order to make sure that there were no clashes with existing top-level types.

Warnings introduced by split

Additionally, many warnings were previously being suppressed, as the event_cache_store module was under active development and not yet exposed publicly. Warning suppression was removed in #5568, but the warnings were not addressed. So, many of the changes deal with addressing warnings or suppressing them where development is still active.

Warnings not introduced by split

Finally, there was an unrelated warning in the crypto_store module introduced in #5537, which complained about the use of a feature that did not exist in the crate - namely, experimental-encrypted-state-events which was used in the cryptostore_integration_tests. This was addressed in the same way that it was addressed in matrix-sdk-sqlite - i.e., by introducing a feature flag in the crate.

Future Work

• Add implementation of remaining functions in MediaStore
• Refactor feature flags
  • The current feature flags are a bit convoluted and could be simplified and made more modular

---

• Public API changes documented in changelogs (optional)

Signed-off-by: Michael Goldenberg [email protected]

[codspeed-hq]

CodSpeed Performance Report

Merging #5676 will not alter performance

_{Comparing mgoldenberg:clean-up-indexeddb-stores (3907724) with main (6818634)}

Summary

✅ 49 untouched

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.40%. Comparing base (8c6922d) to head (3907724).
⚠️ Report is 28 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5676   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         355      355           
  Lines       97713    97713           
  Branches    97713    97713           
=======================================
  Hits        86383    86383           
  Misses       7262     7262           
  Partials     4068     4068           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hywan]

It seems to be mostly code move. Thanks for the cleanup, that's a nice improvement! Thank you for the efforts!