Split media store from event cache store.

[dragonfly1033]

This PR is a start to the process of splitting the media store from the event cache store. #5410

It contains:

• Split MediaStore trait from EventCacheStore.
• Rename EventCacheStoreMedia to MediaStoreInner.
• Move relevant tests into MediaStoreIntegrationTests.

This will be done over 3 PR's (reviewing 1, 2, 3 then merging 3 into 2 into 1).

A reminder comment for my own sanity:
This PR will not pass tests until after merging.

Current state of this PR:

• Step 1 reviewed Split media store from event cache store. #5568
• Step 2 reviewed Part 2 of Split media store from event cache store #5569
• Step 3 reviewed Part 3 of Split media store from event cache store #5571
• Step 3 merged into Step 2
• Step 2 merged into Step 1
• Add changes to changelog.
• Ready to merge 🎉

Note, may also want to:

• Re-organize file structure
• Split/refactor benchmarks namely benchmarks/benches/event_cache.rs

• Public API changes documented in changelogs (optional)

Signed-off-by: Shrey Patel [email protected]

Review was preliminary. New review will be needed aftere CI fixes and changelog entry as planned 🙂

[codspeed-hq]

CodSpeed Performance Report

Merging #5568 will not alter performance

_{Comparing dragonfly1033/split_media_db (8c1ca74) with main (b0c0e0e)}

Summary

✅ 49 untouched benchmarks

[codecov]

Codecov Report

❌ Patch coverage is 71.81303% with 199 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.31%. Comparing base (ce3b67f) to head (8c1ca74).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/matrix-sdk-sqlite/src/media_store.rs	70.80%	53 Missing and 27 partials ⚠️
...trix-sdk-base/src/media/store/integration_tests.rs	85.86%	25 Missing and 1 partial ⚠️
...es/matrix-sdk-base/src/media/store/memory_store.rs	71.26%	25 Missing ⚠️
crates/matrix-sdk-base/src/media/store/traits.rs	45.94%	20 Missing ⚠️
crates/matrix-sdk-base/src/media/store/mod.rs	69.23%	11 Missing and 1 partial ⚠️
crates/matrix-sdk/src/send_queue/upload.rs	50.00%	0 Missing and 8 partials ⚠️
crates/matrix-sdk/src/media.rs	22.22%	6 Missing and 1 partial ⚠️
crates/matrix-sdk-sqlite/src/error.rs	0.00%	5 Missing ⚠️
crates/matrix-sdk/src/client/builder/mod.rs	28.57%	1 Missing and 4 partials ⚠️
...s/matrix-sdk-base/src/media/store/media_service.rs	78.94%	2 Missing and 2 partials ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5568      +/-   ##
==========================================
- Coverage   88.89%   88.31%   -0.58%     
==========================================
  Files         349      353       +4     
  Lines       96546    96750     +204     
  Branches    96546    96750     +204     
==========================================
- Hits        85820    85448     -372     
- Misses       6688     7256     +568     
- Partials     4038     4046       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hywan]

@dragonfly1033 Tell me if you need a last round of review.

[dragonfly1033]

@dragonfly1033 Tell me if you need a last round of review.

Yes please! I've put all the unreviewed changes in the fixup commit. Just waiting for these benches to see if it's all good.

[Hywan]

Thanks for the work! I've left a couple of questions.