-
Notifications
You must be signed in to change notification settings - Fork 375
IndexedDB: Add IndexedDB implementation of LinkedChunk-related functions in EventCacheStore
#5406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IndexedDB: Add IndexedDB implementation of LinkedChunk-related functions in EventCacheStore
#5406
Conversation
…previous_chunk Signed-off-by: Michael Goldenberg <[email protected]>
…_all_linked_chunks Signed-off-by: Michael Goldenberg <[email protected]>
…all_chunks_metadata Signed-off-by: Michael Goldenberg <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5406 +/- ##
==========================================
- Coverage 88.81% 88.81% -0.01%
==========================================
Files 334 334
Lines 91256 91256
Branches 91256 91256
==========================================
- Hits 81051 81048 -3
- Misses 6391 6394 +3
Partials 3814 3814 ☔ View full report in Codecov by Sentry. |
Hywan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! I left a feedback regarding a query made in a loop. Otherwise, it's good! Thanks.
…easy performance tracking Signed-off-by: Michael Goldenberg <[email protected]>
Background
This pull request is part of a series of pull requests to add a full IndexedDB implementation of the
EventCacheStore(see #4617, #4996, #5090, #5138, #5226, #5274, #5343, #5384). This particular pull request focuses on providing implementations for the remainingLinkedChunk-related functions inEventCacheStore.Changes
The changes include implementations of the following functions, as well as tests for each of them.
EventCacheStore::load_all_chunks_metadataEventCacheStore::load_previous_chunkEventCacheStore::clear_all_linked_chunksThere are also two additions to
IndexeddbEventCacheStoreTransactionwhich support the implementation of theEventCacheStore::load_all_chunks_metadata.get_events_count_by_positionget_events_count_by_chunkFuture Work
EventCacheStorefunctions without relying onMemoryStoreSigned-off-by: Michael Goldenberg [email protected]