IndexedDB: Make IndexeddbSerializer shareable between modules in matrix-sdk-indexeddb

[mgoldenberg]

Background

This pull request has a high-level focus on integrating work on an IndexedDB implementation of the EventCacheStore (see #4617). Those changes were rather large and sprawling and included code duplication, so this is part of a series of pull requests which will break that work into smaller, more manageable changes.

Changes

This change is focused on de-duplicating code. In #4617, crypto_store::indexeddb_serializer was copy-and-pasted to event_cache_store::indexeddb_serializer with minor modifications (see here). In preparation for integrating this work, I have made the following changes.

1. Moved the IndexeddbSerializer to the top-level so it may be shared between modules in the crate.
2. Created a new error type, IndexeddbSerializerError to be used with IndexeddbSerializer.
   1. Previously, it was using IndexeddbCryptoStoreError, which was too specific for a generalized use-case.

Additionally, I have prioritized making changes in such a way that does not change the public API of the crate. This means some of the changes weren't as sensible as they could have been, but it helped to keep the pull request small.

Future Work

The next pull request in this series will make additions to the IndexeddbSerializer - there are two functions which #4617 added to its copy of the serializer and which are used by IndexeddbEventCacheStore.

---

• Public API changes documented in changelogs (optional)

Signed-off-by: Michael Goldenberg [email protected]

[mgoldenberg]

Apologies about the failures, I am fixing them now!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.88%. Comparing base (284db61) to head (72da680).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4996      +/-   ##
==========================================
+ Coverage   85.86%   85.88%   +0.02%     
==========================================
  Files         325      325              
  Lines       35851    35851              
==========================================
+ Hits        30783    30791       +8     
+ Misses       5068     5060       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Hywan]

Thanks for your patches. They are making sense to me. Thanks for doing small patches, I appreciate.