IndexedDB: Add IndexedDB implementation of EventCacheStore::load_last_chunk
#5384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Goldenberg <[email protected]>
…last_chunk Signed-off-by: Michael Goldenberg <[email protected]>
… last chunk Signed-off-by: Michael Goldenberg <[email protected]>
…rsions Signed-off-by: Michael Goldenberg <[email protected]>
…ad_last_chunk Signed-off-by: Michael Goldenberg <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5384 +/- ##
==========================================
- Coverage 88.79% 88.79% -0.01%
==========================================
Files 334 334
Lines 91143 91143
Branches 91143 91143
==========================================
- Hits 80928 80927 -1
- Misses 6390 6391 +1
Partials 3825 3825 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Jul 14, 2025
Comment on lines
+467
to
+468
| check_test_event(&items[0], "saucisse de morteau"); | ||
| check_test_event(&items[1], "comté"); |
| }, | ||
| Update::PushItems { | ||
| at: Position::new(ChunkIdentifier::new(7), 0), | ||
| items: vec![event("fondue"), event("gruyère"), event("mont d'or")], |
This was referenced Jul 15, 2025
Merged
This was referenced Aug 6, 2025
1 task
This was referenced Aug 25, 2025
This was referenced Sep 16, 2025
1 task
Merged
1 task
This was referenced Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This pull request is part of a series of pull requests to add a full IndexedDB implementation of the
EventCacheStore(see #4617, #4996, #5090, #5138, #5226, #5274, #5343). This particular pull request focuses on providing an implementation ofEventCacheStore::load_last_chunk.Changes
The primary change is the addition of
EventCacheStore::load_last_chunk, as well as tests for ensuring this is functioning correctly.There are also a number of additions to
IndexeddbEventCacheStoreTransactionwhich support the implementation ofEventCacheStore::load_last_chunk.get_chunk_by_next_chunk_idget_chunks_count_in_roomget_max_chunk_idThese are simply typed wrappers around the generic functions in
IndexeddbEventCacheStoreTransaction.Future Work
EventCacheStorefunctions without relying onMemoryStore.Signed-off-by: Michael Goldenberg [email protected]